From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] x86/msr: Fix fallout from mostly c/s 832c180 Date: Fri, 12 Apr 2019 04:46:25 -0600 Message-ID: <5CB06C810200007800226D79@prv1-mh.provo.novell.com> References: <1554832427-30567-1-git-send-email-andrew.cooper3@citrix.com> <5CADC46B02000078002261CC@prv1-mh.provo.novell.com> <1027d5f4-e133-0717-4fdf-76cafbf07a03@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1027d5f4-e133-0717-4fdf-76cafbf07a03@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper Cc: Kevin Tian , Wei Liu , Xen-devel , Paul Durrant , Jun Nakajima , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDExLjA0LjE5IGF0IDIwOjIwLCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3Jv dGU6Cj4gT24gMTAvMDQvMjAxOSAxMToyNCwgSmFuIEJldWxpY2ggd3JvdGU6Cj4+Pj4+IE9uIDA5 LjA0LjE5IGF0IDE5OjUzLCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+PiBU aGUgc2VyaWVzIDgzMmMxODAzXi4uZjYxNjg1YTYgd2FzIGNvbW1pdHRlZCB3aXRob3V0IGFkZXF1 YXRlIHJldmlldy4KPj4+Cj4+PiAgKiBGaXggdGhlIHNoaW0gYnVpbGQgYnkgcHJvdmlkaW5nIGEg IUNPTkZJR19IVk0gZGVjbGFyYXRpb24gZm9yCj4+PiAgICBodm1fZ2V0X2d1ZXN0X2JuZGNmZ3Mo KQo+Pj4gICogUmV2ZXJ0IHRoZSBib2d1cyBkZS1jb25zdCdpbmcgb2YgdGhlIHZjcHUgcG9pbnRl ciBpbgo+Pj4gICAgdm14X2dldF9ndWVzdF9ibmRjZmdzKCkuICB2bXhfdm1jc19lbnRlcigpIHJl YWxseSBkb2VzIG11dGF0ZSB0aGUgdmNwdSwgYW5kCj4+PiAgICBtYXkgY2F1c2UgaXQgdG8gdW5k ZXJnbyBhIGZ1bGwgZGUvcmVzY2hlZHVsZSwgd2hpY2ggaXMgaW4gdmlvbGF0aW9uIG9mIHRoZQo+ Pj4gICAgQUJJIGRlc2NyaWJlZCBieSBodm1fZ2V0X2d1ZXN0X2JuZGNmZ3MoKS4gIGd1ZXN0X3Jk bXNyKCkgd2FzIGFsd2F5cyBnb2luZwo+Pj4gICAgdG8gbmVlZCB0byBsb3NlIGl0cyBjb25zdCBw YXJhbWV0ZXIsIGFuZCB0aGlzIHdhcyB0aGUgY29ycmVjdCB0aW1lIGZvciBpdAo+Pj4gICAgdG8g aGFwcGVuLgo+PiBJJ2QgbGlrZSB0byBhc2sgZm9yIGEgYmV0dGVyIGV4cGxhbmF0aW9uIG9mIHRo ZSBhY3R1YWwgaXNzdWUgeW91IHNlZQo+PiBoZXJlLiBCeSBkZWNsYXJpbmcgYSBmdW5jdGlvbiBw YXJhbWV0ZXIgcG9pbnRlciB0byBjb25zdCwgbm90aGluZwo+PiB0ZWxscyB0aGUgY29tcGlsZXIg dGhhdCB0aGUgb2JqZWN0IG1heSBub3QgY2hhbmdlIChlLmcuIGFjcm9zcwo+PiBmdW5jdGlvbiBj YWxscyBtYWRlIG91dCBvZiB0aGlzIGZ1bmN0aW9uKS4KPiAKPiBGYWxzZS4KPiAKPj4gQWxsIGl0 IHRlbGxzIHRoZSBjb21waWxlciBpcwo+PiB0aGF0IHRoZSBmdW5jdGlvbiBwcm9taXNlcyB0byBu b3QgaXRzZWxmIGFsdGVyIHRoZSBwb2ludGVkIHRvIG9iamVjdC4KPiAKPiBOb25zZW5zZS4KCkV4 Y3VzZSBtZT8KCj4gIFRoZSBmdW5jdGlvbiBwcm9taXNpbmcgbm90IHRvIGFsdGVyIHRoZSBwb2lu dGVkLXRvLW9iamVjdAo+IGluY2x1ZGVzIHRoZSBlbnRpcmUgY2hpbGQgY2FsbGdyYXBoLgo+IAo+ IAo+IFRoZSBjb2RlIHlvdSBpbnNpc3RlZCBQYXVsIHRvIGFkZCBpczoKPiAKPiBzdHJ1Y3QgdmNw dSAqdiA9IGN2LT5kb21haW4tPnZjcHVbY3YtPnZjcHVfaWRdOwo+IAo+IHdoaWNoIGlzIGlkZW50 aWNhbCB0bzoKPiAKPiBzdHJ1Y3QgdmNwdSAqdiA9IChzdHJ1Y3QgdmNwdSAqKWN2OwoKSXQgaXMg bm90IGlkZW50aWNhbDsgaXQgaXMgaGF2aW5nIHRoZSBzYW1lIGVmZmVjdGl2ZSBiZWhhdmlvciB3 aGVuCmNvbXBpbGVkIHdpdGggdG9kYXkncyBjb21waWxlcnMuCgo+IFdoaWNoIGhpZ2hsaWdodHMg dmVyeSBjbGVhcmx5IHRoYXQgdGhpcyBmdW5jdGlvbiBoYXMgdW5kZWZpbmVkIGJlaGF2aW91ci4K Ckl0IGRvZXNuJ3QsIG5vLgoKPiBBbiBvcHRpbWlzaW5nIGNvbXBpbGVyIHdoaWNoIHVzZXMgYW4g b2JqZWN0LCBhbmQgcGFzc2VzIGEgY29uc3QgcG9pbnRlcgo+IHRvIHRoYXQgb2JqZWN0IHRvIGEg ZnVuY3Rpb24sIGlzIHBlcm1pdHRlZCB0byByZXRhaW4gYXNzdW1wdGlvbnMgZGVyaXZlZAo+IGZy b20gdGhhdCBzdGF0ZSBhY3Jvc3MgdGhlIGZ1bmN0aW9uIGNhbGwgc2VxdWVuY2UgcG9pbnQsIGJl Y2F1c2UgdGhlIEFCSQo+IG9mIHRoZSBmdW5jdGlvbiBzdGF0ZXMgdGhhdCB0aGUgY29udGVudCBv ZiB0aGUgb2JqZWN0IGRvZXNuJ3QgY2hhbmdlLgoKVmVyeSBtdWNoIG5vdCBzbywgbm8uIFRha2Ug dGhpcyBzaW1wbGUgKGFuZCBncmFudGVkIGNvbnRyaXZlZCkKZXhhbXBsZToKCmludCBpbnRlZ2Vy OwoKaW50IHRlc3Qodm9pZCkgewoJZnVuYygmaW50ZWdlcik7CglyZXR1cm4gaW50ZWdlcjsKfQoK YW5kIGluIGEgZGlmZmVyZW50IENVIChqdXN0IHRvIGF2b2lkIHRoZSBlZmZlY3Qgb2YgdGhlIGNv bXBpbGVyCmlubGluaW5nIHRoZSB3aG9sZSB0aGluZykKCnZvaWQgZnVuYyhjb25zdCBpbnQqcGkp IHsKCWludGVnZXIgPSB+KnBpOwp9CgpWYXJpb3VzIG90aGVyIGV4YW1wbGVzIGFyZSBwb3NzaWJs ZSwgaW5jbHVkaW5nIG9uZXMgd2hlcmUKdGhlcmUncyBub3RoaW5nIGNvbnRyaXZlZCBhdCBhbGwu Cgo+IEJ1dCBpZiB5b3UnZCBwcmVmZXIgYSBkaWZmZXJlbnQgYXJndW1lbnQsIGhvdyBhYm91dCBh IGNvbnRyYWRpY3Rpb24uCj4gCj4gQnkgeW91ciBpbnRlcnByZXRhdGlvbiwgdGhlIGNvbnN0IGtl eXdvcmQgaXMgdXR0ZXJseSB1c2VsZXNzIGJlY2F1c2UgYQo+IGNvbXBpbGVyIG11c3QgdHJlYXQg YWxsIGNvbnN0IHBvaW50ZXJzIGFzIG5vbi1jb25zdCwgYmVjYXVzZSB0aGUKPiBwb2ludGVkLXRv IG9iamVjdCBjYW4gY2hhbmdlIGluIGFueSBhcmJpdHJhcnkgd2F5IGF0IGFueSBwb2ludC4gIElm IHRoaXMKPiB3ZXJlIHRoZSBpbnRlbmRlZCBpbnRlcnByZXRhdGlvbiwgY29uc3Qgd291bGQgbmV2 ZXIgaGF2ZSBiZWVuIGFkZGVkIHRvCj4gdGhlIEMgbGFuZ3VhZ2UgYmVjYXVzZSBpdCB3b3VsZCB3 YXN0ZSBzcGFjZSBpbiB0aGUgY29tcGlsZXIgZm9yIDAgZ2Fpbi4KPiAKPiBUaGUgZmFjdCBpdCB3 YXMgYWRkZWQgZGVtb25zdHJhdGVzIHRoYXQgaXQgaGFkIHJlYWwgbWF0ZXJpYWwgZ2FpbnMsCj4g d2hpY2ggbWVhbnMgaXQgaXNuJ3QgYSB1c2VsZXNzIGtleXdvcmQsIHdoaWNoIG1lYW5zIHRoZSBj b21waWxlciByZWFsbHkKPiBtYXkgZGVwZW5kIG9uIHRoZSBjb250ZW50IG9mIGEgY29uc3QgcG9p bnRlZC10by1vYmplY3Qgbm90IGNoYW5naW5nIGF0IGFsbC4KCkkgZG91YnQgdGhpcywgYW5kIHlv dSBwcm92aWRlIG5vIHNvdXJjZSB3aGVyZSB5b3UgdGFrZSBmcm9tIHRoYXQKdGhpcyB3YXMgdGhl IGludGVudGlvbi4gQW5kIGRlc3BpdGUgd2hhdCB5b3Ugc2F5LCAiY29uc3QiIGhhcyBpdHMKdmFs dWUgbmV2ZXJ0aGVsZXNzIC0gaXQgYWxsb3dzIHRoZSBjb21waWxlciB0byB0ZWxsIHlvdSB3aGVu IGEgcGllY2UKb2YgY29kZSBtb2RpZmllcyBhbiBvYmplY3QgdGhhdCB5b3UgZGlkbid0IG1lYW4g dG8gYWx0ZXIuCgpRdW90ZSBmcm9tIHRoZSBsYW5ndWFnZSBzcGVjOgoKIklmIGFuIGF0dGVtcHQg aXMgbWFkZSB0byBtb2RpZnkgYW4gb2JqZWN0IGRlZmluZWQgd2l0aCBhIGNvbnN0LQogcXVhbGlm aWVkIHR5cGUgdGhyb3VnaCB1c2Ugb2YgYW4gbHZhbHVlIHdpdGggbm9uLWNvbnN0LXF1YWxpZmll ZAogdHlwZSwgdGhlIGJlaGF2aW9yIGlzIHVuZGVmaW5lZC4gSWYgYW4gYXR0ZW1wdCBpcyBtYWRl IHRvIHJlZmVyCiB0byBhbiBvYmplY3QgZGVmaW5lZCB3aXRoIGEgdm9sYXRpbGUtcXVhbGlmaWVk IHR5cGUgdGhyb3VnaCB1c2UKIG9mIGFuIGx2YWx1ZSB3aXRoIG5vbi12b2xhdGlsZS1xdWFsaWZp ZWQgdHlwZSwgdGhlIGJlaGF2aW9yIGlzCiB1bmRlZmluZWQuIgoKQW5kIHRoZSByZXNwZWN0aXZl IGZvb3Rub3RlOgoKIlRoaXMgYXBwbGllcyB0byB0aG9zZSBvYmplY3RzIHRoYXQgYmVoYXZlIGFz IGlmIHRoZXkgd2VyZQogZGVmaW5lZCB3aXRoIHF1YWxpZmllZCB0eXBlcywgZXZlbiBpZiB0aGV5 IGFyZSBuZXZlciBhY3R1YWxseQogZGVmaW5lZCBhcyBvYmplY3RzIGluIHRoZSBwcm9ncmFtIChz dWNoIGFzIGFuIG9iamVjdCBhdCBhCiBtZW1vcnktbWFwcGVkIGlucHV0L291dHB1dCBhZGRyZXNz KS4iCgpUaHJvdWdob3V0IHRoZSB2ZXJiIHVzZWQgaXMgImRlZmluZWQiLCBub3QgImRlY2xhcmVk Ii4gSWYgYW55CnN0cnVjdCB2Y3B1IGluc3RhbmNlIGFjdHVhbGx5IGxpdmVkIGluIC5yb2RhdGEg KGZvciBleGFtcGxlKSwKdGhlbiAod2l0aG91dCBjYXN0aW5nIGF3YXkgY29uc3RuZXNzKSBpdCB3 b3VsZCBiZSBpbXBvc3NpYmxlIHRvCmNvbnN0cnVjdCBhIG5vbi1jb25zdCBwb2ludGVyIHRvIGl0 LiBIZW5jZSB0aGVyZSB3b3VsZCBiZSBubwpsZWdpdGltYXRlIG1lYW5zIHRvIGNyZWF0ZSBhIHdh eSB0byBtb2RpZnkgdGhhdCBpbnN0YW5jZS4gQnV0CnRoYXQncyBzcGVjaWZpY2FsbHkgbm90IHRo ZSBjYXNlIGhlcmUgKG9yIGluIHRoZSBleGFtcGxlIGdpdmVuKS4KCj4+PiAgKiBSZW1vdmUgdGhl IGludHJvZHVjZWQgQVNTRVJUKGlzX2h2bV9kb21haW4oZCkpIGFuZCBjaGVjayB0aGUgcHJlZGlj YXRlCj4+PiAgICBkaXJlY3RseS4gIFdoaWxlIHdlIGV4cGVjdCBpdCB0byBiZSB0cnVlLCB0aGUg cmVzdWx0IGlzIHBvdGVudGlhbCB0eXBlCj4+PiAgICBjb25mdXNpb24gaW4gcmVsZWFzZSBidWls ZHMgYmFzZWQgb24gc2V2ZXJhbCBzdWJ0bGUgYXNwZWN0cyBvZiB0aGUgQ1BVSUQKPj4+ICAgIGZl YXR1cmUgZGVyaXZhdGlvbiBsb2dpYyB3aXRoIG5vIG90aGVyIHNhZmV0eSBjaGVja3MuICBUaGlz IGFsc28gZml4ZXMgdGhlCj4+PiAgICBhIGxpbmtlciBlcnJvciBpbiB0aGUgcmVsZWFzZSBidWls ZCBvZiB0aGUgc2hpbSwgYWdhaW4gZm9yICFDT05GSUdfSFZNCj4+PiAgICByZWFzb25zLgo+PiBJ IGRvbid0IHVuZGVyc3RhbmQgIm5vIG90aGVyIHNhZmV0eSBjaGVja3MiOiBUbyBtZSB0aGUgIlMi IGluCj4+Cj4+IFhFTl9DUFVGRUFUVVJFKE1QWCwgICAgICAgICAgIDUqMzIrMTQpIC8qUyAgTWVt b3J5IFByb3RlY3Rpb24gRXh0ZW5zaW9ucyAqLwo+Pgo+PiBpcyBjbGVhciBlbm91Z2guIFdoaWxl IHBlcmhhcHMgbm90IHRvd2FyZHMgInBvdGVudGlhbCB0eXBlIGNvbmZ1c2lvbiIKPiAKPiAidHlw ZSBjb25mdXNpb24iIGhlcmUgaXMgbWl4aW5nIHVwIHYtPmFyY2guaHZtIGFuZCB2LT5hcmNoLnB2 LCB3aGljaCBpcwo+IHdoYXQgaGFwcGVucyB3aGVuIHlvdSd2ZSBhY3R1YWxseSBnb3QgYSBQViB2 Y3B1IGFuZCB5b3UgY2FsbCBhbiBodm1fKgo+IGZ1bmN0aW9uLgo+IAo+ICJObyBvdGhlciBzYWZl dHkgY2hlY2tzIiBtZWFucyB0aGF0IGNwLT5mZWF0Lm1weCBiZWNvbWluZyBhY2NpZGVudGFsbHkK PiBzZXQgcmVzdWx0cyBpbiBiYWQgdGhpbmdzIGhhcHBlbmluZyBpZiBhIFBWIGFuZCBIVk0gdmNw dSBnZXQgbWl4ZWQgdXAuCgpJZiB3aGF0ZXZlciBiaXQgLyBmaWVsZCAvIHZhcmlhYmxlIGFjY2lk ZW50YWxseSBnYWlucyBhIHdyb25nIHZhbHVlLApiYWQgdGhpbmdzIGFyZSBnb2luZyB0byBiZSBo YXBwZW5pbmcuIFRoZXJlJ3Mgbm8gZXNjYXBlIGZyb20gdGhpcy4KCj4gSXQgaXMgc2FtZSByZWFz b25pbmcgd2hpY2ggY2F1c2VzIHVzIHRvIGRvIHRoaXM6Cj4gCj4gaWYgKCAhY29uZCApCj4gewo+ ICAgICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsKPiAgICAgZ290byBzb21ldGhpbmdfc2FmZXI7Cj4g fQo+IAo+IHJhdGhlciB0aGFuIEFTU0VSVChjb25kKQoKUmlnaHQsIGFuZCBqdXN0IHRvIHJlbWlu ZCB5b3U6IEknbSBub3Qgb2JqZWN0aW5nIHRvIHRoZSBjaGFuZ2UKaXRzZWxmLiBJIGRpc2xpa2Ug aG93IHlvdSBjYWxsIGl0IGFsbCBicm9rZW4gd2l0aG91dCBkZW1vbnN0cmF0aW5nIGl0cwpicm9r ZW5uZXNzLiBJJ2QgbGlrZSB0byBhZGQgdGhvdWdoIHRoYXQgdGhpcyBwYXJ0IG9mIHRoZSBwYXRj aApkZXNjcmlwdGlvbiBpcyBwZXJoYXBzIGFjY2VwdGFibGUsIGlmIHRoZXJlIHdhc24ndCB0aGUg b3ZlcmFsbAppbml0aWFsIHN0YXRlbWVudCByZWdhcmRpbmcgImFkZXF1YXRlIHJldmlldyIuCgo+ PiBhcyB5b3Ugd29yZCBpdCwgdGhlcmUgYXJlIG90aGVyIGNhc2VzIHdoZXJlIHdlIG1ha2UgaW1w bGljYXRpb25zCj4+IGZyb20gdGhlIHNjb3BlIHN0YXRlZCBpbiB0aGUgcHVibGljIGhlYWRlcjog TVNSX0ZMVVNIX0NNRCwgZm9yCj4+IGV4YW1wbGUsIGlzIHN1cHBvc2VkIHRvIGJlIGluYWNjZXNz aWJsZSB0byBQViBndWVzdHMsIGJ1dCB0aGVyZSdzIG5vCj4+IGV4cGxpY2l0ICFQViBjaGVjayBp biBpdHMgaGFuZGxpbmcgY29kZS4KPiAKPiBOb3RoaW5nIHdpdGggdGhlIGhhbmRsaW5nIG9mIEZM VVNIX0NNRCBnZXRzIGludG8gYW55IGZvcm0gb2YgVUIKPiB3aGF0c29ldmVyIGlmIGNwLT5mZWF0 LmwxZF9mbHVzaCBiZWNvbWVzIGFjY2lkZW50YWxseSBzZXQgZm9yIGEgUFYgZ3Vlc3QuCgpNaW5k IG1lIGFkanVzdGluZyB0aGlzIHRvICJOb3RoaW5nIC4uLiBjdXJyZW50bHkgZ2V0cyBpbnRvIC4u LiI/Cgo+PiAgSSB3b3VsZCBjYWxsIHRoZSBjdXJyZW50IHN0YXRlCj4+IGFzIGluY29uc2lzdGVu dCAoc2VlaW5nIGUuZy4gZ3Vlc3Rfe3JkLHdyfW1zcl94MmFwaWMoKSBhZ2FpbiBiZWluZwo+PiBi ZWhpbmQgaXNfaHZtX2RvbWFpbigpIGNoZWNrcyksIGFuZCBoZW5jZSBpdCdzIG5vdCByZWFsbHkg cG9zc2libGUKPj4gdG8gZGVyaXZlIGluIHdoaWNoIGNhc2Ugd2hpY2ggYXBwcm9hY2ggaXMgdG8g YmUgcHJlZmVycmVkIChvciwgYXMgaW4KPj4gdGhlIGNhc2UgaGVyZSwgd291bGQgYmUgb2JqZWN0 ZWQgdG8pLgo+IAo+IFRoZSB2ZXJ5IGZpcnN0IHRoaW5nIGd1ZXN0X3tyZCx3cn1tc3JfeDJhcGlj KCkgZG9lcyBpcyBvcGVyYXRlIG9uCj4gdi0+YXJjaC5odm0KCkJ1dCBhbG9uZyB0aGUgbGluZXMg b2YgdGhlIHByZXZpb3VzIGNvbW1lbnQ6IEkgdGhpbmsgdGhlIGNoZWNraW5nCmRvbmUgaW4gdGhl IGNhbGxlciBzaG91bGQgbm90IGRlcGVuZCBvbiBpbXBsZW1lbnRhdGlvbiBkZXRhaWxzIG9mCnRo ZSBjYWxsZWUuIEl0IHNob3VsZCBiZSBjb25zaXN0ZW50IGluIGl0c2VsZi4KCj4gQW55d2F5LCBh cyB3YXMgaW5jbHVkZWQgaW4gdGhlIGJ1bGxldCBwb2ludCwgdGhlIGlzX2h2bV9kb21haW4oKSBj aGVjawo+IGlzIGEgY3JpdGljYWwgcGFydCBvZiBtYWtpbmcgdGhlIHNoaW0gYnVpbGQgd29yaywg Z2l2ZW4gdGhhdCBpdCBkZXBlbmRzCj4gb24gZGVhZCBjb2RlIGVsaW1pbmF0aW9uLiAgT21pdHRp bmcgdGhlIGlzX2h2bV9kb21haW4oKSBjaGVjayByZWFsbHkKPiBkb2VzIHJlc3VsdCBpbiBhIGxp bmsgZXJyb3IuCgpUaGlzIGlzIG9uZSB3YXkgb2YgYWRkcmVzc2luZyB0aGUgYnVpbGQgcHJvYmxl bSwgYnV0IG5vdCB0aGUgb25seQpvbmUuIFlldCBhZ2FpbiAtIEknbSBva2F5IHdpdGggdGhlIGNv ZGUgY2hhbmdlcyB5b3UgcHJvcG9zZSwgYnV0CnBsZWFzZSB3aXRoIGEgbW9yZSBjaXZpbCAoYW5k LCBpbiB0aGUgY2FzZSBvZiB0aGUgY29uc3QgYXNwZWN0LApmYWN0dWFsbHkgY29ycmVjdCkgZGVz Y3JpcHRpb24uCgpKYW4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRl dmVs