From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] x86/msr: Fix fallout from mostly c/s 832c180 Date: Fri, 12 Apr 2019 08:57:33 -0600 Message-ID: <5CB0A75D0200007800226EF6@prv1-mh.provo.novell.com> References: <1554832427-30567-1-git-send-email-andrew.cooper3@citrix.com> <5CADC46B02000078002261CC@prv1-mh.provo.novell.com> <1027d5f4-e133-0717-4fdf-76cafbf07a03@citrix.com> <5CB06C810200007800226D79@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper Cc: Kevin Tian , Wei Liu , Xen-devel , Paul Durrant , Jun Nakajima , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDEyLjA0LjE5IGF0IDE1OjUyLCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3Jv dGU6Cj4gT24gMTIvMDQvMjAxOSAxMTo0NiwgSmFuIEJldWxpY2ggd3JvdGU6Cj4+Cj4+PiAgVGhl IGZ1bmN0aW9uIHByb21pc2luZyBub3QgdG8gYWx0ZXIgdGhlIHBvaW50ZWQtdG8tb2JqZWN0Cj4+ PiBpbmNsdWRlcyB0aGUgZW50aXJlIGNoaWxkIGNhbGxncmFwaC4KPj4+Cj4+Pgo+Pj4gVGhlIGNv ZGUgeW91IGluc2lzdGVkIFBhdWwgdG8gYWRkIGlzOgo+Pj4KPj4+IHN0cnVjdCB2Y3B1ICp2ID0g Y3YtPmRvbWFpbi0+dmNwdVtjdi0+dmNwdV9pZF07Cj4+Pgo+Pj4gd2hpY2ggaXMgaWRlbnRpY2Fs IHRvOgo+Pj4KPj4+IHN0cnVjdCB2Y3B1ICp2ID0gKHN0cnVjdCB2Y3B1ICopY3Y7Cj4+IEl0IGlz IG5vdCBpZGVudGljYWw7IGl0IGlzIGhhdmluZyB0aGUgc2FtZSBlZmZlY3RpdmUgYmVoYXZpb3Ig d2hlbgo+PiBjb21waWxlZCB3aXRoIHRvZGF5J3MgY29tcGlsZXJzLgo+Pgo+Pj4gV2hpY2ggaGln aGxpZ2h0cyB2ZXJ5IGNsZWFybHkgdGhhdCB0aGlzIGZ1bmN0aW9uIGhhcyB1bmRlZmluZWQgYmVo YXZpb3VyLgo+PiBJdCBkb2Vzbid0LCBuby4KPiAKPiBZZXMgaXQgbGl0ZXJhbGx5IGRvZXMsIGFu ZCBldmVuIGluIHRoZSB2ZXJ5IGZpcnN0IHNlbnRlbmNlIHlvdSBxdW90ZWQuCj4gCj4gUmVwcm9k dWNlZCBoZXJlOgo+IAo+PiAiSWYgYW4gYXR0ZW1wdCBpcyBtYWRlIHRvIG1vZGlmeSBhbiBvYmpl Y3QgZGVmaW5lZCB3aXRoIGEgY29uc3QtCj4+ICBxdWFsaWZpZWQgdHlwZSB0aHJvdWdoIHVzZSBv ZiBhbiBsdmFsdWUgd2l0aCBub24tY29uc3QtcXVhbGlmaWVkCj4+ICB0eXBlLCB0aGUgYmVoYXZp b3IgaXMgdW5kZWZpbmVkLgo+IAo+IFRoZXJlIGlzIGV4YWN0bHkgb25lIG9iamVjdCBmb3IgdGhp cyB2Y3B1Lgo+IAo+ICpjdiwgYXMgZGVmaW5lZCBieSB0aGUgcHJvdG90eXBlLCBpcyBjb25zdCBx dWFsaWZpZWQsIGFuZCBpcyB0aGlzIG9iamVjdC4KPiAKPiAqdiBpcyB0aGUgc2FtZSBvYmplY3Qs IGFuZCBtdXRhdGVzIGl0LgoKQnV0IHRoZXNlIGFyZSBfZGVjbGFyYXRpb25zXywgbm90IF9kZWZp bml0aW9uc18uCgo+IEMgZG9lc24ndCBuZWNlc3NhcmlseSBrbm93IHRoYXQgImN2LT5kb21haW4t PnZjcHVbY3YtPnZjcHVfaWRdID09IGN2IiwKPiBidXQgaXQgcmVhbGx5IGlzIGFuIGFsaWFzIGlu IHByYWN0aWNlLCBhbmQgdGhlcmVmb3JlIGlzIFVCIHVuZGVyIHRoYXQgcnVsZS4KCkFzIHBlciBh Ym92ZSwgdGhpcyBydWxlIG1ha2VzIGl0IFVCIG9ubHkgaWYgdGhlIG9iamVjdCBfZGVmaW5pdGlv bl8Kd2FzIChlZmZlY3RpdmVseSwgYXMgcGVyIHRoZSBmb290bm90ZSkgY29uc3QuCgo+Pj4gQW4g b3B0aW1pc2luZyBjb21waWxlciB3aGljaCB1c2VzIGFuIG9iamVjdCwgYW5kIHBhc3NlcyBhIGNv bnN0IHBvaW50ZXIKPj4+IHRvIHRoYXQgb2JqZWN0IHRvIGEgZnVuY3Rpb24sIGlzIHBlcm1pdHRl ZCB0byByZXRhaW4gYXNzdW1wdGlvbnMgZGVyaXZlZAo+Pj4gZnJvbSB0aGF0IHN0YXRlIGFjcm9z cyB0aGUgZnVuY3Rpb24gY2FsbCBzZXF1ZW5jZSBwb2ludCwgYmVjYXVzZSB0aGUgQUJJCj4+PiBv ZiB0aGUgZnVuY3Rpb24gc3RhdGVzIHRoYXQgdGhlIGNvbnRlbnQgb2YgdGhlIG9iamVjdCBkb2Vz bid0IGNoYW5nZS4KPj4gVmVyeSBtdWNoIG5vdCBzbywgbm8uIFRha2UgdGhpcyBzaW1wbGUgKGFu ZCBncmFudGVkIGNvbnRyaXZlZCkKPj4gZXhhbXBsZToKPj4KPj4gaW50IGludGVnZXI7Cj4+Cj4+ IGludCB0ZXN0KHZvaWQpIHsKPj4gCWZ1bmMoJmludGVnZXIpOwo+PiAJcmV0dXJuIGludGVnZXI7 Cj4+IH0KPj4KPj4gYW5kIGluIGEgZGlmZmVyZW50IENVIChqdXN0IHRvIGF2b2lkIHRoZSBlZmZl Y3Qgb2YgdGhlIGNvbXBpbGVyCj4+IGlubGluaW5nIHRoZSB3aG9sZSB0aGluZykKPj4KPj4gdm9p ZCBmdW5jKGNvbnN0IGludCpwaSkgewo+PiAJaW50ZWdlciA9IH4qcGk7Cj4+IH0KPj4KPj4gVmFy aW91cyBvdGhlciBleGFtcGxlcyBhcmUgcG9zc2libGUsIGluY2x1ZGluZyBvbmVzIHdoZXJlCj4+ IHRoZXJlJ3Mgbm90aGluZyBjb250cml2ZWQgYXQgYWxsLgo+IAo+IEhvdyBhYm91dCBhIGNvbmNy ZXRlIGV4YW1wbGUgd2hpY2ggbWF0Y2hlcyB0aGUgY29kZSBwYXR0ZXJuIHVuZGVyCj4gYXJndW1l bnQgYW5kIGRlbW9uc3RyYXRlcyB0aGUgaXNzdWUuCj4gCj4gdm9pZCBmdW5jKGNvbnN0IGludCAq cGkpCj4gewo+ICAgICBpbnQgKmkgPSAoaW50ICopcGk7CgpUbyBnaXZlIGEgdmFsaWQgZXhhbXBs ZSwgeW91IG5lZWQgdG8gZ2V0IGF3YXkgd2l0aG91dCBjYXN0aW5nCmF3YXkgY29uc3QtbmVzcy4g VGhpcyBpcyB0aGUgcmVhbCBkaWZmZXJlbmNlIGJldHdlZW4gd2hhdCB5b3UKY29ycmVjdGx5IG5h bWUgVUIgYW5kIHdoYXQgSSBoYWQgc3VnZ2VzdGVkIHdoaWxlIHJldmlld2luZwpQYXVsJ3MgcGF0 Y2guCgo+ICAgICAqaSA9IDY7Cj4gfQo+IAo+IEFuZCBpbiBhIHNlcGFyYXRlIHRyYW5zbGF0aW9u IHVuaXQuCj4gCj4gaW50IHRlc3Qodm9pZCkKPiB7Cj4gICAgIGNvbnN0IGludCBpID0gNDsKPiAK PiAgICAgZnVuYygmaSk7Cj4gICAgIGFzc2VydChpID09IDQpOwo+IAo+ICAgICByZXR1cm4gaTsK PiB9Cj4gCj4gRnVubmlseSBlbm91Z2gsIHRoZSBhc3NlcnQgbmV2ZXIgdHJpZ2dlcnMuICBFdmVu IGF0IC1PMCwgaXQgbmV2ZXIgZ2V0cwo+IGNvbXBpbGVkIGluIGFuZCB0ZXN0IGhhcyBpdHMgcmV0 dXJuIHZhbHVlIGluIHRoZSBmb3JtIGBtb3YgJDQsICVlYXg7Cj4gcmV0YCwgYW5kIHRoZSBvbmx5 IHdheSB0aGF0IG9jY3VycyBpcyBiZWNhdXNlIG9mIHRoZSBVQi4KClN1cmUgLSBldmVuIHdpdGhv dXQgYW55IG9wdGltaXphdGlvbiB0aGUgY29tcGlsZXIgc2VlcyB0aGUgY29uc3QKb24gdGhlIF9k ZWZpbml0aW9uXyBvZiBpLgoKPj4+IEJ1dCBpZiB5b3UnZCBwcmVmZXIgYSBkaWZmZXJlbnQgYXJn dW1lbnQsIGhvdyBhYm91dCBhIGNvbnRyYWRpY3Rpb24uCj4+Pgo+Pj4gQnkgeW91ciBpbnRlcnBy ZXRhdGlvbiwgdGhlIGNvbnN0IGtleXdvcmQgaXMgdXR0ZXJseSB1c2VsZXNzIGJlY2F1c2UgYQo+ Pj4gY29tcGlsZXIgbXVzdCB0cmVhdCBhbGwgY29uc3QgcG9pbnRlcnMgYXMgbm9uLWNvbnN0LCBi ZWNhdXNlIHRoZQo+Pj4gcG9pbnRlZC10byBvYmplY3QgY2FuIGNoYW5nZSBpbiBhbnkgYXJiaXRy YXJ5IHdheSBhdCBhbnkgcG9pbnQuICBJZiB0aGlzCj4+PiB3ZXJlIHRoZSBpbnRlbmRlZCBpbnRl cnByZXRhdGlvbiwgY29uc3Qgd291bGQgbmV2ZXIgaGF2ZSBiZWVuIGFkZGVkIHRvCj4+PiB0aGUg QyBsYW5ndWFnZSBiZWNhdXNlIGl0IHdvdWxkIHdhc3RlIHNwYWNlIGluIHRoZSBjb21waWxlciBm b3IgMCBnYWluLgo+Pj4KPj4+IFRoZSBmYWN0IGl0IHdhcyBhZGRlZCBkZW1vbnN0cmF0ZXMgdGhh dCBpdCBoYWQgcmVhbCBtYXRlcmlhbCBnYWlucywKPj4+IHdoaWNoIG1lYW5zIGl0IGlzbid0IGEg dXNlbGVzcyBrZXl3b3JkLCB3aGljaCBtZWFucyB0aGUgY29tcGlsZXIgcmVhbGx5Cj4+PiBtYXkg ZGVwZW5kIG9uIHRoZSBjb250ZW50IG9mIGEgY29uc3QgcG9pbnRlZC10by1vYmplY3Qgbm90IGNo YW5naW5nIGF0IGFsbC4KPj4gSSBkb3VidCB0aGlzLCBhbmQgeW91IHByb3ZpZGUgbm8gc291cmNl IHdoZXJlIHlvdSB0YWtlIGZyb20gdGhhdAo+PiB0aGlzIHdhcyB0aGUgaW50ZW50aW9uLiBBbmQg ZGVzcGl0ZSB3aGF0IHlvdSBzYXksICJjb25zdCIgaGFzIGl0cwo+PiB2YWx1ZSBuZXZlcnRoZWxl c3MgLSBpdCBhbGxvd3MgdGhlIGNvbXBpbGVyIHRvIHRlbGwgeW91IHdoZW4gYSBwaWVjZQo+PiBv ZiBjb2RlIG1vZGlmaWVzIGFuIG9iamVjdCB0aGF0IHlvdSBkaWRuJ3QgbWVhbiB0byBhbHRlci4K Pj4KPj4gUXVvdGUgZnJvbSB0aGUgbGFuZ3VhZ2Ugc3BlYzoKPj4KPj4gIklmIGFuIGF0dGVtcHQg aXMgbWFkZSB0byBtb2RpZnkgYW4gb2JqZWN0IGRlZmluZWQgd2l0aCBhIGNvbnN0LQo+PiAgcXVh bGlmaWVkIHR5cGUgdGhyb3VnaCB1c2Ugb2YgYW4gbHZhbHVlIHdpdGggbm9uLWNvbnN0LXF1YWxp ZmllZAo+PiAgdHlwZSwgdGhlIGJlaGF2aW9yIGlzIHVuZGVmaW5lZC4gSWYgYW4gYXR0ZW1wdCBp cyBtYWRlIHRvIHJlZmVyCj4+ICB0byBhbiBvYmplY3QgZGVmaW5lZCB3aXRoIGEgdm9sYXRpbGUt cXVhbGlmaWVkIHR5cGUgdGhyb3VnaCB1c2UKPj4gIG9mIGFuIGx2YWx1ZSB3aXRoIG5vbi12b2xh dGlsZS1xdWFsaWZpZWQgdHlwZSwgdGhlIGJlaGF2aW9yIGlzCj4+ICB1bmRlZmluZWQuIgo+Pgo+ PiBBbmQgdGhlIHJlc3BlY3RpdmUgZm9vdG5vdGU6Cj4+Cj4+ICJUaGlzIGFwcGxpZXMgdG8gdGhv c2Ugb2JqZWN0cyB0aGF0IGJlaGF2ZSBhcyBpZiB0aGV5IHdlcmUKPj4gIGRlZmluZWQgd2l0aCBx dWFsaWZpZWQgdHlwZXMsIGV2ZW4gaWYgdGhleSBhcmUgbmV2ZXIgYWN0dWFsbHkKPj4gIGRlZmlu ZWQgYXMgb2JqZWN0cyBpbiB0aGUgcHJvZ3JhbSAoc3VjaCBhcyBhbiBvYmplY3QgYXQgYQo+PiAg bWVtb3J5LW1hcHBlZCBpbnB1dC9vdXRwdXQgYWRkcmVzcykuIgo+Pgo+PiBUaHJvdWdob3V0IHRo ZSB2ZXJiIHVzZWQgaXMgImRlZmluZWQiLCBub3QgImRlY2xhcmVkIi4gSWYgYW55Cj4+IHN0cnVj dCB2Y3B1IGluc3RhbmNlIGFjdHVhbGx5IGxpdmVkIGluIC5yb2RhdGEgKGZvciBleGFtcGxlKSwK Pj4gdGhlbiAod2l0aG91dCBjYXN0aW5nIGF3YXkgY29uc3RuZXNzKSBpdCB3b3VsZCBiZSBpbXBv c3NpYmxlIHRvCj4+IGNvbnN0cnVjdCBhIG5vbi1jb25zdCBwb2ludGVyIHRvIGl0LiBIZW5jZSB0 aGVyZSB3b3VsZCBiZSBubwo+PiBsZWdpdGltYXRlIG1lYW5zIHRvIGNyZWF0ZSBhIHdheSB0byBt b2RpZnkgdGhhdCBpbnN0YW5jZS4gQnV0Cj4+IHRoYXQncyBzcGVjaWZpY2FsbHkgbm90IHRoZSBj YXNlIGhlcmUgKG9yIGluIHRoZSBleGFtcGxlIGdpdmVuKS4KPiAKPiBBIGZ1bmN0aW9uIHdoaWNo IHRha2VzIGEgY29uc3QgdmNwdSogZG9lcyBub3Qga25vdywgYW5kIGhhcyBubyB3YXkgb2YKPiBw cm92aW5nLCB0aGF0IHRoZSBvYmplY3QgcmVhbGx5IHdhc24ndCBjb25zdC4KCkV4YWN0bHkuIFdo aWNoIGlzIHdoeSB0aGUgY29tcGlsZXIgY2FuJ3QgZGVyaXZlIGFueXRoaW5nIGZvciBpdHMKb3du IGNvZGUgZ2VuZXJhdGlvbiBwdXJwb3Nlcy4KCj4gSSB3aWxsIGFkbWl0IHRoYXQgSSBtYWRlIGEg bWFkZSBhIG1pc3Rha2Ugd2l0aCB0aGUgb3B0aW1pc2F0aW9uIGNsYWltLiAKPiBUaGUgb3V0ZXIg ZnVuY3Rpb24sIGJlY2F1c2UgaXQgY2FuJ3Qgc2VlIHRoZSBkZWNsYXJhdGlvbiBvZiB0aGUgb2Jq ZWN0Cj4gaXRzZWxmLCBhbHNvIGNhbid0IGFzc3VtZSB0aGVyZSBhcmVuJ3Qgb3RoZXIgYWxpYXNl cy4KCkFuZCB0aGlzIGlzIHRydWUgdGhyb3VnaG91dCB0aGUgY29kZSwgbm90IGp1c3QgZm9yIHRo ZSBvdXRlcgpmdW5jdGlvbi4KCj4gQnV0IG5vbmUgb2YgdGhpcyBzdG9wcyB0aGUgY2FzdGluZyBh d2F5IG9mIGNvbnN0IGJlaW5nIFVCLCBhbmQgaXQgc3RpbGwKPiByZW1haW5zIGNvbXBsZXRlbHkg ZGlzaG9uZXN0IHByb2dyYW1taW5nIHRvIGRlY2xhcmUKPiB2bXhfc2V0X2d1ZXN0X2JuZGNmZ3Mo KSBhcyB0YWtpbmcgYSBjb25zdCB2Y3B1LCBhbmQgdGhlbiBtb2RpZnlpbmcgaXQuCgpXZWxsLCBJ IHdhcyBhd2FyZSB0aGF0IHRoZSBjb25zdHJ1Y3QgbWlnaHQgbm90IGJlIGxpa2VkLCBhbmQgaGVu Y2UKSSBoYWQgc3BlY2lmaWNhbGx5IGNhbGxlZCBmb3Igb3BpbmlvbnMuIE5ldmVydGhlbGVzcyBp dCdzIG5vdCBhdCBhbGwKImRpc2hvbmVzdCBwcm9ncmFtbWluZyIgdG8gbWUuIFF1aXRlIHRoZSBp bnZlcnNlIC0gSSB0aGluayB0aGUgVk1DUwplbnRlci9leGl0IGxvZ2ljIHNob3VsZCBoYXZlIGJl ZW4gd3JpdHRlbiB0aGlzIHdheSBmcm9tIHRoZSBiZWdpbm5pbmcuCkFmdGVyIGFsbCBpdCdzIG5v dCB0aGUgZmlyc3QgdGltZSB0aGF0IGJlY2F1c2Ugb2YgaXRzIGludGVybmFsIHdvcmtpbmdzCnNv bWV0aGluZyBlbHNlIGNhbiBnZXQgY29uc3QgYWRkZWQuCgpBbmQgYnR3LCBDKysgc3BlY2lmaWNh bGx5IGhhcyB0aGUgIm11dGFibGUiIGtleXdvcmQgdG8gb3ZlcnJpZGUKY29uc3QgaW4gY2VydGFp biAoc3BlY2lhbCkgY2FzZXMuCgpJIGNhbiBhY2NlcHQgdGhvdWdoIHRoYXQgeW91IGFuZCBtYXli ZSBvdGhlcnMgZG9uJ3QgYWdyZWUgd2l0aApteSB2aWV3IGhlcmUsIGFuZCBoZW5jZSAoYXMgZXhw cmVzc2VkIGJlZm9yZSkgSSdtIG5vdCBpbnNpc3RpbmcKb24gaXQgc3RheWluZyB0aGUgd2F5IGl0 IGlzIHJpZ2h0IG5vdy4KCkphbgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnBy b2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94 ZW4tZGV2ZWw=