From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH 2/3] IOMMU/x86: make page type checks consistent when mapping pages Date: Tue, 14 May 2019 05:17:01 -0600 Message-ID: <5CDAA3AD020000780022E878@prv1-mh.provo.novell.com> References: <5C7E77D1020000780021BB0B@prv1-mh.provo.novell.com> <5C7E78F6020000780021BB21@prv1-mh.provo.novell.com> <3172ee3f-0800-99a5-e148-d10ecdfd51a8@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQVQl-00008I-Jm for xen-devel@lists.xenproject.org; Tue, 14 May 2019 11:17:11 +0000 In-Reply-To: <3172ee3f-0800-99a5-e148-d10ecdfd51a8@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: george.dunlap@citrix.com Cc: George Dunlap , Andrew Cooper , Juergen Gross , xen-devel List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDEzLjA1LjE5IGF0IDE1OjQ0LCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPiB3cm90 ZToKPiBPbiAzLzUvMTkgMToyNiBQTSwgSmFuIEJldWxpY2ggd3JvdGU6Cj4+IC0tLSBhL3hlbi9k cml2ZXJzL3Bhc3N0aHJvdWdoL2lvbW11LmMKPj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvaW9tbXUuYwo+PiBAQCAtMTkyLDIxICsxOTIsMjcgQEAgdm9pZCBfX2h3ZG9tX2luaXQgaW9t bXVfaHdkb21faW5pdChzdHJ1Ywo+PiAgCj4+ICAgICAgICAgIHBhZ2VfbGlzdF9mb3JfZWFjaCAo IHBhZ2UsICZkLT5wYWdlX2xpc3QgKQo+PiAgICAgICAgICB7Cj4+IC0gICAgICAgICAgICB1bnNp Z25lZCBsb25nIG1mbiA9IG1mbl94KHBhZ2VfdG9fbWZuKHBhZ2UpKTsKPj4gLSAgICAgICAgICAg IHVuc2lnbmVkIGxvbmcgZGZuID0gbWZuX3RvX2dtZm4oZCwgbWZuKTsKPj4gLSAgICAgICAgICAg IHVuc2lnbmVkIGludCBtYXBwaW5nID0gSU9NTVVGX3JlYWRhYmxlOwo+PiAtICAgICAgICAgICAg aW50IHJldDsKPj4gKyAgICAgICAgICAgIGlmICggKHBhZ2UtPnUuaW51c2UudHlwZV9pbmZvICYg UEdUX3R5cGVfbWFzaykgPT0gUEdUX25vbmUgKQo+PiArICAgICAgICAgICAgewo+PiArICAgICAg ICAgICAgICAgIEFTU0VSVCghKHBhZ2UtPnUuaW51c2UudHlwZV9pbmZvICYgUEdUX2NvdW50X21h c2spKTsKPj4gKyAgICAgICAgICAgICAgICBpZiAoIGdldF9wYWdlX2FuZF90eXBlKHBhZ2UsIGQs IFBHVF93cml0YWJsZV9wYWdlKSApCj4+ICsgICAgICAgICAgICAgICAgICAgIHB1dF9wYWdlX2Fu ZF90eXBlKHBhZ2UpOwo+PiArICAgICAgICAgICAgICAgIGVsc2UgaWYgKCAhcmMgKQo+PiArICAg ICAgICAgICAgICAgICAgICByYyA9IC1FQlVTWTsKPj4gKyAgICAgICAgICAgIH0KPj4gIAo+PiAt ICAgICAgICAgICAgaWYgKCAoKHBhZ2UtPnUuaW51c2UudHlwZV9pbmZvICYgUEdUX2NvdW50X21h c2spID09IDApIHx8Cj4+IC0gICAgICAgICAgICAgICAgICgocGFnZS0+dS5pbnVzZS50eXBlX2lu Zm8gJiBQR1RfdHlwZV9tYXNrKQo+PiAtICAgICAgICAgICAgICAgICAgPT0gUEdUX3dyaXRhYmxl X3BhZ2UpICkKPj4gLSAgICAgICAgICAgICAgICBtYXBwaW5nIHw9IElPTU1VRl93cml0YWJsZTsK Pj4gKyAgICAgICAgICAgIGlmICggKChwYWdlLT51LmludXNlLnR5cGVfaW5mbyAmIFBHVF90eXBl X21hc2spID09Cj4+ICsgICAgICAgICAgICAgICAgICBQR1Rfd3JpdGFibGVfcGFnZSkgKQo+PiAr ICAgICAgICAgICAgewo+PiArICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbWZuID0gbWZu X3gocGFnZV90b19tZm4ocGFnZSkpOwo+PiArICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcg ZGZuID0gbWZuX3RvX2dtZm4oZCwgbWZuKTsKPj4gKyAgICAgICAgICAgICAgICBpbnQgcmV0ID0g aW9tbXVfbWFwKGQsIF9kZm4oZGZuKSwgX21mbihtZm4pLCAwLAo+PiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgSU9NTVVGX3JlYWRhYmxlIHwgSU9NTVVGX3dyaXRhYmxlLAo+ PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmZsdXNoX2ZsYWdzKTsKPiAK PiBXaGF0J3MgdGhlIGlkZWEgYmVoaW5kIGNhbGxpbmcgaW9tbXVfbWFwKCkgaGVyZSwgcmF0aGVy IHRoYW4gcmVseWluZyBvbgo+IHRoZSBvbmUgaW4gX2dldF9wYWdlX3R5cGUoKT8gIERvZXMgbmVl ZF9pb21tdV9wdF9zeW5jKCkgbm90IHdvcmsgeWV0IGF0Cj4gdGhpcyBwb2ludCwgb3IgZG8geW91 IGV4cGVjdCB0aGVyZSB0byBiZSBwYWdlcyB0aGF0IGhhdmUgYmVlbiBtYXJrZWQKPiBQR1Rfd3Jp dGFibGUgd2l0aG91dCBoYXZpbmcgZ29uZSB0aHJvdWdoIF9nZXRfcGFnZV90eXBlKCk/CgoiaW9t bXU9ZG9tMC1zdHJpY3QiIGRvZXNuJ3Qgd29yayB3aXRob3V0IHRoaXMuIFRoYXQncyBiZWNhdXNl IHRoZQpQViBEb20wIGJ1aWxkZXIgc2V0cyB0aGUgcGFnZXMgaW4gdGhlIGludGlhbCBhbGxvY2F0 aW9uIHRvClBHVF93cml0YWJsZSAob3IgdGhlIG5lY2Vzc2FyeSBwYWdlIHRhYmxlIHR5cGVzKSBs b25nIGJlZm9yZQpjYWxsaW5nIGlvbW11X2h3ZG9tX2luaXQoKS4gUHJvYmFibHkgdGhpcyBjb3Vs ZCBiZSByZS1hcnJhbmdlZCwgYnV0CkkgZG9uJ3QgdGhpbmsgSSdtIHVwIHRvIHRoaXMgcmlnaHQg bm93LgoKQnV0IGhhdmluZyBhdCBsZWFzdCBtYWRlIHRoZSBhdHRlbXB0IHN0aWxsIHBvaW50ZWQg b3V0IHR3byBpc3N1ZXMKd2l0aCB0aGUgcGF0Y2g6IEZvciBQR1Rfbm9uZSBwYWdlcyAoaS5lLiBn ZXRfcGFnZV9hbmRfdHlwZSgpCmFjdHVhbGx5IGhhdmluZyB0aGUgaW50ZW5kZWQgZWZmZWN0KSBJ T1RMQiBmbHVzaGluZyB3YXNuJ3QgZG9uZQoobm90IGEgYmlnIHByb2JsZW0sIHNpbmNlIERvbTAg aGFzbid0IHJ1biB5ZXQsIGJ1dCBpbmNvbnNpc3RlbnQKd2l0aCB0aGUgZnVuY3Rpb24gY2FsbGlu ZyBpb21tdV9pb3RsYl9mbHVzaF9hbGwoKSBpbiB0aGUgZmlyc3QgcGxhY2UpLgpQbHVzIEkgZG9u J3QgdGhpbmsgdGhlIHtnZXQscHV0fV9wYWdlX2FuZF90eXBlKCkgZGFuY2Ugc2hvdWxkCmJlIGRv bmUgYXQgYWxsIGZvciBQVkggRG9tMC4KClNvIGEgdjIgaXMgY29taW5nIGluIGFueSBldmVudC4K CkphbgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRw czovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC58C04AB4 for ; Tue, 14 May 2019 11:17:28 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA07A21473 for ; Tue, 14 May 2019 11:17:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA07A21473 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQVQm-00008V-Q4; Tue, 14 May 2019 11:17:12 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQVQl-00008I-Jm for xen-devel@lists.xenproject.org; Tue, 14 May 2019 11:17:11 +0000 X-Inumbo-ID: d0797e6a-7639-11e9-8980-bc764e045a96 Received: from prv1-mh.provo.novell.com (unknown [137.65.248.33]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id d0797e6a-7639-11e9-8980-bc764e045a96; Tue, 14 May 2019 11:17:09 +0000 (UTC) Received: from INET-PRV1-MTA by prv1-mh.provo.novell.com with Novell_GroupWise; Tue, 14 May 2019 05:17:09 -0600 Message-Id: <5CDAA3AD020000780022E878@prv1-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 18.1.0 Date: Tue, 14 May 2019 05:17:01 -0600 From: "Jan Beulich" To: References: <5C7E77D1020000780021BB0B@prv1-mh.provo.novell.com> <5C7E78F6020000780021BB21@prv1-mh.provo.novell.com> <3172ee3f-0800-99a5-e148-d10ecdfd51a8@citrix.com> In-Reply-To: <3172ee3f-0800-99a5-e148-d10ecdfd51a8@citrix.com> Mime-Version: 1.0 Content-Disposition: inline Subject: Re: [Xen-devel] [PATCH 2/3] IOMMU/x86: make page type checks consistent when mapping pages X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: George Dunlap , Andrew Cooper , Juergen Gross , xen-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Message-ID: <20190514111701.muKiDcSEpa7Rh6fdzXXSqE-jQ0QTyQ_DP3NpgsGD6jk@z> Pj4+IE9uIDEzLjA1LjE5IGF0IDE1OjQ0LCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPiB3cm90 ZToKPiBPbiAzLzUvMTkgMToyNiBQTSwgSmFuIEJldWxpY2ggd3JvdGU6Cj4+IC0tLSBhL3hlbi9k cml2ZXJzL3Bhc3N0aHJvdWdoL2lvbW11LmMKPj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvaW9tbXUuYwo+PiBAQCAtMTkyLDIxICsxOTIsMjcgQEAgdm9pZCBfX2h3ZG9tX2luaXQgaW9t bXVfaHdkb21faW5pdChzdHJ1Ywo+PiAgCj4+ICAgICAgICAgIHBhZ2VfbGlzdF9mb3JfZWFjaCAo IHBhZ2UsICZkLT5wYWdlX2xpc3QgKQo+PiAgICAgICAgICB7Cj4+IC0gICAgICAgICAgICB1bnNp Z25lZCBsb25nIG1mbiA9IG1mbl94KHBhZ2VfdG9fbWZuKHBhZ2UpKTsKPj4gLSAgICAgICAgICAg IHVuc2lnbmVkIGxvbmcgZGZuID0gbWZuX3RvX2dtZm4oZCwgbWZuKTsKPj4gLSAgICAgICAgICAg IHVuc2lnbmVkIGludCBtYXBwaW5nID0gSU9NTVVGX3JlYWRhYmxlOwo+PiAtICAgICAgICAgICAg aW50IHJldDsKPj4gKyAgICAgICAgICAgIGlmICggKHBhZ2UtPnUuaW51c2UudHlwZV9pbmZvICYg UEdUX3R5cGVfbWFzaykgPT0gUEdUX25vbmUgKQo+PiArICAgICAgICAgICAgewo+PiArICAgICAg ICAgICAgICAgIEFTU0VSVCghKHBhZ2UtPnUuaW51c2UudHlwZV9pbmZvICYgUEdUX2NvdW50X21h c2spKTsKPj4gKyAgICAgICAgICAgICAgICBpZiAoIGdldF9wYWdlX2FuZF90eXBlKHBhZ2UsIGQs IFBHVF93cml0YWJsZV9wYWdlKSApCj4+ICsgICAgICAgICAgICAgICAgICAgIHB1dF9wYWdlX2Fu ZF90eXBlKHBhZ2UpOwo+PiArICAgICAgICAgICAgICAgIGVsc2UgaWYgKCAhcmMgKQo+PiArICAg ICAgICAgICAgICAgICAgICByYyA9IC1FQlVTWTsKPj4gKyAgICAgICAgICAgIH0KPj4gIAo+PiAt ICAgICAgICAgICAgaWYgKCAoKHBhZ2UtPnUuaW51c2UudHlwZV9pbmZvICYgUEdUX2NvdW50X21h c2spID09IDApIHx8Cj4+IC0gICAgICAgICAgICAgICAgICgocGFnZS0+dS5pbnVzZS50eXBlX2lu Zm8gJiBQR1RfdHlwZV9tYXNrKQo+PiAtICAgICAgICAgICAgICAgICAgPT0gUEdUX3dyaXRhYmxl X3BhZ2UpICkKPj4gLSAgICAgICAgICAgICAgICBtYXBwaW5nIHw9IElPTU1VRl93cml0YWJsZTsK Pj4gKyAgICAgICAgICAgIGlmICggKChwYWdlLT51LmludXNlLnR5cGVfaW5mbyAmIFBHVF90eXBl X21hc2spID09Cj4+ICsgICAgICAgICAgICAgICAgICBQR1Rfd3JpdGFibGVfcGFnZSkgKQo+PiAr ICAgICAgICAgICAgewo+PiArICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbWZuID0gbWZu X3gocGFnZV90b19tZm4ocGFnZSkpOwo+PiArICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcg ZGZuID0gbWZuX3RvX2dtZm4oZCwgbWZuKTsKPj4gKyAgICAgICAgICAgICAgICBpbnQgcmV0ID0g aW9tbXVfbWFwKGQsIF9kZm4oZGZuKSwgX21mbihtZm4pLCAwLAo+PiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgSU9NTVVGX3JlYWRhYmxlIHwgSU9NTVVGX3dyaXRhYmxlLAo+ PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmZsdXNoX2ZsYWdzKTsKPiAK PiBXaGF0J3MgdGhlIGlkZWEgYmVoaW5kIGNhbGxpbmcgaW9tbXVfbWFwKCkgaGVyZSwgcmF0aGVy IHRoYW4gcmVseWluZyBvbgo+IHRoZSBvbmUgaW4gX2dldF9wYWdlX3R5cGUoKT8gIERvZXMgbmVl ZF9pb21tdV9wdF9zeW5jKCkgbm90IHdvcmsgeWV0IGF0Cj4gdGhpcyBwb2ludCwgb3IgZG8geW91 IGV4cGVjdCB0aGVyZSB0byBiZSBwYWdlcyB0aGF0IGhhdmUgYmVlbiBtYXJrZWQKPiBQR1Rfd3Jp dGFibGUgd2l0aG91dCBoYXZpbmcgZ29uZSB0aHJvdWdoIF9nZXRfcGFnZV90eXBlKCk/CgoiaW9t bXU9ZG9tMC1zdHJpY3QiIGRvZXNuJ3Qgd29yayB3aXRob3V0IHRoaXMuIFRoYXQncyBiZWNhdXNl IHRoZQpQViBEb20wIGJ1aWxkZXIgc2V0cyB0aGUgcGFnZXMgaW4gdGhlIGludGlhbCBhbGxvY2F0 aW9uIHRvClBHVF93cml0YWJsZSAob3IgdGhlIG5lY2Vzc2FyeSBwYWdlIHRhYmxlIHR5cGVzKSBs b25nIGJlZm9yZQpjYWxsaW5nIGlvbW11X2h3ZG9tX2luaXQoKS4gUHJvYmFibHkgdGhpcyBjb3Vs ZCBiZSByZS1hcnJhbmdlZCwgYnV0CkkgZG9uJ3QgdGhpbmsgSSdtIHVwIHRvIHRoaXMgcmlnaHQg bm93LgoKQnV0IGhhdmluZyBhdCBsZWFzdCBtYWRlIHRoZSBhdHRlbXB0IHN0aWxsIHBvaW50ZWQg b3V0IHR3byBpc3N1ZXMKd2l0aCB0aGUgcGF0Y2g6IEZvciBQR1Rfbm9uZSBwYWdlcyAoaS5lLiBn ZXRfcGFnZV9hbmRfdHlwZSgpCmFjdHVhbGx5IGhhdmluZyB0aGUgaW50ZW5kZWQgZWZmZWN0KSBJ T1RMQiBmbHVzaGluZyB3YXNuJ3QgZG9uZQoobm90IGEgYmlnIHByb2JsZW0sIHNpbmNlIERvbTAg aGFzbid0IHJ1biB5ZXQsIGJ1dCBpbmNvbnNpc3RlbnQKd2l0aCB0aGUgZnVuY3Rpb24gY2FsbGlu ZyBpb21tdV9pb3RsYl9mbHVzaF9hbGwoKSBpbiB0aGUgZmlyc3QgcGxhY2UpLgpQbHVzIEkgZG9u J3QgdGhpbmsgdGhlIHtnZXQscHV0fV9wYWdlX2FuZF90eXBlKCkgZGFuY2Ugc2hvdWxkCmJlIGRv bmUgYXQgYWxsIGZvciBQVkggRG9tMC4KClNvIGEgdjIgaXMgY29taW5nIGluIGFueSBldmVudC4K CkphbgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRw czovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs