All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] xen/boot: Print the build-id along with the changeset information
Date: Mon, 20 May 2019 02:12:35 -0600	[thread overview]
Message-ID: <5CE261730200007800230797@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <1558120638-3610-1-git-send-email-andrew.cooper3@citrix.com>

>>> On 17.05.19 at 21:17, <andrew.cooper3@citrix.com> wrote:
> During initcalls is ok, but is a rather random place to find the build-id:
> 
>   (XEN) Parked 2 CPUs
>   (XEN) build-id: 7ff05f78ebc8141000b9feee4370a408bd935dec
>   (XEN) Running stub recovery selftests...
> 
> Logically, it is version information, so print with the changeset information
> in console_init_preirq():
> 
>   (XEN) Xen version 4.13-unstable (andrewcoop@andrecoop) (gcc (Debian 4.9.2-10+deb8u2) 4.9.2) debug=y  Fri Apr 12 18:24:52 BST 2019
>   (XEN) Latest ChangeSet: Fri Apr 5 14:39:42 2019 git:fc6c7ae-dirty
>   (XEN) build-id: 7ff05f78ebc8141000b9feee4370a408bd935dec
>   (XEN) PVH start info: (pa 0000ffc0)
> 
> Nothing has ever cared about xen_build_init()'s return value, so convert it to
> void rather than include errno.h into the !BUILD_ID case of version.h
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID
From: "Jan Beulich" <JBeulich@suse.com>
To: "Andrew Cooper" <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Julien Grall <julien.grall@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] xen/boot: Print the build-id along with the changeset information
Date: Mon, 20 May 2019 02:12:35 -0600	[thread overview]
Message-ID: <5CE261730200007800230797@prv1-mh.provo.novell.com> (raw)
Message-ID: <20190520081235.iUhch4n8zX1UWHhSIgJfaAVjTQOPqkCN7AplqiAbuvE@z> (raw)
In-Reply-To: <1558120638-3610-1-git-send-email-andrew.cooper3@citrix.com>

>>> On 17.05.19 at 21:17, <andrew.cooper3@citrix.com> wrote:
> During initcalls is ok, but is a rather random place to find the build-id:
> 
>   (XEN) Parked 2 CPUs
>   (XEN) build-id: 7ff05f78ebc8141000b9feee4370a408bd935dec
>   (XEN) Running stub recovery selftests...
> 
> Logically, it is version information, so print with the changeset information
> in console_init_preirq():
> 
>   (XEN) Xen version 4.13-unstable (andrewcoop@andrecoop) (gcc (Debian 4.9.2-10+deb8u2) 4.9.2) debug=y  Fri Apr 12 18:24:52 BST 2019
>   (XEN) Latest ChangeSet: Fri Apr 5 14:39:42 2019 git:fc6c7ae-dirty
>   (XEN) build-id: 7ff05f78ebc8141000b9feee4370a408bd935dec
>   (XEN) PVH start info: (pa 0000ffc0)
> 
> Nothing has ever cared about xen_build_init()'s return value, so convert it to
> void rather than include errno.h into the !BUILD_ID case of version.h
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-05-20  8:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 19:17 Andrew Cooper
2019-05-17 19:17 ` [Xen-devel] " Andrew Cooper
2019-05-20  8:12 ` Jan Beulich [this message]
2019-05-20  8:12   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5CE261730200007800230797@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=julien.grall@arm.com \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH] xen/boot: Print the build-id along with the changeset information' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.