From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dr. Philipp Tomsich Date: Wed, 22 Feb 2017 18:24:29 +0100 Subject: [U-Boot] [PATCH v1 1/2] sun8i: define CONFIG_PHY_GIGE for EMAC In-Reply-To: <20170222171841.wc64m7izwfwwfhhg@lukather> References: <20170221195542.axi6iujbepchemvm@lukather> <66F8CE5E-3CAB-4C9B-A52D-6B59A6024643@theobroma-systems.com> <20170222171841.wc64m7izwfwwfhhg@lukather> Message-ID: <5CE5BA2E-1568-464A-B4B6-EF59931EE3C3@theobroma-systems.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > On 22 Feb 2017, at 18:18, Maxime Ripard wrote: > > On Tue, Feb 21, 2017 at 09:37:14PM +0100, Dr. Philipp Tomsich wrote: >> On 21 Feb 2017, at 20:55, Maxime Ripard wrote: >>> >>> On Fri, Feb 17, 2017 at 06:47:54PM +0100, Philipp Tomsich wrote: >>>> +#ifdef CONFIG_SUN8I_EMAC >>>> +#define CONFIG_PHY_GIGE /* GMAC can use gigabit PHY */ >>>> +#endif >>> >>> It would make more sense to move that option to Kconfig, and selecting >>> it from SUN8I_EMAC. >> >> CONFIG_PHY_GIGE is not a Kconfig option yet and only enabled via >> board-specific config files. > > Which is exactly what I was suggesting to do, sorry if it wasn't clear > :) > > We're still in the phase of getting options moved to kconfig, so this > seems like the perfect occasion to do so. Looks like this will be one of the many v2 patches for today. All I have to do now is to get my patch-format right ;-) Cheers, Philipp.