Re: [Outreachy kernel] [PATCH] staging: lustre: llite: rw26: Remove unused function definition

["Dilger, Andreas" <andreas.dilger@intel.com>]

On Mar 12, 2017, at 07:40, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Sat, Mar 11, 2017 at 12:01:53PM +0530, sayli karnik wrote:
>> The patch removes unused function definition ll_get_user_pages().
>> 
>> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
>> ---
>> drivers/staging/lustre/lustre/llite/rw26.c | 26 --------------------------
>> 1 file changed, 26 deletions(-)
>> 
>> diff --git a/drivers/staging/lustre/lustre/llite/rw26.c b/drivers/staging/lustre/lustre/llite/rw26.c
>> index d89e795..420f296 100644
>> --- a/drivers/staging/lustre/lustre/llite/rw26.c
>> +++ b/drivers/staging/lustre/lustre/llite/rw26.c
>> @@ -156,32 +156,6 @@ static int ll_releasepage(struct page *vmpage, gfp_t gfp_mask)
>> 
>> #define MAX_DIRECTIO_SIZE (2 * 1024 * 1024 * 1024UL)
>> 
>> -static inline int ll_get_user_pages(int rw, unsigned long user_addr,
>> -				    size_t size, struct page ***pages,
>> -				    int *max_pages)
>> -{
>> -	int result = -ENOMEM;
>> -
>> -	/* set an arbitrary limit to prevent arithmetic overflow */
>> -	if (size > MAX_DIRECTIO_SIZE) {
>> -		*pages = NULL;
>> -		return -EFBIG;
>> -	}
>> -
>> -	*max_pages = (user_addr + size + PAGE_SIZE - 1) >> PAGE_SHIFT;
>> -	*max_pages -= user_addr >> PAGE_SHIFT;
>> -
>> -	*pages = libcfs_kvzalloc(*max_pages * sizeof(**pages), GFP_NOFS);
>> -	if (*pages) {
>> -		result = get_user_pages_fast(user_addr, *max_pages,
>> -					     (rw == READ), *pages);
>> -		if (unlikely(result <= 0))
>> -			kvfree(*pages);
>> -	}
>> -
>> -	return result;
>> -}
>> -
> 
> Should this be deleted?  Given that ll_free_user_pages() is used, that
> implies that this function should also be used somewhere.  Why isn't it?

Al replaced the use of ll_get_user_pages() with iov_iter_get_pages_alloc() in
commit 91f79c43d1b54d7154b118860d81b39bad07dfff so it is no longer used.

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation