From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD6C5C47404 for ; Fri, 11 Oct 2019 06:20:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97E7121D56 for ; Fri, 11 Oct 2019 06:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727401AbfJKGUW (ORCPT ); Fri, 11 Oct 2019 02:20:22 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3731 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726401AbfJKGUW (ORCPT ); Fri, 11 Oct 2019 02:20:22 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id A265B27779FA3EAE2939; Fri, 11 Oct 2019 14:20:18 +0800 (CST) Received: from [127.0.0.1] (10.177.29.68) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.439.0; Fri, 11 Oct 2019 14:20:17 +0800 Message-ID: <5DA01F20.8020402@huawei.com> Date: Fri, 11 Oct 2019 14:20:16 +0800 From: zhong jiang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Greg KH CC: , Subject: Re: [PATCH] staging: wfx: fix an undefined reference error when CONFIG_MMC=m References: <1570762939-8735-1-git-send-email-zhongjiang@huawei.com> <20191011042609.GB938845@kroah.com> In-Reply-To: <20191011042609.GB938845@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.29.68] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/10/11 12:26, Greg KH wrote: > On Fri, Oct 11, 2019 at 11:02:19AM +0800, zhong jiang wrote: >> I hit the following error when compile the kernel. >> >> drivers/staging/wfx/main.o: In function `wfx_core_init': >> /home/z00352263/linux-next/linux-next/drivers/staging/wfx/main.c:488: undefined reference to `sdio_register_driver' >> drivers/staging/wfx/main.o: In function `wfx_core_exit': >> /home/z00352263/linux-next/linux-next/drivers/staging/wfx/main.c:496: undefined reference to `sdio_unregister_driver' >> drivers/staging/wfx/main.o:(.debug_addr+0x1a8): undefined reference to `sdio_register_driver' >> drivers/staging/wfx/main.o:(.debug_addr+0x6f0): undefined reference to `sdio_unregister_driver' >> >> Signed-off-by: zhong jiang >> --- >> drivers/staging/wfx/Kconfig | 3 ++- >> drivers/staging/wfx/Makefile | 5 +++-- >> 2 files changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/staging/wfx/Kconfig b/drivers/staging/wfx/Kconfig >> index 9b8a1c7..4d045513 100644 >> --- a/drivers/staging/wfx/Kconfig >> +++ b/drivers/staging/wfx/Kconfig >> @@ -1,7 +1,8 @@ >> config WFX >> tristate "Silicon Labs wireless chips WF200 and further" >> depends on MAC80211 >> - depends on (SPI || MMC) >> + depends on SPI >> + select MMC > How about: > depends on (SPI && MMC) > > instead? Yep, That is better. Will repost in v2. Thanks, Sincerely, zhong jiang > thanks, > > greg k-h > > . >