From: Zhou Wang <wangzhou1@hisilicon.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 1/2] crypto: hisilicon - select NEED_SG_DMA_LENGTH in qm Kconfig
Date: Fri, 25 Oct 2019 09:00:24 +0800 [thread overview]
Message-ID: <5DB24928.5000307@hisilicon.com> (raw)
In-Reply-To: <20191024135629.vs43o3rz3xe2hg2c@gondor.apana.org.au>
On 2019/10/24 21:56, Herbert Xu wrote:
> On Thu, Oct 24, 2019 at 03:22:50PM +0200, Ard Biesheuvel wrote:
>>
>> If you are fixing a COMPILE_TEST failure, just add NEED_SG_DMA_LENGTH
>> as a dependency, or drop the COMPILE_TEST altogether (why was that
>> added in the first place?)
>
> Because we want to maximise compiler coverage so that build failures
> can be caught at the earliest opportunity.
>
> But a better fix would be to use
>
> sg_dma_len(sg)
OK, will do by this. Thanks!
Best，
Zhou
>
> instead of
>
> sg->dma_length
>
> Cheers,
>
prev parent reply other threads:[~2019-10-25 1:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 11:18 [PATCH 1/2] crypto: hisilicon - select NEED_SG_DMA_LENGTH in qm Kconfig Zhou Wang
2019-10-11 11:25 ` Zhou Wang
2019-10-18 8:04 ` Herbert Xu
2019-10-21 3:53 ` Zhou Wang
2019-10-24 13:22 ` Ard Biesheuvel
2019-10-24 13:56 ` Herbert Xu
2019-10-25 1:00 ` Zhou Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DB24928.5000307@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.