Re: [Patch v5 2/6] sched/fair: Add infrastructure to store and update instantaneous thermal pressure

From: Thara Gopinath <thara.gopinath@linaro.org>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: mingo@redhat.com, peterz@infradead.org,
	vincent.guittot@linaro.org, rui.zhang@intel.com,
	edubezval@gmail.com, qperret@google.com,
	linux-kernel@vger.kernel.org, amit.kachhap@gmail.com,
	javi.merino@kernel.org, daniel.lezcano@linaro.org
Subject: Re: [Patch v5 2/6] sched/fair: Add infrastructure to store and update instantaneous thermal pressure
Date: Tue, 5 Nov 2019 16:02:00 -0500	[thread overview]
Message-ID: <5DC1E348.2090104@linaro.org> (raw)
In-Reply-To: <20191105202037.GA17494@e108754-lin>

On 11/05/2019 03:21 PM, Ionela Voinescu wrote:
> Hi Thara,
> 
> On Tuesday 05 Nov 2019 at 13:49:42 (-0500), Thara Gopinath wrote:
> [...]
>> +static void trigger_thermal_pressure_average(struct rq *rq)
>> +{
>> +#ifdef CONFIG_SMP
>> +	update_thermal_load_avg(rq_clock_task(rq), rq,
>> +				per_cpu(thermal_pressure, cpu_of(rq)));
>> +#endif
>> +}
> 
> Why did you decide to keep trigger_thermal_pressure_average and not
> call update_thermal_load_avg directly?
> 
> For !CONFIG_SMP you already have an update_thermal_load_avg function
> that does nothing, in kernel/sched/pelt.h, so you don't need that
> ifdef. 
Hi,

Yes you are right. But later with the shift option added, I shift
rq_clock_task(rq) by the shift. I thought it is better to contain it in
a function that replicate it in three different places. I can remove the
CONFIG_SMP in the next version
> 
> Thanks,
> Ionela.
> 
>> +
>>  /*
>>   * All the scheduling class methods:
>>   */
>> -- 
>> 2.1.4
>>


-- 
Warm Regards
Thara