From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jitendra Kalsaria Subject: RE: [PATCH net 4/7] qlge: Fixed double pci free upon tx_ring->q allocation failure. Date: Mon, 2 Jul 2012 22:56:57 -0700 Message-ID: <5E4F49720D0BAD499EE1F01232234BA877435B2684@AVEXMB1.qlogic.org> References: <1341272514-5156-1-git-send-email-jitendra.kalsaria@qlogic.com> <1341272514-5156-5-git-send-email-jitendra.kalsaria@qlogic.com> <1341278521.2590.30.camel@bwh-desktop.uk.solarflarecom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: David Miller , netdev , Ron Mercer , Dept-NX Linux NIC Driver To: Ben Hutchings Return-path: Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:32294 "EHLO tx2outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752874Ab2GCF5D (ORCPT ); Tue, 3 Jul 2012 01:57:03 -0400 In-Reply-To: <1341278521.2590.30.camel@bwh-desktop.uk.solarflarecom.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBCZW4gSHV0Y2hpbmdzIFttYWls dG86Ymh1dGNoaW5nc0Bzb2xhcmZsYXJlLmNvbV0gDQpTZW50OiBNb25kYXksIEp1bHkgMDIsIDIw MTIgNjoyMiBQTQ0KVG86IEppdGVuZHJhIEthbHNhcmlhDQpDYzogRGF2aWQgTWlsbGVyOyBuZXRk ZXY7IFJvbiBNZXJjZXI7IERlcHQtTlggTGludXggTklDIERyaXZlcg0KU3ViamVjdDogUmU6IFtQ QVRDSCBuZXQgNC83XSBxbGdlOiBGaXhlZCBkb3VibGUgcGNpIGZyZWUgdXBvbiB0eF9yaW5nLT5x IGFsbG9jYXRpb24gZmFpbHVyZS4NCg0KT24gTW9uLCAyMDEyLTA3LTAyIGF0IDE5OjQxIC0wNDAw LCBKaXRlbmRyYSBLYWxzYXJpYSB3cm90ZToNCj4gRnJvbTogSml0ZW5kcmEgS2Fsc2FyaWEgPGpp dGVuZHJhLmthbHNhcmlhQHFsb2dpYy5jb20+DQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKaXRlbmRy YSBLYWxzYXJpYSA8aml0ZW5kcmEua2Fsc2FyaWFAcWxvZ2ljLmNvbT4NCj4gLS0tDQo+ICBkcml2 ZXJzL25ldC9ldGhlcm5ldC9xbG9naWMvcWxnZS9xbGdlX21haW4uYyB8ICAgMTQgKysrKysrKy0t LS0tLS0NCj4gIDEgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygt KQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L3Fsb2dpYy9xbGdlL3Fs Z2VfbWFpbi5jIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvcWxvZ2ljL3FsZ2UvcWxnZV9tYWluLmMN Cj4gaW5kZXggY2RiYzg2MC4uOWVjZDE1ZiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9uZXQvZXRo ZXJuZXQvcWxvZ2ljL3FsZ2UvcWxnZV9tYWluLmMNCj4gKysrIGIvZHJpdmVycy9uZXQvZXRoZXJu ZXQvcWxvZ2ljL3FsZ2UvcWxnZV9tYWluLmMNCj4gQEAgLTI3MDEsMjAgKzI3MDEsMjAgQEAgc3Rh dGljIGludCBxbF9hbGxvY190eF9yZXNvdXJjZXMoc3RydWN0IHFsX2FkYXB0ZXIgKnFkZXYsDQo+ ICAJICAgIHBjaV9hbGxvY19jb25zaXN0ZW50KHFkZXYtPnBkZXYsIHR4X3JpbmctPndxX3NpemUs DQo+ICAJCQkJICZ0eF9yaW5nLT53cV9iYXNlX2RtYSk7DQo+ICANCj4gLQlpZiAoKHR4X3Jpbmct PndxX2Jhc2UgPT0gTlVMTCkgfHwNCj4gLQkgICAgdHhfcmluZy0+d3FfYmFzZV9kbWEgJiBXUV9B RERSX0FMSUdOKSB7DQo+IC0JCW5ldGlmX2VycihxZGV2LCBpZnVwLCBxZGV2LT5uZGV2LCAidHhf cmluZyBhbGxvYyBmYWlsZWQuXG4iKTsNCj4gLQkJcmV0dXJuIC1FTk9NRU07DQo+IC0JfQ0KPiAr CWlmICghdHhfcmluZy0+d3FfYmFzZSB8fCB0eF9yaW5nLT53cV9iYXNlX2RtYSAmIFdRX0FERFJf QUxJR04pDQo+ICsJCWdvdG8gZXJyOw0KPiArDQoNClNvIGluIGNhc2UgcGNpX2FsbG9jX2NvbnNp c3RlbnQoKSBmYWlscywgeW91IG5vdyB0cnkgdG8gZnJlZSBhbnl3YXkuDQpOb3Qgc3VyZSB3aGV0 aGVyIHRoYXQncyBzYWZlOyBkbyB5b3UgZmVlbCBsdWNreT8NCg0KW0pLXSBBaGgsIG15IGFwb2xv Z3kuIA0KDQo+ICAJdHhfcmluZy0+cSA9DQo+ICAJICAgIGttYWxsb2ModHhfcmluZy0+d3FfbGVu ICogc2l6ZW9mKHN0cnVjdCB0eF9yaW5nX2Rlc2MpLCBHRlBfS0VSTkVMKTsNCj4gLQlpZiAodHhf cmluZy0+cSA9PSBOVUxMKQ0KPiArCWlmICghdHhfcmluZy0+cSkNCj4gIAkJZ290byBlcnI7DQoN ClVucmVsYXRlZCBjaGFuZ2UuDQoNCj4gIAlyZXR1cm4gMDsNCj4gIGVycjoNCj4gIAlwY2lfZnJl ZV9jb25zaXN0ZW50KHFkZXYtPnBkZXYsIHR4X3JpbmctPndxX3NpemUsDQo+IC0JCQkgICAgdHhf cmluZy0+d3FfYmFzZSwgdHhfcmluZy0+d3FfYmFzZV9kbWEpOw0KPiArCQkJdHhfcmluZy0+d3Ff YmFzZSwgdHhfcmluZy0+d3FfYmFzZV9kbWEpOw0KDQpUaGlzIHdhcyBuaWNlbHkgaW5kZW50ZWQg YmVmb3JlLi4uDQoNCj4gKwl0eF9yaW5nLT53cV9iYXNlID0gTlVMTDsNCj4gKwluZXRpZl9lcnIo cWRldiwgaWZ1cCwgcWRldi0+bmRldiwgInR4X3JpbmcgYWxsb2MgZmFpbGVkLlxuIik7DQo+ICAJ cmV0dXJuIC1FTk9NRU07DQo+ICB9DQo+ICANCg0KLS0gDQpCZW4gSHV0Y2hpbmdzLCBTdGFmZiBF bmdpbmVlciwgU29sYXJmbGFyZQ0KTm90IHNwZWFraW5nIGZvciBteSBlbXBsb3llcjsgdGhhdCdz IHRoZSBtYXJrZXRpbmcgZGVwYXJ0bWVudCdzIGpvYi4NClRoZXkgYXNrZWQgdXMgdG8gbm90ZSB0 aGF0IFNvbGFyZmxhcmUgcHJvZHVjdCBuYW1lcyBhcmUgdHJhZGVtYXJrZWQuDQoNCg0K