From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.reyna@windriver.com>
Received: from mail.windriver.com (mail.windriver.com [147.11.1.11])
	by yocto-www.yoctoproject.org (Postfix) with ESMTP id DEC2BE0086B
	for <toaster@yoctoproject.org>; Thu, 16 Jan 2014 18:26:26 -0800 (PST)
Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com
	[147.11.189.40])
	by mail.windriver.com (8.14.5/8.14.5) with ESMTP id s0H2QFeJ002720
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL);
	Thu, 16 Jan 2014 18:26:15 -0800 (PST)
Received: from ALA-MBB.corp.ad.wrs.com ([169.254.1.246]) by
	ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.02.0347.000;
	Thu, 16 Jan 2014 18:26:15 -0800
From: "Reyna, David" <david.reyna@windriver.com>
To: "Lerner, Dave" <dave.lerner@windriver.com>, "Damian, Alexandru
	(alexandru.damian@intel.com)" <alexandru.damian@intel.com>, "Eggleton, Paul
	(paul.eggleton@intel.com)" <paul.eggleton@intel.com>, "Barros Pena, Belen
	(belen.barros.pena@intel.com)" <belen.barros.pena@intel.com>, "Ravi
	Chintakunta (ravi.chintakunta@timesys.com)" <ravi.chintakunta@timesys.com>
Thread-Topic: Commit for recipe detail view ready for review
Thread-Index: Ac8TK3wV5uLtxrqASu2TgaW7mPKyNw==
Date: Fri, 17 Jan 2014 02:26:14 +0000
Message-ID: <5E53D14CE4667A45B9A06760DE5D13D055D7DAFA@ALA-MBB.corp.ad.wrs.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [147.11.152.89]
MIME-Version: 1.0
Cc: "jessica.zhang@intel.com" <jessica.zhang@intel.com>,
	"toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: Commit for recipe detail view ready for review
X-BeenThere: toaster@yoctoproject.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Web based interface for BitBake <toaster.yoctoproject.org>
List-Unsubscribe: <https://lists.yoctoproject.org/options/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=unsubscribe>
List-Archive: <http://lists.yoctoproject.org/pipermail/toaster>
List-Post: <mailto:toaster@yoctoproject.org>
List-Help: <mailto:toaster-request@yoctoproject.org?subject=help>
List-Subscribe: <https://lists.yoctoproject.org/listinfo/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jan 2014 02:26:29 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi all,

I have pushed my commit for the recipe details page for review. There are t=
wo separate commits for tracking purposes.

Branch: dreyna/recipe-detail-view

(a) Implementation of base build details page. This adds the proposed base =
page for details pages.

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=3Ddreyna/r=
ecipe-detail-view&id=3D95d3ebecbbf87af3a657bb7fcd7785700fb42c6c

(b) Implementation of recipe detail views. This adds the recipe details pag=
e with an updated view context, plus renames and links the recipe summary p=
age.

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=3Ddreyna/r=
ecipe-detail-view&id=3D95d3ebecbbf87af3a657bb7fcd7785700fb42c6c

(c) I have implemeted Alex's review comments. The test plan remains the sam=
e as my previous submission.=20


Development Notes
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

* This commit uses and depends upon Ravi's 'task_color' template tag, as di=
scussed.

* The recipe summary page is a placeholder to allow access to the recipe de=
tails page. The recipe summary page will be subsequently updated to the new=
 design requirements in a separate commit.


Test Instructions
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

1) Create a default Yocto project (qemux86), and start the Toaster.

  $ source poky/oe-init-build-env
  $ cd build
  $ source toaster start
  $ bitbake core-image-minimal
  $ xdg-open http://localhost:8000/

2) Select the "core-image-minimal" build link

3) Select the "Recipes" link in the left sidebar

Observe that the recipes are listed in a table, and that each recipe name i=
s a live URL link.

4) Click on the "busybox" recipe name link

Observe:
  a) The "breadcrumbs" at the top include is in this form form, and that al=
l but the last entry are live links.
 =20
	     All builds > core-image-sato atom-pc (<time>) > Recipes > busybox_1.2=
1.1-r0
	=20
  b) The informational sidebar on the right contains information pertinent =
to the "busybox" recipe,=20
 =20
  c) Some 14 task entries, starting with "do_patch" and ending with "do_bui=
ld" If you hover over a recipe name, you will see a question-mark icon appe=
ar, and if you hover over that a tooltip will appear for that task.
 =20
  d) Any task outcome of "Succeeded" should be in normal black. Any outcome=
 of "Failed" (not likely) would be red, and all other tasks should be in gr=
ey.
 =20
  e) The layer description will indicate the layer "meta", and the recipe w=
ill point to "busybox_1.21.1.bb".

  f) The right-hand sidebar about busybox is still present.
 =20
5) Observe that "Packages" link. It should have an appended value like "(4)=
". Now click on this link.

Observe:
  a) The number of packages matches the previous number in parenthesis.
 =20
  b) Each package has a version and a size. The size may be zero.
 =20
  c) Note that if you hover on a package name, it will reveal a URL of the =
following form. This link should take you to the corresponding package deta=
il page once you have the fix for 4328 pulled.
 =20
	localhost:8000/gui/build/<number>/package/<number> =20

6) Observe that "Build Dependencies" link. It should have an appended value=
 like "(0)". Now click on this link.

Observe:
  a) No dependencies appear, and you get a message of the form:
 =20
  "$RECIPE_NAME_VERSION has no build dependencies."
=20
7) Observe that "Reverse build dependencies" link. It should have an append=
ed value like "(1)". Now click on this link.

Observe:
  a) The number of packages matches the previous number in parenthesis.
 =20
  b) The recipe dependency should be "packagegroup-core-boot",=20
 =20
  c) There should be a respective version displayed, for example "1.0-r11"
=20
  d) If you hover on the recipe name, it will reveal a URL of the following=
 form. This link should take you to the corresponding recipe detail page.
 =20
	localhost:8000/gui/build/<number>/recipe/<number>

8) Click the breadcrumb "Recipes" at the top, locate the "gdbm" recipe, and=
 select it.

9) Observe that "Packages" link. It should have an appended value like "(0)=
". Now click on this link.

Observe:
  a) No packages appear, and you get a message of the form:
 =20
  "$PACKAGE_NAME_VERSION does not build any packages."
=20
10) Observe that "Build dependencies" link. It should have an appended valu=
e like "(2)". Now click on this link.

Observe:
  a) The number of build dependencies matches the previous number in parent=
hesis.
 =20
  b) The recipe dependency should have values like "gettext-native" and "li=
btool-cross".=20
 =20
  c) There should be a respective versions displayed for each dependency.
=20
  d) If you hover on a recipe name, it will reveal a URL of the following f=
orm. This link should take you to the corresponding recipe detail page.
 =20
	localhost:8000/gui/build/<number>/recipe/<number>

11) Observe that "Reverse build dependencies" link. It should have an appen=
ded value like "(0)". Now click on this link.

Observe:
  a) No reverse dependencies appear, and you get a message of the form:
 =20
  "$RECIPE_NAME_VERSION does not build any packages."

12) Select the recipe "base-files". It my build it did not have any tasks, =
and in this case instead of the task table you will observe the message:

  "$PACKAGE_NAME_VERSION does not have any tasks executed yet."

13) NOTE: to simulate the "error" task entry coloring, make the following _=
temporary_ change to "projecttags.py", and select a new recipe. All of the =
task entries should now be highlighted in red.

toastergui/templatetags/projecttags.py:
     if not task_object.task_executed:
+        return 'class=3Dmuted'
-        return 'class=3Derror'



David