From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 85345E0081B for ; Fri, 17 Jan 2014 10:37:36 -0800 (PST) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail1.windriver.com (8.14.5/8.14.5) with ESMTP id s0HIbVMx023352 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 17 Jan 2014 10:37:32 -0800 (PST) Received: from ALA-MBB.corp.ad.wrs.com ([169.254.1.246]) by ALA-HCB.corp.ad.wrs.com ([147.11.189.41]) with mapi id 14.02.0347.000; Fri, 17 Jan 2014 10:37:32 -0800 From: "Reyna, David" To: "Barros Pena, Belen" Thread-Topic: Commit for recipe detail view ready for review Thread-Index: Ac8TK3wV5uLtxrqASu2TgaW7mPKyNwAc52uAAASdDNA= Date: Fri, 17 Jan 2014 18:37:30 +0000 Message-ID: <5E53D14CE4667A45B9A06760DE5D13D055D7E2F2@ALA-MBB.corp.ad.wrs.com> References: <5E53D14CE4667A45B9A06760DE5D13D055D7DAFA@ALA-MBB.corp.ad.wrs.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [147.11.116.175] MIME-Version: 1.0 Cc: "toaster@yoctoproject.org" Subject: Re: Commit for recipe detail view ready for review X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jan 2014 18:37:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Belen, See inline... > -----Original Message----- > From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com] > Sent: Friday, January 17, 2014 8:14 AM > To: Reyna, David > Cc: toaster@yoctoproject.org > Subject: Re: Commit for recipe detail view ready for review >=20 > Hi David, >=20 > Thanks for pushing this: it=B9s looking great :) >=20 > From a UI standpoint, the page seems to have a small layout issue that > makes the heading and the tabs not to align properly. To fix it, the > body > structure should look like this: >=20 > >

> >=20 > You need to add the class row-fluid to the child of container-fluid, > and > remove the div with class row-fluid that is a sibling of the div with > class section. That will align all content nicely. Will do. > Only 3 other things: >=20 > 1. Next to the layer name you are showing the blue icon that links to > the > layer index. We currently have an issue with this that we still don=B9t > know > how to solve (see 5192 in Bugzilla). Can we take the icon out for the > moment until we find the right solution? Ok. > 2. I am finding recipes that report no tasks in their tasks table (see > attached image). This should not happen, and in fact when you go to the > tasks list there are tasks for those recipes. Hmm, I will investigate.=20 I encountered empty task lists for some packages, so I added the new test a= nd message, plus added an explicit step in my test instructions for this (s= tep #12). When you write "... when you go to the tasks list ...", what path did you t= ake to get the alternate task list? > 3. The Bugtracker value seems to have a trailing / (see attached > image). > So if there is no bugtracker specified for the recipe, the / shows. If > any > of the variables used to populate the information about the recipe is > not > specified in the recipe file, we simply don=B9t show them. For example, > if > there is no bugtracker, we show only summary, description, homepage, > section and license. Ah, the "/" was a left over debugging marker. But, you are also saying that for and only for "bugtracker" I should condit= ionally display it only if there is an actual value. I will double check th= e design document for any other such conditionals. - David > Any questions, let me know. >=20 > Cheers >=20 > Bel=E9n >=20 >=20 > On 17/01/2014 02:26, "Reyna, David" wrote: >=20 > >Hi all, > > > >I have pushed my commit for the recipe details page for review. There > are > >two separate commits for tracking purposes. > > > >Branch: dreyna/recipe-detail-view > > > >(a) Implementation of base build details page. This adds the proposed > >base page for details pages. > > > >http://git.yoctoproject.org/cgit/cgit.cgi/poky- > contrib/commit/?h=3Ddreyna/re > >cipe-detail-view&id=3D95d3ebecbbf87af3a657bb7fcd7785700fb42c6c > > > >(b) Implementation of recipe detail views. This adds the recipe > details > >page with an updated view context, plus renames and links the recipe > >summary page. > > > >http://git.yoctoproject.org/cgit/cgit.cgi/poky- > contrib/commit/?h=3Ddreyna/re > >cipe-detail-view&id=3D95d3ebecbbf87af3a657bb7fcd7785700fb42c6c > > > >(c) I have implemeted Alex's review comments. The test plan remains > the > >same as my previous submission. > > > > > >Development Notes > >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > >* This commit uses and depends upon Ravi's 'task_color' template tag, > as > >discussed. > > > >* The recipe summary page is a placeholder to allow access to the > recipe > >details page. The recipe summary page will be subsequently updated to > the > >new design requirements in a separate commit. > > > > > >Test Instructions > >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > >1) Create a default Yocto project (qemux86), and start the Toaster. > > > > $ source poky/oe-init-build-env > > $ cd build > > $ source toaster start > > $ bitbake core-image-minimal > > $ xdg-open http://localhost:8000/ > > > >2) Select the "core-image-minimal" build link > > > >3) Select the "Recipes" link in the left sidebar > > > >Observe that the recipes are listed in a table, and that each recipe > name > >is a live URL link. > > > >4) Click on the "busybox" recipe name link > > > >Observe: > > a) The "breadcrumbs" at the top include is in this form form, and > that > >all but the last entry are live links. > > > > All builds > core-image-sato atom-pc () > Recipes > > >busybox_1.21.1-r0 > > > > b) The informational sidebar on the right contains information > >pertinent to the "busybox" recipe, > > > > c) Some 14 task entries, starting with "do_patch" and ending with > >"do_build" If you hover over a recipe name, you will see a question- > mark > >icon appear, and if you hover over that a tooltip will appear for that > >task. > > > > d) Any task outcome of "Succeeded" should be in normal black. Any > >outcome of "Failed" (not likely) would be red, and all other tasks > should > >be in grey. > > > > e) The layer description will indicate the layer "meta", and the > recipe > >will point to "busybox_1.21.1.bb". > > > > f) The right-hand sidebar about busybox is still present. > > > >5) Observe that "Packages" link. It should have an appended value like > >"(4)". Now click on this link. > > > >Observe: > > a) The number of packages matches the previous number in > parenthesis. > > > > b) Each package has a version and a size. The size may be zero. > > > > c) Note that if you hover on a package name, it will reveal a URL of > >the following form. This link should take you to the corresponding > >package detail page once you have the fix for 4328 pulled. > > > > localhost:8000/gui/build//package/ > > > >6) Observe that "Build Dependencies" link. It should have an appended > >value like "(0)". Now click on this link. > > > >Observe: > > a) No dependencies appear, and you get a message of the form: > > > > "$RECIPE_NAME_VERSION has no build dependencies." > > > >7) Observe that "Reverse build dependencies" link. It should have an > >appended value like "(1)". Now click on this link. > > > >Observe: > > a) The number of packages matches the previous number in > parenthesis. > > > > b) The recipe dependency should be "packagegroup-core-boot", > > > > c) There should be a respective version displayed, for example "1.0- > r11" > > > > d) If you hover on the recipe name, it will reveal a URL of the > >following form. This link should take you to the corresponding recipe > >detail page. > > > > localhost:8000/gui/build//recipe/ > > > >8) Click the breadcrumb "Recipes" at the top, locate the "gdbm" > recipe, > >and select it. > > > >9) Observe that "Packages" link. It should have an appended value like > >"(0)". Now click on this link. > > > >Observe: > > a) No packages appear, and you get a message of the form: > > > > "$PACKAGE_NAME_VERSION does not build any packages." > > > >10) Observe that "Build dependencies" link. It should have an appended > >value like "(2)". Now click on this link. > > > >Observe: > > a) The number of build dependencies matches the previous number in > >parenthesis. > > > > b) The recipe dependency should have values like "gettext-native" > and > >"libtool-cross". > > > > c) There should be a respective versions displayed for each > dependency. > > > > d) If you hover on a recipe name, it will reveal a URL of the > following > >form. This link should take you to the corresponding recipe detail > page. > > > > localhost:8000/gui/build//recipe/ > > > >11) Observe that "Reverse build dependencies" link. It should have an > >appended value like "(0)". Now click on this link. > > > >Observe: > > a) No reverse dependencies appear, and you get a message of the > form: > > > > "$RECIPE_NAME_VERSION does not build any packages." > > > >12) Select the recipe "base-files". It my build it did not have any > >tasks, and in this case instead of the task table you will observe the > >message: > > > > "$PACKAGE_NAME_VERSION does not have any tasks executed yet." > > > >13) NOTE: to simulate the "error" task entry coloring, make the > following > >_temporary_ change to "projecttags.py", and select a new recipe. All > of > >the task entries should now be highlighted in red. > > > >toastergui/templatetags/projecttags.py: > > if not task_object.task_executed: > >+ return 'class=3Dmuted' > >- return 'class=3Derror' > > > > > > > >David > > > > > > >=20