All of lore.kernel.org
 help / color / mirror / Atom feed
* recipe summary ready for review
@ 2014-02-06  6:40 Reyna, David
  2014-02-06  9:08 ` Reyna, David
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Reyna, David @ 2014-02-06  6:40 UTC (permalink / raw)
  To: DAMIAN, ALEXANDRU, BARROS PENA, BELEN; +Cc: toaster

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

Hi Alex and Belen,

* I have pushed my implementation of the Recipe Summary view to the branch "dreyna/recipe-summary-view".

  http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/recipe-summary-view

* There is only one exception to the design document that I am aware of.

In that document, you have a column titled "Work directory", with the description "The path to the WORKDIR for the target to which the task applies". I think that this is a cut/paste error, since (a) this field only exists within "task" records and not recipe records, and (b) this field does not appear in your sample page at "yoctoproject.org/toaster".

If you did want this field, I could probably find the first task, grab its "work_directory" field, and somehow trim it back to the recipe's general work directory, but it fear that this may be non-deterministic.

- David



[-- Attachment #2: Type: text/html, Size: 2138 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: recipe summary ready for review
  2014-02-06  6:40 recipe summary ready for review Reyna, David
@ 2014-02-06  9:08 ` Reyna, David
  2014-02-06 15:18   ` Barros Pena, Belen
  2014-02-06 10:38 ` Barros Pena, Belen
  2014-02-06 15:05 ` Barros Pena, Belen
  2 siblings, 1 reply; 8+ messages in thread
From: Reyna, David @ 2014-02-06  9:08 UTC (permalink / raw)
  To: DAMIAN, ALEXANDRU, BARROS PENA, BELEN; +Cc: toaster

[-- Attachment #1: Type: text/plain, Size: 1613 bytes --]

Additionally as an implementation difference, the design document had filter icons on each of the headings, but none of the columns are "choice fields" so that did not make sense.

I therefore assumed that the simple default sorting facility was sufficient (though I explicitly disabled sorting for the composite pop-up columns of dependencies and commit IDs).

- David

      _____________________________________________
      From: Reyna, David
      Sent: Wednesday, February 05, 2014 10:40 PM
      To: Damian, Alexandru (alexandru.damian@intel.com); belen.barros.pena@intel.com
      Cc: toaster@yoctoproject.org
      Subject: recipe summary ready for review


      Hi Alex and Belen,

      * I have pushed my implementation of the Recipe Summary view to the branch "dreyna/recipe-summary-view".

        http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/recipe-summary-view

      * There is only one exception to the design document that I am aware of.

      In that document, you have a column titled "Work directory", with the description "The path to the WORKDIR for the target to which the task applies". I think that this is a cut/paste error, since (a) this field only exists within "task" records and not recipe records, and (b) this field does not appear in your sample page at "yoctoproject.org/toaster".

      If you did want this field, I could probably find the first task, grab its "work_directory" field, and somehow trim it back to the recipe's general work directory, but it fear that this may be non-deterministic.

      - David



[-- Attachment #2: Type: text/html, Size: 3647 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: recipe summary ready for review
  2014-02-06  6:40 recipe summary ready for review Reyna, David
  2014-02-06  9:08 ` Reyna, David
@ 2014-02-06 10:38 ` Barros Pena, Belen
  2014-02-06 15:05 ` Barros Pena, Belen
  2 siblings, 0 replies; 8+ messages in thread
From: Barros Pena, Belen @ 2014-02-06 10:38 UTC (permalink / raw)
  To: Reyna, David L (Wind River), Damian, Alexandru; +Cc: toaster

On 06/02/2014 06:40, "Reyna, David" <david.reyna@windriver.com> wrote:

>Hi Alex and Belen,
> 
>* I have pushed my implementation of the Recipe Summary view to the
>branch ³dreyna/recipe-summary-view².
> 
>  
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/re
>cipe-summary-view 
><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/r
>ecipe-summary-view>
> 
>* There is only one exception to the design document that I am aware of.
> 
>In that document, you have a column titled ³Work directory², with the
>description ³The
> path to the WORKDIR for the target to which the task applies². I think
>that
> this is a cut/paste error, since (a) this field only exists within
>³task² records and not recipe records, and (b) this field does not appear
>in your sample page at ³yoctoproject.org/toaster².

We intended to provide this information per recipe, but the feature was
dropped, so no need to worry about it. See

https://bugzilla.yoctoproject.org/show_bug.cgi?id=5253

>
> 
>If you did want this field, I could probably find the first task, grab
>its ³work_directory² field, and somehow trim it back to the recipe¹s
>general work directory, but it fear that this may be non-deterministic.
> 
>- David
> 
> 



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: recipe summary ready for review
  2014-02-06  6:40 recipe summary ready for review Reyna, David
  2014-02-06  9:08 ` Reyna, David
  2014-02-06 10:38 ` Barros Pena, Belen
@ 2014-02-06 15:05 ` Barros Pena, Belen
  2014-02-06 17:39   ` Reyna, David
  2 siblings, 1 reply; 8+ messages in thread
From: Barros Pena, Belen @ 2014-02-06 15:05 UTC (permalink / raw)
  To: Reyna, David L (Wind River), Damian, Alexandru; +Cc: toaster

Hi David,

This is a very impressive first go :)

I have a list of mainly small tweaks that I hope can be fixed. We also
have some issues with the popover behaviour and the length of the popovers
when you have a lot of content in them. But I have fixes for those, since
they concern the javascript code and the styles.

Here comes the list. Let me know if you have any questions.

TABLE 

* The page is missing the h1

* The Depends column heading should say ŒDependencies¹ instead

* The Brought in by column heading should say ŒReverse dependencies¹
instead

* The content of the help bubbles doesn¹t match the one in the prototype
(see http://www.yoctoproject.org/toaster/all-recipes.html)

* If the number of dependencies or reverse dependencies is 0, the cell
should be blank (it shows a button with 0 at the moment)

* The recipe version should be a link to the recipe details page, like the
recipe name is

* In the Dependencies column, the recipe name inside the popover title
should link to the build dependencies tab in the recipe details page (add
#dependencies to the current link)

* In the Reverse dependencies column, the recipe name inside the popover
title should link to the build reverse dependencies tab in the recipe
details page (add #brought-in-by to the current link)

SORTING

* There is no default sorting applied to the table. It should be sorted by
Recipe (caret down, i.e. A to Z)

* Disable sorting by recipe version

* The sorting spec at
https://bugzilla.yoctoproject.org/show_bug.cgi?id=4298 (see page 7)
specifies that ³If you use the Edit columns menu to hide the column with
the applied sorting, we revert the sorting to the default sorting (i.e.
Recipe)². This is currently not working, but I am not sure who should
tackle this (you? Alex?)

* Sorting by Layer, Layer branch and Layer directory returns an ³invalid
ordering² exception

SEARCH

The search spec is available at
https://bugzilla.yoctoproject.org/show_bug.cgi?id=4297

* The no results search page is not implemented (once again, I am not sure
who should tackle this one)

* Search by the following fields is not working: recipe version, recipe
file, license, layer, layer branch, layer commit and layer directory




On 06/02/2014 06:40, "Reyna, David" <david.reyna@windriver.com> wrote:

>Hi Alex and Belen,
> 
>* I have pushed my implementation of the Recipe Summary view to the
>branch ³dreyna/recipe-summary-view².
> 
>  
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/re
>cipe-summary-view 
><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/r
>ecipe-summary-view>
> 
>* There is only one exception to the design document that I am aware of.
> 
>In that document, you have a column titled ³Work directory², with the
>description ³The
> path to the WORKDIR for the target to which the task applies². I think
>that
> this is a cut/paste error, since (a) this field only exists within
>³task² records and not recipe records, and (b) this field does not appear
>in your sample page at ³yoctoproject.org/toaster².
>
> 
>If you did want this field, I could probably find the first task, grab
>its ³work_directory² field, and somehow trim it back to the recipe¹s
>general work directory, but it fear that this may be non-deterministic.
> 
>- David
> 
> 



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: recipe summary ready for review
  2014-02-06  9:08 ` Reyna, David
@ 2014-02-06 15:18   ` Barros Pena, Belen
  0 siblings, 0 replies; 8+ messages in thread
From: Barros Pena, Belen @ 2014-02-06 15:18 UTC (permalink / raw)
  To: Reyna, David L (Wind River), Damian, Alexandru; +Cc: toaster


On 06/02/2014 09:08, "Reyna, David" <david.reyna@windriver.com> wrote:

>Additionally as an implementation difference, the design document had
>filter icons on each of the headings, but none of the columns are ³choice
>fields² so that did not make sense.

You are completely right: there are no filters in the recipes table. The
document attached to 4294 is showing old screenshots. You can see the
latest version of the page (without any filters) at
http://www.yoctoproject.org/toaster/all-recipes.html

> 
>I therefore assumed that the simple default sorting facility was
>sufficient (though I explicitly disabled sorting for the composite pop-up
>columns of dependencies and commit IDs).

Yep, everybody seems to agree that sorting by those is not useful.

I will have a look at the branch today.

Thanks!!

Belén

> 
>- David
> 
>_____________________________________________
>From: Reyna, David
>Sent: Wednesday, February 05, 2014 10:40 PM
>To: Damian, Alexandru (alexandru.damian@intel.com);
>belen.barros.pena@intel.com
>Cc: toaster@yoctoproject.org
>Subject: recipe summary ready for review
> 
> 
>Hi Alex and Belen,
> 
>* I have pushed my implementation of the Recipe Summary view to the
>branch ³dreyna/recipe-summary-view².
> 
>  
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/re
>cipe-summary-view 
><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/r
>ecipe-summary-view>
> 
>* There is only one exception to the design document that I am aware of.
>
> 
>In that document, you have a column titled ³Work directory², with the
>description
> ³The path to the WORKDIR for the target to which the task applies². I
>think
> that this is a cut/paste error, since (a) this field only exists within
>³task² records and not recipe records, and (b) this field does not appear
>in your sample page at ³yoctoproject.org/toaster².
>
> 
>If you did want this field, I could probably find the first task, grab
>its ³work_directory² field, and somehow trim it back to the recipe¹s
>general work directory, but it fear that this may be non-deterministic.
> 
>- David
> 
> 



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: recipe summary ready for review
  2014-02-06 15:05 ` Barros Pena, Belen
@ 2014-02-06 17:39   ` Reyna, David
  2014-02-06 17:49     ` Barros Pena, Belen
  0 siblings, 1 reply; 8+ messages in thread
From: Reyna, David @ 2014-02-06 17:39 UTC (permalink / raw)
  To: BARROS PENA, BELEN, DAMIAN, ALEXANDRU; +Cc: 'toaster@yoctoproject.org'

Hi Belen,

How do I set the initial default sort column? Do I force the "sortby" value in my "views.py" class? If I do it that way, will it then reset that value every time my page is served, thereby breaking the ability to select other column sorts?

David

----- Original Message -----
From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
Sent: Thursday, February 06, 2014 07:05 AM
To: Reyna, David; DAMIAN, ALEXANDRU
Cc: toaster@yoctoproject.org <toaster@yoctoproject.org>
Subject: Re: recipe summary ready for review

Hi David,

This is a very impressive first go :)

I have a list of mainly small tweaks that I hope can be fixed. We also
have some issues with the popover behaviour and the length of the popovers
when you have a lot of content in them. But I have fixes for those, since
they concern the javascript code and the styles.

Here comes the list. Let me know if you have any questions.

TABLE 

* The page is missing the h1

* The Depends column heading should say ŒDependencies¹ instead

* The Brought in by column heading should say ŒReverse dependencies¹
instead

* The content of the help bubbles doesn¹t match the one in the prototype
(see http://www.yoctoproject.org/toaster/all-recipes.html)

* If the number of dependencies or reverse dependencies is 0, the cell
should be blank (it shows a button with 0 at the moment)

* The recipe version should be a link to the recipe details page, like the
recipe name is

* In the Dependencies column, the recipe name inside the popover title
should link to the build dependencies tab in the recipe details page (add
#dependencies to the current link)

* In the Reverse dependencies column, the recipe name inside the popover
title should link to the build reverse dependencies tab in the recipe
details page (add #brought-in-by to the current link)

SORTING

* There is no default sorting applied to the table. It should be sorted by
Recipe (caret down, i.e. A to Z)

* Disable sorting by recipe version

* The sorting spec at
https://bugzilla.yoctoproject.org/show_bug.cgi?id=4298 (see page 7)
specifies that ³If you use the Edit columns menu to hide the column with
the applied sorting, we revert the sorting to the default sorting (i.e.
Recipe)². This is currently not working, but I am not sure who should
tackle this (you? Alex?)

* Sorting by Layer, Layer branch and Layer directory returns an ³invalid
ordering² exception

SEARCH

The search spec is available at
https://bugzilla.yoctoproject.org/show_bug.cgi?id=4297

* The no results search page is not implemented (once again, I am not sure
who should tackle this one)

* Search by the following fields is not working: recipe version, recipe
file, license, layer, layer branch, layer commit and layer directory




On 06/02/2014 06:40, "Reyna, David" <david.reyna@windriver.com> wrote:

>Hi Alex and Belen,
> 
>* I have pushed my implementation of the Recipe Summary view to the
>branch ³dreyna/recipe-summary-view².
> 
>  
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/re
>cipe-summary-view 
><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/r
>ecipe-summary-view>
> 
>* There is only one exception to the design document that I am aware of.
> 
>In that document, you have a column titled ³Work directory², with the
>description ³The
> path to the WORKDIR for the target to which the task applies². I think
>that
> this is a cut/paste error, since (a) this field only exists within
>³task² records and not recipe records, and (b) this field does not appear
>in your sample page at ³yoctoproject.org/toaster².
>
> 
>If you did want this field, I could probably find the first task, grab
>its ³work_directory² field, and somehow trim it back to the recipe¹s
>general work directory, but it fear that this may be non-deterministic.
> 
>- David
> 
> 



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: recipe summary ready for review
  2014-02-06 17:39   ` Reyna, David
@ 2014-02-06 17:49     ` Barros Pena, Belen
  2014-02-06 17:59       ` Ravi Chintakunta
  0 siblings, 1 reply; 8+ messages in thread
From: Barros Pena, Belen @ 2014-02-06 17:49 UTC (permalink / raw)
  To: Reyna, David L (Wind River), Damian, Alexandru
  Cc: 'toaster@yoctoproject.org'

On 06/02/2014 17:39, "Reyna, David" <david.reyna@windriver.com> wrote:

>Hi Belen,
>
>How do I set the initial default sort column?

I know Ravi has done it for the Tasks table: maybe he or Alex can
recommend something.

Cheers

Belén

>Do I force the "sortby" value in my "views.py" class? If I do it that
>way, will it then reset that value every time my page is served, thereby
>breaking the ability to select other column sorts?
>
>David
>
>----- Original Message -----
>From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com]
>Sent: Thursday, February 06, 2014 07:05 AM
>To: Reyna, David; DAMIAN, ALEXANDRU
>Cc: toaster@yoctoproject.org <toaster@yoctoproject.org>
>Subject: Re: recipe summary ready for review
>
>Hi David,
>
>This is a very impressive first go :)
>
>I have a list of mainly small tweaks that I hope can be fixed. We also
>have some issues with the popover behaviour and the length of the popovers
>when you have a lot of content in them. But I have fixes for those, since
>they concern the javascript code and the styles.
>
>Here comes the list. Let me know if you have any questions.
>
>TABLE
>
>* The page is missing the h1
>
>* The Depends column heading should say ŒDependencies¹ instead
>
>* The Brought in by column heading should say ŒReverse dependencies¹
>instead
>
>* The content of the help bubbles doesn¹t match the one in the prototype
>(see http://www.yoctoproject.org/toaster/all-recipes.html)
>
>* If the number of dependencies or reverse dependencies is 0, the cell
>should be blank (it shows a button with 0 at the moment)
>
>* The recipe version should be a link to the recipe details page, like the
>recipe name is
>
>* In the Dependencies column, the recipe name inside the popover title
>should link to the build dependencies tab in the recipe details page (add
>#dependencies to the current link)
>
>* In the Reverse dependencies column, the recipe name inside the popover
>title should link to the build reverse dependencies tab in the recipe
>details page (add #brought-in-by to the current link)
>
>SORTING
>
>* There is no default sorting applied to the table. It should be sorted by
>Recipe (caret down, i.e. A to Z)
>
>* Disable sorting by recipe version
>
>* The sorting spec at
>https://bugzilla.yoctoproject.org/show_bug.cgi?id=4298 (see page 7)
>specifies that ³If you use the Edit columns menu to hide the column with
>the applied sorting, we revert the sorting to the default sorting (i.e.
>Recipe)². This is currently not working, but I am not sure who should
>tackle this (you? Alex?)
>
>* Sorting by Layer, Layer branch and Layer directory returns an ³invalid
>ordering² exception
>
>SEARCH
>
>The search spec is available at
>https://bugzilla.yoctoproject.org/show_bug.cgi?id=4297
>
>* The no results search page is not implemented (once again, I am not sure
>who should tackle this one)
>
>* Search by the following fields is not working: recipe version, recipe
>file, license, layer, layer branch, layer commit and layer directory
>
>
>
>
>On 06/02/2014 06:40, "Reyna, David" <david.reyna@windriver.com> wrote:
>
>>Hi Alex and Belen,
>>
>>* I have pushed my implementation of the Recipe Summary view to the
>>branch ³dreyna/recipe-summary-view².
>>
>>
>>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/r
>>e
>>cipe-summary-view
>><http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dreyna/
>>r
>>ecipe-summary-view>
>>
>>* There is only one exception to the design document that I am aware of.
>>
>>In that document, you have a column titled ³Work directory², with the
>>description ³The
>> path to the WORKDIR for the target to which the task applies². I think
>>that
>> this is a cut/paste error, since (a) this field only exists within
>>³task² records and not recipe records, and (b) this field does not appear
>>in your sample page at ³yoctoproject.org/toaster².
>>
>>
>>If you did want this field, I could probably find the first task, grab
>>its ³work_directory² field, and somehow trim it back to the recipe¹s
>>general work directory, but it fear that this may be non-deterministic.
>>
>>- David
>>
>>
>
>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: recipe summary ready for review
  2014-02-06 17:49     ` Barros Pena, Belen
@ 2014-02-06 17:59       ` Ravi Chintakunta
  0 siblings, 0 replies; 8+ messages in thread
From: Ravi Chintakunta @ 2014-02-06 17:59 UTC (permalink / raw)
  To: 'Barros Pena, Belen',
	'Reyna, David L (Wind River)',
	'Damian,	Alexandru'
  Cc: 'toaster@yoctoproject.org'

>  >Hi Belen,
>  >
>  >How do I set the initial default sort column?
>  
>  I know Ravi has done it for the Tasks table: maybe he or Alex can
>  recommend something.
>  

Hi David,

You would set the default sort column in a dictionary of parameters that are mandatory, like count, page and orderby. If the page request does not include the parameters, then these parameters will be added to the request and a page redirect will be sent. If you are already sorting on another column and the request includes that orderby parameter, that will not be changed.

The code snippet below from the tasks function gives you an idea about it:


def tasks(request, build_id):
    template = 'tasks.html'
    mandatory_parameters = { 'count': 25,  'page' : 1, 'orderby':'order:+'};
    retval = _verify_parameters( request.GET, mandatory_parameters )
    if retval:
        return _redirect_parameters( 'tasks', request.GET, mandatory_parameters, build_id = build_id)


Hope this helps.

Thanks,
Ravi

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2014-02-06 17:59 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-06  6:40 recipe summary ready for review Reyna, David
2014-02-06  9:08 ` Reyna, David
2014-02-06 15:18   ` Barros Pena, Belen
2014-02-06 10:38 ` Barros Pena, Belen
2014-02-06 15:05 ` Barros Pena, Belen
2014-02-06 17:39   ` Reyna, David
2014-02-06 17:49     ` Barros Pena, Belen
2014-02-06 17:59       ` Ravi Chintakunta

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.