Hi again,

> "I have the filter for the descriptions, but is depends on the presence of a space character"

Ok, I was able to redo and push the filter using a regex, so that will allow the possibility of a description that has characters but no spaces.

    ('Show only variables with description', 'description__regex:.+'),

- David

From: toaster-bounces@yoctoproject.org [mailto:toaster-bounces@yoctoproject.org] On Behalf Of Reyna, David
Sent: Friday, February 14, 2014 1:20 AM
To: belen.barros.pena@intel.com; Damian, Alexandru (alexandru.damian@intel.com)
Cc: toaster@yoctoproject.org
Subject: [Toaster] review request for configure details page

Hi Belen and Alex,

I have the configuration page ready for review at:  "dreyna/configure-detail-view"

Implementation Notes:

* In the file list pop-up dialog, I truncate the variable's value to 200 characters max.

The reason is that I discovered for variables (like "BBINCLUDE") with very long values, the pop-up is in fact unable by design to scroll to the end, to show the file list. I think that 200 characters give the right idea, and the result looks consistent with the more normal pop-ups.

* I have the file filters working for each of the indicated categories.

I will note that in my examinations that there were a few file types that were not covered by the existing categories, and I wondered if you were ok that.

    poky/meta/classes/*
    poky/bitbake/lib/bb/*

* I have the filter for the descriptions.

I ended on filtering on the presence of a space character, because I could not find an appropriate alternate field lookup. I suppose I could try a regex test.

* I implemented the file list such the last file is the one shown.

I was however curious if it is absolutely the case that the foreign key select on the VariableHistory table is guaranteed to be in time order. I did manually examine the first 100 rows and found that indeed that the rows were in primary key sequential order, but that is not proof.

Thanks,
David