From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 905EAC47254 for ; Sat, 2 May 2020 06:45:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EE652192A for ; Sat, 2 May 2020 06:45:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726745AbgEBGpK (ORCPT ); Sat, 2 May 2020 02:45:10 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:40713 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726473AbgEBGpK (ORCPT ); Sat, 2 May 2020 02:45:10 -0400 Received: from [192.168.1.91] (p4FEFC5A7.dip0.t-ipconnect.de [79.239.197.167]) by mail.holtmann.org (Postfix) with ESMTPSA id 45329CED2C; Sat, 2 May 2020 08:54:48 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH 00/20] crypto: introduce crypto_shash_tfm_digest() From: Marcel Holtmann In-Reply-To: <20200502053122.995648-1-ebiggers@kernel.org> Date: Sat, 2 May 2020 08:44:37 +0200 Cc: linux-crypto@vger.kernel.org, Cheng-Yi Chiang , ecryptfs@vger.kernel.org, Enric Balletbo i Serra , Gilad Ben-Yossef , Guenter Roeck , Jesper Nilsson , Kamil Konieczny , keyrings@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Opasiak , Lars Persson , linux-bluetooth , linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-sctp@vger.kernel.org, Robert Baldyga , Tom Lendacky , Vladimir Zapolskiy , Zaibo Xu Content-Transfer-Encoding: 7bit Message-Id: <5E6F9382-3D91-4587-980A-377E7CB086E4@holtmann.org> References: <20200502053122.995648-1-ebiggers@kernel.org> To: Eric Biggers X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Eric, > This series introduces a helper function crypto_shash_tfm_digest() which > replaces the following common pattern: > > { > SHASH_DESC_ON_STACK(desc, tfm); > int err; > > desc->tfm = tfm; > > err = crypto_shash_digest(desc, data, len, out); > > shash_desc_zero(desc); > } > > with: > > err = crypto_shash_tfm_digest(tfm, data, len, out); > > Patch 1 introduces this helper function, and patches 2-20 convert all > relevant users to use it. > > IMO, it would be easiest to take all these patches through the crypto > tree. But taking just the "crypto:" ones and then me trying to get the > rest merged later via subsystem trees is also an option. I am fine if you take the net/bluetooth/smp.c change through the crypto tree. Acked-by: Marcel Holtmann Regards Marcel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Holtmann Date: Sat, 02 May 2020 06:44:37 +0000 Subject: Re: [PATCH 00/20] crypto: introduce crypto_shash_tfm_digest() Message-Id: <5E6F9382-3D91-4587-980A-377E7CB086E4@holtmann.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20200502053122.995648-1-ebiggers@kernel.org> In-Reply-To: <20200502053122.995648-1-ebiggers@kernel.org> To: Eric Biggers Cc: linux-crypto@vger.kernel.org, Cheng-Yi Chiang , ecryptfs@vger.kernel.org, Enric Balletbo i Serra , Gilad Ben-Yossef , Guenter Roeck , Jesper Nilsson , Kamil Konieczny , keyrings@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Opasiak , Lars Persson , linux-bluetooth , linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-sctp@vger.kernel.org, Robert Baldyga , Tom Lendacky , Vladimir Zapolskiy , Zaibo Xu Hi Eric, > This series introduces a helper function crypto_shash_tfm_digest() which > replaces the following common pattern: > > { > SHASH_DESC_ON_STACK(desc, tfm); > int err; > > desc->tfm = tfm; > > err = crypto_shash_digest(desc, data, len, out); > > shash_desc_zero(desc); > } > > with: > > err = crypto_shash_tfm_digest(tfm, data, len, out); > > Patch 1 introduces this helper function, and patches 2-20 convert all > relevant users to use it. > > IMO, it would be easiest to take all these patches through the crypto > tree. But taking just the "crypto:" ones and then me trying to get the > rest merged later via subsystem trees is also an option. I am fine if you take the net/bluetooth/smp.c change through the crypto tree. Acked-by: Marcel Holtmann Regards Marcel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45827C3A5A9 for ; Sat, 2 May 2020 06:45:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1632E206F0 for ; Sat, 2 May 2020 06:45:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DtF56Dh9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1632E206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=holtmann.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MdB6uEfF+W9bR62au3Sr1FGfMMufdVH9PutUQdcEDHQ=; b=DtF56Dh9MH4v6b fGODS6Ar2t+wLPyC4vK+JPtAAkXwWdwxf3nE/tamsTl/CV28SKyItYrCXzJpDb/aNEkwmFMhUy7h7 egPkG7of7Yvg+4P6MVsO8Q5cdV5j35manjZEycliwukbC15+aUn9+wN+2BOeyRq0OtbKf108FSgIz x8DJNnYxcozX1KVGHHThSOQ/HybykdUrpSDrPsgNrgVIrdajvVAmGlZQX3Ax8srjWBqBTtWHu5sic iuoBWW+vXucvS2o60pK1m8Q4p73rqHhmusRVdNMPANMgKs0EonnXJExuDAbKBX5AAbD5J2ubV2spU +bqJozXKt2nlmeJ9+JCQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUltu-0005Fu-T0; Sat, 02 May 2020 06:45:26 +0000 Received: from coyote.holtmann.net ([212.227.132.17] helo=mail.holtmann.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUltq-0005Ep-6j for linux-mtd@lists.infradead.org; Sat, 02 May 2020 06:45:25 +0000 Received: from [192.168.1.91] (p4FEFC5A7.dip0.t-ipconnect.de [79.239.197.167]) by mail.holtmann.org (Postfix) with ESMTPSA id 45329CED2C; Sat, 2 May 2020 08:54:48 +0200 (CEST) Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH 00/20] crypto: introduce crypto_shash_tfm_digest() From: Marcel Holtmann In-Reply-To: <20200502053122.995648-1-ebiggers@kernel.org> Date: Sat, 2 May 2020 08:44:37 +0200 Message-Id: <5E6F9382-3D91-4587-980A-377E7CB086E4@holtmann.org> References: <20200502053122.995648-1-ebiggers@kernel.org> To: Eric Biggers X-Mailer: Apple Mail (2.3608.80.23.2.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200501_234522_390586_0E4B5AD6 X-CRM114-Status: UNSURE ( 9.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Lendacky , Jesper Nilsson , linux-bluetooth , Kamil Konieczny , Robert Baldyga , ecryptfs@vger.kernel.org, Krzysztof Opasiak , linux-nfs@vger.kernel.org, Krzysztof Kozlowski , Vladimir Zapolskiy , Gilad Ben-Yossef , linux-sctp@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, linux-crypto@vger.kernel.org, Enric Balletbo i Serra , Guenter Roeck , Zaibo Xu , Lars Persson , Cheng-Yi Chiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Eric, > This series introduces a helper function crypto_shash_tfm_digest() which > replaces the following common pattern: > > { > SHASH_DESC_ON_STACK(desc, tfm); > int err; > > desc->tfm = tfm; > > err = crypto_shash_digest(desc, data, len, out); > > shash_desc_zero(desc); > } > > with: > > err = crypto_shash_tfm_digest(tfm, data, len, out); > > Patch 1 introduces this helper function, and patches 2-20 convert all > relevant users to use it. > > IMO, it would be easiest to take all these patches through the crypto > tree. But taking just the "crypto:" ones and then me trying to get the > rest merged later via subsystem trees is also an option. I am fine if you take the net/bluetooth/smp.c change through the crypto tree. Acked-by: Marcel Holtmann Regards Marcel ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/