Re: [OE-core] [PATCH] bison: fix the parallel build

["Yu, Mingli" <mingli.yu@windriver.com>]

Hi Jacob,

On 05/14/20 15:55, Jacob Kroon wrote:
> Hi Mingli,
>
> On 5/14/20 9:39 AM, Yu, Mingli wrote:
>> From: Mingli Yu <mingli.yu@windriver.com>
>>
>> Explicitly make the BUILT_SOURCES which
>> are the generated headers such as stdio.h,
>> fcntl.h and etc to be the dependencies of
>> the gl_LIBOBJS such as libbison_a-sprintf.o,
>> libbison_a-printf.o and etc to guarantee the
>> BUILT_SOURCES is generated before begin to
>> compile EXTRA_lib_libbison_a_SOURCES such as
>> fprintf.c in parallel builid, otherwise there
>> may come below error:
>>   | muscle-tab.c:(.text+0x77a): undefined reference to `rpl_sprintf'
>>
>> It does the same for src_bison_OBJECTS and
>> lib_libbison_a_OBJECTS to make sure BUILT_SOURCES
>> generated before begin to compile src_bison_SOURCES
>> which contains AnnotationList.c and etc.
>>
>> BTW, the MOSTLYCLEANFILES also contains the
>> generated header needs to be created early
>> in the build process, so add it also in to
>> avoid below error:
>>   | ./lib/uniwidth/width.c:21:10: fatal error: uniwidth.h: No such
>> file or directory
>>
>> [YOCTO #13825]
>>
>> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
>> ---
>>   .../0001-bison-fix-the-parallel-build.patch   | 63 +++++++++++++++++++
>>   meta/recipes-devtools/bison/bison_3.5.4.bb    |  1 +
>>   2 files changed, 64 insertions(+)
>>   create mode 100644
>> meta/recipes-devtools/bison/bison/0001-bison-fix-the-parallel-build.patch
>>
>> diff --git
>> a/meta/recipes-devtools/bison/bison/0001-bison-fix-the-parallel-build.patch
>> b/meta/recipes-devtools/bison/bison/0001-bison-fix-the-parallel-build.patch
>>
>> new file mode 100644
>> index 0000000000..c3be91a109
>> --- /dev/null
>> +++
>> b/meta/recipes-devtools/bison/bison/0001-bison-fix-the-parallel-build.patch
>>
>> @@ -0,0 +1,63 @@
>> +From e0dbcee6e25b3c0cb11a627bbfe3af45ef67ec30 Mon Sep 17 00:00:00 2001
>> +From: Mingli Yu <mingli.yu@windriver.com>
>> +Date: Thu, 14 May 2020 15:23:16 +0800
>> +Subject: [PATCH] bison: fix the parallel build
>> +
>> +Explicitly make the BUILT_SOURCES which
>> +are the generated headers such as stdio.h,
>> +fcntl.h and etc to be the dependencies of
>> +the gl_LIBOBJS such as libbison_a-sprintf.o,
>> +libbison_a-printf.o and etc to guarantee the
>> +BUILT_SOURCES is generated before begin to
>> +compile EXTRA_lib_libbison_a_SOURCES such as
>> +fprintf.c in parallel builid, otherwise there
>> +may come below error:
>> + | muscle-tab.c:(.text+0x77a): undefined reference to `rpl_sprintf'
>> +
>> +It does the same for src_bison_OBJECTS and
>> +lib_libbison_a_OBJECTS to make sure BUILT_SOURCES
>> +generated before begin to compile src_bison_SOURCES
>> +which contains AnnotationList.c and etc.
>> +
>> +BTW, the MOSTLYCLEANFILES also contains the
>> +generated header needs to be created early
>> +in the build process, so add it also in to
>> +avoid below error:
>> + | ./lib/uniwidth/width.c:21:10: fatal error: uniwidth.h: No such
>> file or directory
>> +
>> +Upstream-Status: Submitted [bison-patches@gnu.org maillist]
>> +
>
> I can't find the patch email in the bison-patches mailing list archive,
> do you have a link url ?

Good catch, that's why I didn't paste the link in the Submitted part.

BTW, I also cannot find at
https://lists.gnu.org/archive/html/bison-patches/2020-05/threads.html 
though I indeed sent to bison-patches@gnu.org.

Thanks,
Mingli

>
> /Jacob
>