On 07/04/20 08:02, Thomas Huth wrote:
TFR is a macro that is defined in our qemu-common.h header ... does it
work if you add a #include "qemu-common.h" somewhere at the beginning of
net/tap-solaris.c ?
Yes, thank you, that fixed it:

root@hemlock:~/qemu-5.0.0# gmake -j16
gmake[1]: Entering directory '/export/home/denber/qemu-5.0.0/slirp'
grep: illegal option -- m
Usage: grep [-c|-l|-q] -bhinsvw pattern file . . .
gmake[1]: Nothing to be done for 'all'.
gmake[1]: Leaving directory '/export/home/denber/qemu-5.0.0/slirp'
        CHK version_gen.h
  CC      net/tap-solaris.o
  LINK    moxie-softmmu/qemu-system-moxie
  LINK    cris-softmmu/qemu-system-cris
  LINK    microblaze-softmmu/qemu-system-microblaze
  LINK    microblazeel-softmmu/qemu-system-microblazeel
  LINK    nios2-softmmu/qemu-system-nios2
  LINK    lm32-softmmu/qemu-system-lm32
  LINK    m68k-softmmu/qemu-system-m68k
  LINK    hppa-softmmu/qemu-system-hppa
  LINK    alpha-softmmu/qemu-system-alpha
  LINK    mips64-softmmu/qemu-system-mips64
  LINK    mips64el-softmmu/qemu-system-mips64el
  LINK    mipsel-softmmu/qemu-system-mipsel
  LINK    mips-softmmu/qemu-system-mips
  LINK    i386-softmmu/qemu-system-i386
  LINK    aarch64-softmmu/qemu-system-aarch64
  LINK    arm-softmmu/qemu-system-arm
  LINK    or1k-softmmu/qemu-system-or1k
  CC      s390x-softmmu/gen-features
/bin/sh: cc: not found
gmake[1]: *** [/export/home/denber/qemu-5.0.0/target/s390x/Makefile.objs:25: /export/home/denber/qemu-5.0.0/s390x-softmmu/gen-features] Error 127
gmake: *** [Makefile:527: s390x-softmmu/all] Error 2
gmake: *** Waiting for unfinished jobs....
  LINK    rx-softmmu/qemu-system-rx
  LINK    riscv32-softmmu/qemu-system-riscv32
  LINK    riscv64-softmmu/qemu-system-riscv64
  LINK    ppc64-softmmu/qemu-system-ppc64
  LINK    ppc-softmmu/qemu-system-ppc
root@hemlock:~/qemu-5.0.0#


I still have one grep/ggrep issue and one "wrong sh" issue.  And it doesn't look like it really completed correctly because for example I see:

root@hemlock:~/qemu-5.0.0# cd x86_64-softmmu
root@hemlock:~/qemu-5.0.0/x86_64-softmmu# ls
config-devices.mak      config-devices.mak.old  Makefile
config-devices.mak.d    config-target.mak
root@hemlock:~/qemu-5.0.0/x86_64-softmmu#


So even though gmake finished, it didn't make at least one VM.  Is that because of the two remaining errors?

            - Michele