From: Alex Bligh <alex@alex.org.uk>
To: Alex Gartrell <agartrell@fb.com>
Cc: Alex Bligh <alex@alex.org.uk>, Arnd Bergmann <arnd@arndb.de>,
Josef Bacik <jbacik@fb.com>, Jens Axboe <axboe@fb.com>,
Greg KH <gregkh@linuxfoundation.org>,
Kernel Team <Kernel-team@fb.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"nbd-general@lists.sourceforge.net"
<nbd-general@lists.sourceforge.net>
Subject: Re: [Nbd] [PATCH 4/4] nbd: add a nbd-control interface
Date: Wed, 25 Jan 2017 18:25:11 +0000 [thread overview]
Message-ID: <5F1F69A4-CDE1-4519-9FB4-C6B1DED5BBAE@alex.org.uk> (raw)
In-Reply-To: <F7E2FE6F-B7A8-4A36-854D-AE1620D88762@fb.com>
> On 25 Jan 2017, at 16:48, Alex Gartrell <agartrell@fb.com> wrote:
>
>
> If nbd were *all* netlink I think that that'd be fine, but you'd have
> problems implementing the NBD_DOIT function in that fashion. So I'd
> rather stick to the char device ioctl thing because it's more
> consistent with the old NBD stuff as well as the loop device stuff.
I spend most of my time looking at the userspace side of NBD so
apologies if this is off base.
Given (because of NBD_DO_IT) we need an ioctl anyway, and we have
an ioctl that isn't going to go away, it would seem better if possible
to stick with ioctls, and not introduce either a dependency
on netlink (which would presumably bloat static binaries that
are used early in the boot process). Personally I'd have thought
adding a new NBD ioctl (or extending an existing one) would be
less entropy than adding a new char device.
--
Alex Bligh
next prev parent reply other threads:[~2017-01-25 18:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 21:56 [PATCH 1/4] nbd: use our own workqueue for recv threads Josef Bacik
2017-01-20 21:56 ` [PATCH 2/4] miscdevice: add a minor number for nbd-control Josef Bacik
2017-01-21 9:03 ` Greg KH
2017-01-21 13:25 ` Josef Bacik
2017-01-22 11:09 ` Greg KH
2017-01-20 21:56 ` [PATCH 3/4] nbd: use an idr to keep track of nbd devices Josef Bacik
2017-01-20 21:56 ` [PATCH 4/4] nbd: add a nbd-control interface Josef Bacik
2017-01-21 9:05 ` Greg KH
2017-01-23 14:42 ` Josef Bacik
2017-01-23 14:52 ` Greg KH
2017-01-23 14:57 ` Josef Bacik
2017-01-23 15:03 ` Greg KH
2017-01-23 15:52 ` Josef Bacik
2017-01-24 7:11 ` Greg KH
2017-01-25 8:55 ` [Nbd] " Wouter Verhelst
2017-01-25 13:47 ` Josef Bacik
2017-01-25 14:23 ` Arnd Bergmann
2017-01-25 16:48 ` Alex Gartrell
2017-01-25 18:21 ` [Nbd] " Wouter Verhelst
2017-01-25 18:25 ` Alex Bligh [this message]
2017-01-25 21:30 ` Greg KH
2017-01-25 21:36 ` Eric Blake
2017-01-26 8:40 ` Christoph Hellwig
2017-01-26 9:17 ` Greg KH
2017-01-26 13:17 ` Christoph Hellwig
2017-01-25 18:24 ` Paul Clements
2017-01-21 12:11 ` Wouter Verhelst
2017-01-21 13:44 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F1F69A4-CDE1-4519-9FB4-C6B1DED5BBAE@alex.org.uk \
--to=alex@alex.org.uk \
--cc=Kernel-team@fb.com \
--cc=agartrell@fb.com \
--cc=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbacik@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=nbd-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.