From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752998AbbKILJB (ORCPT ); Mon, 9 Nov 2015 06:09:01 -0500 Received: from mga01.intel.com ([192.55.52.88]:33622 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbbKILJA convert rfc822-to-8bit (ORCPT ); Mon, 9 Nov 2015 06:09:00 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,265,1444719600"; d="scan'208";a="831570931" From: "Drokin, Oleg" To: James Simmons CC: Greg Kroah-Hartman , "" , "Dilger, Andreas" , Linux Kernel Mailing List , "" Subject: Re: [lustre-devel] [PATCH] staging: lustre: export cfs_str2mask Thread-Topic: [lustre-devel] [PATCH] staging: lustre: export cfs_str2mask Thread-Index: AQHRGkN29O5e/ZW6r06IQLd1ZWDTeJ6UD5KA Date: Mon, 9 Nov 2015 11:08:43 +0000 Message-ID: <5F41E759-F653-4A35-B2E5-15544BCF4BD2@intel.com> References: <1447000500-29427-1-git-send-email-jsimmons@infradead.org> <1447000500-29427-6-git-send-email-jsimmons@infradead.org> In-Reply-To: <1447000500-29427-6-git-send-email-jsimmons@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.187.54] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Nov 8, 2015, at 11:34 AM, James Simmons wrote: > We need cfs_str2mask exported for our server code. > Even with the server code not available upstream > it would be nice to use the upstream code on Lustre > servers. > > Signed-off-by: James Simmons > --- > .../staging/lustre/lustre/libcfs/libcfs_string.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c > index d40be53..05630f8 100644 > --- a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c > +++ b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c > @@ -111,6 +111,7 @@ int cfs_str2mask(const char *str, const char *(*bit2str)(int bit), > *oldmask = newmask; > return 0; > } > +EXPORT_SYMBOL(cfs_str2mask); If this is the case of it being used out of tree, I suspect a comment here to that effect would be useful, otherwise next person running a script to eliminate unused EXPORT_SYMBOLs would kill it again. > > /* get the first string out of @str */ > char *cfs_firststr(char *str, size_t size) > -- > 1.7.1 > > _______________________________________________ > lustre-devel mailing list > lustre-devel@lists.lustre.org > http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Drokin, Oleg Date: Mon, 9 Nov 2015 11:08:43 +0000 Subject: [lustre-devel] [PATCH] staging: lustre: export cfs_str2mask In-Reply-To: <1447000500-29427-6-git-send-email-jsimmons@infradead.org> References: <1447000500-29427-1-git-send-email-jsimmons@infradead.org> <1447000500-29427-6-git-send-email-jsimmons@infradead.org> Message-ID: <5F41E759-F653-4A35-B2E5-15544BCF4BD2@intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lustre-devel@lists.lustre.org On Nov 8, 2015, at 11:34 AM, James Simmons wrote: > We need cfs_str2mask exported for our server code. > Even with the server code not available upstream > it would be nice to use the upstream code on Lustre > servers. > > Signed-off-by: James Simmons > --- > .../staging/lustre/lustre/libcfs/libcfs_string.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c > index d40be53..05630f8 100644 > --- a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c > +++ b/drivers/staging/lustre/lustre/libcfs/libcfs_string.c > @@ -111,6 +111,7 @@ int cfs_str2mask(const char *str, const char *(*bit2str)(int bit), > *oldmask = newmask; > return 0; > } > +EXPORT_SYMBOL(cfs_str2mask); If this is the case of it being used out of tree, I suspect a comment here to that effect would be useful, otherwise next person running a script to eliminate unused EXPORT_SYMBOLs would kill it again. > > /* get the first string out of @str */ > char *cfs_firststr(char *str, size_t size) > -- > 1.7.1 > > _______________________________________________ > lustre-devel mailing list > lustre-devel at lists.lustre.org > http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org