From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sandeen.net ([63.231.237.45]:34725 "EHLO sandeen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755228Ab3COOg3 convert rfc822-to-8bit (ORCPT ); Fri, 15 Mar 2013 10:36:29 -0400 References: <1363186623-1378-1-git-send-email-sandeen@redhat.com> <1363186623-1378-4-git-send-email-sandeen@redhat.com> <5140AB9D.2070001@redhat.com> <5140CB3F.5010704@redhat.com> <5140CD26.7050201@sandeen.net> <20130315101625.GE6369@dastard> <737235E6-72C8-45F5-A6F4-EEEFD094706E@redhat.com> <51432EC5.5090208@sgi.com> Mime-Version: 1.0 (1.0) In-Reply-To: <51432EC5.5090208@sgi.com> Content-Type: text/plain; charset=us-ascii Message-Id: <5F46F0D0-1C1D-4F53-A2DE-9D39A85D078F@sandeen.net> Cc: Eric Sandeen , Dave Chinner , Eric Sandeen , "linux-btrfs@vger.kernel.org" , "xfs@oss.sgi.com" From: Eric Sandeen Subject: Re: [PATCH 3/3 V4] xfstests: btrfs tests for basic informational commands Date: Fri, 15 Mar 2013 09:36:23 -0500 To: Rich Johnston Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Mar 15, 2013, at 9:23 AM, Rich Johnston wrote: > On 03/15/2013 08:46 AM, Eric Sandeen wrote: >> Yep sorry. I figure its always a race in numbers do I don't bother with fixing them up. Should I? > > Eric, > I was going to revert and resubmit as test 306, is that OK with you? > Sure, of course. Thanks, Eric >> On Mar 15, 2013, at 5:16 AM, Dave Chinner wrote: >> >>> On Wed, Mar 13, 2013 at 02:01:58PM -0500, Eric Sandeen wrote: >>>> Run basic btrfs information commands in various ways, performing >>>> sanity tests of: filesystem show, label, sync, and device stats >>>> (sync is included just because it's simple). These are mostly >>>> just smoke tests, although for example show by label & UUID >>>> should verify that the correct fs was shown. >>>> >>>> This also add2730c49a3s quite a few new filters to accommodate the output >>>> of the new commands. >>>> >>>> Cc: linux-btrfs@vger.kernel.org >>>> Signed-off-by: Eric Sandeen >>>> --- >>>> >>>> V2: sort & uniq device stats output to account for variable >>>> nrs. of devices. Optionally check that the proper nr. of >>>> devices was returned, as well. >>>> >>>> V3: _filter_uuid needs to pay attention to $1, not hope >>>> that the caller has set $UUID. Oops. >>>> >>>> V4: fix stats filter to set UNIQ_OPT in both cases, ugh. >>> >>> Something I just noticed in this commit: >>> >>>> +# get standard environment, filters and checks >>>> +. ./common.rc >>>> +. ./btrfs.filter >>> >>> That should probably have been named "common.filter.btrfs". > > Dave, > Do you want me to rename btrfs.filter to common.filter.btrfs when I resubmit this patch? > > Regards > --Rich > >>> I found this updating my patchset that moves all the common.* files >>> into a common/ directory.... >>> >>> I'll rename it to common/filter.btrfs.... >>> >>> Cheers, >>> >>> Dave. >>> -- >>> Dave Chinner >>> david@fromorbit.com >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> _______________________________________________ >> xfs mailing list >> xfs@oss.sgi.com >> http://oss.sgi.com/mailman/listinfo/xfs > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 3CA447FE6 for ; Fri, 15 Mar 2013 09:36:33 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id 1F032304032 for ; Fri, 15 Mar 2013 07:36:30 -0700 (PDT) Received: from sandeen.net (sandeen.net [63.231.237.45]) by cuda.sgi.com with ESMTP id OMQduVehgw8OXetT for ; Fri, 15 Mar 2013 07:36:29 -0700 (PDT) References: <1363186623-1378-1-git-send-email-sandeen@redhat.com> <1363186623-1378-4-git-send-email-sandeen@redhat.com> <5140AB9D.2070001@redhat.com> <5140CB3F.5010704@redhat.com> <5140CD26.7050201@sandeen.net> <20130315101625.GE6369@dastard> <737235E6-72C8-45F5-A6F4-EEEFD094706E@redhat.com> <51432EC5.5090208@sgi.com> Mime-Version: 1.0 (1.0) In-Reply-To: <51432EC5.5090208@sgi.com> Message-Id: <5F46F0D0-1C1D-4F53-A2DE-9D39A85D078F@sandeen.net> From: Eric Sandeen Subject: Re: [PATCH 3/3 V4] xfstests: btrfs tests for basic informational commands Date: Fri, 15 Mar 2013 09:36:23 -0500 List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Rich Johnston Cc: Eric Sandeen , Eric Sandeen , "linux-btrfs@vger.kernel.org" , "xfs@oss.sgi.com" On Mar 15, 2013, at 9:23 AM, Rich Johnston wrote: > On 03/15/2013 08:46 AM, Eric Sandeen wrote: >> Yep sorry. I figure its always a race in numbers do I don't bother with fixing them up. Should I? > > Eric, > I was going to revert and resubmit as test 306, is that OK with you? > Sure, of course. Thanks, Eric >> On Mar 15, 2013, at 5:16 AM, Dave Chinner wrote: >> >>> On Wed, Mar 13, 2013 at 02:01:58PM -0500, Eric Sandeen wrote: >>>> Run basic btrfs information commands in various ways, performing >>>> sanity tests of: filesystem show, label, sync, and device stats >>>> (sync is included just because it's simple). These are mostly >>>> just smoke tests, although for example show by label & UUID >>>> should verify that the correct fs was shown. >>>> >>>> This also add2730c49a3s quite a few new filters to accommodate the output >>>> of the new commands. >>>> >>>> Cc: linux-btrfs@vger.kernel.org >>>> Signed-off-by: Eric Sandeen >>>> --- >>>> >>>> V2: sort & uniq device stats output to account for variable >>>> nrs. of devices. Optionally check that the proper nr. of >>>> devices was returned, as well. >>>> >>>> V3: _filter_uuid needs to pay attention to $1, not hope >>>> that the caller has set $UUID. Oops. >>>> >>>> V4: fix stats filter to set UNIQ_OPT in both cases, ugh. >>> >>> Something I just noticed in this commit: >>> >>>> +# get standard environment, filters and checks >>>> +. ./common.rc >>>> +. ./btrfs.filter >>> >>> That should probably have been named "common.filter.btrfs". > > Dave, > Do you want me to rename btrfs.filter to common.filter.btrfs when I resubmit this patch? > > Regards > --Rich > >>> I found this updating my patchset that moves all the common.* files >>> into a common/ directory.... >>> >>> I'll rename it to common/filter.btrfs.... >>> >>> Cheers, >>> >>> Dave. >>> -- >>> Dave Chinner >>> david@fromorbit.com >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> _______________________________________________ >> xfs mailing list >> xfs@oss.sgi.com >> http://oss.sgi.com/mailman/listinfo/xfs > > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs