Re: [PATCH] xen/arm: gic-hip04: Resync the driver with the GICv2

[Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>]

Hi Julien/Zoli,

>http://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=shortlog;h=refs/heads/for-huawei/gicv2-on-gicv3
I had a run of this staging on our D01 board.

Xen fails to boot with below error:
(XEN) domain 0: vGIC requested is not supported
(XEN) CPU0: Unexpected Trap: Data Abort

After going through the code, it looks to me that hip04 gicv2_info is missing the vgic_versions initialisation. Made the following changes and xen booted and started dom0.

--- ../xen-org/arch/arm/gic-hip04.c   2015-06-01 16:33:40.000000000 +0100
+++ ./xen/arch/arm/gic-hip04.c  2015-06-09 13:21:44.355012016 +0100
@@ -735,6 +735,7 @@ static int __init hip04gic_preinit(struc
                                    const void *data)
 {
     gicv2_info.hw_version = GIC_V2;
+    gicv2_info.vgic_versions = GIC_V2;
     gicv2_info.node = node;
     register_gic_ops(&hip04gic_ops);
     dt_irq_xlate = gic_irq_xlate;

(Sorry, this is a diff not a proper git patch)
Please correct me, if this is not the correct way to init the vgic_versions.

Regards,
Shameer

-----Original Message-----
From: Julien Grall [mailto:julien.grall@citrix.com] 
Sent: 01 June 2015 16:35
To: Zoltan Kiss; Julien Grall; Ian Campbell
Cc: xen-devel@lists.xenproject.org; stefano.stabellini@citrix.com; tim@xen.org; Shameerali Kolothum Thodi; Zoltan Kiss
Subject: Re: [Xen-devel] [PATCH] xen/arm: gic-hip04: Resync the driver with the GICv2

On 01/06/15 14:18, Zoltan Kiss wrote:
> Sure. Btw. do you have them in a public repo somewhere? It would make 
> it a little bit easier to apply and test.

It's based on the latest staging:

http://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=shortlog;h=refs/heads/for-huawei/gicv2-on-gicv3

Regards,

--
Julien Grall