From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shameerali Kolothum Thodi Subject: RE: [RFCv2 PATCH 14/36] iommu/arm-smmu-v3: Add support for Substream IDs Date: Thu, 2 Nov 2017 17:02:27 +0000 Message-ID: <5FC3163CFD30C246ABAA99954A238FA838454A9B@FRAEML521-MBX.china.huawei.com> References: <20171006133203.22803-1-jean-philippe.brucker@arm.com> <20171006133203.22803-15-jean-philippe.brucker@arm.com> <5FC3163CFD30C246ABAA99954A238FA838454887@FRAEML521-MBX.china.huawei.com> <20171102155152.GA11899@e106794-lin.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from lhrrgout.huawei.com ([194.213.3.17]:39626 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbdKBRDw (ORCPT ); Thu, 2 Nov 2017 13:03:52 -0400 In-Reply-To: <20171102155152.GA11899@e106794-lin.localdomain> Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jean-Philippe Brucker Cc: "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "devicetree@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Mark Rutland , "xieyisheng (A)" , Gabriele Paoloni , Catalin Marinas , Will Deacon , "okaya@codeaurora.org" , "yi.l.liu@intel.com" , Lorenzo Pieralisi , "ashok.raj@intel.com" , "tn@semihalf.com" , joro@8bytes.or DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmVhbi1QaGlsaXBwZSBC cnVja2VyIFttYWlsdG86SmVhbi1QaGlsaXBwZS5CcnVja2VyQGFybS5jb21dDQo+IFNlbnQ6IFRo dXJzZGF5LCBOb3ZlbWJlciAwMiwgMjAxNyAzOjUyIFBNDQo+IFRvOiBTaGFtZWVyYWxpIEtvbG90 aHVtIFRob2RpIDxzaGFtZWVyYWxpLmtvbG90aHVtLnRob2RpQGh1YXdlaS5jb20+DQo+IENjOiBs aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LXBjaUB2Z2VyLmtlcm5l bC5vcmc7IGxpbnV4LQ0KPiBhY3BpQHZnZXIua2VybmVsLm9yZzsgZGV2aWNldHJlZUB2Z2VyLmtl cm5lbC5vcmc7IGlvbW11QGxpc3RzLmxpbnV4LQ0KPiBmb3VuZGF0aW9uLm9yZzsgTWFyayBSdXRs YW5kIDxNYXJrLlJ1dGxhbmRAYXJtLmNvbT47IHhpZXlpc2hlbmcgKEEpDQo+IDx4aWV5aXNoZW5n MUBodWF3ZWkuY29tPjsgR2FicmllbGUgUGFvbG9uaQ0KPiA8Z2FicmllbGUucGFvbG9uaUBodWF3 ZWkuY29tPjsgQ2F0YWxpbiBNYXJpbmFzDQo+IDxDYXRhbGluLk1hcmluYXNAYXJtLmNvbT47IFdp bGwgRGVhY29uIDxXaWxsLkRlYWNvbkBhcm0uY29tPjsNCj4gb2theWFAY29kZWF1cm9yYS5vcmc7 IHlpLmwubGl1QGludGVsLmNvbTsgTG9yZW56byBQaWVyYWxpc2kNCj4gPExvcmVuem8uUGllcmFs aXNpQGFybS5jb20+OyBhc2hvay5yYWpAaW50ZWwuY29tOyB0bkBzZW1paGFsZi5jb207DQo+IGpv cm9AOGJ5dGVzLm9yZzsgcmZyYW56QGNhdml1bS5jb207IGxlbmJAa2VybmVsLm9yZzsNCj4gamFj b2IuanVuLnBhbkBsaW51eC5pbnRlbC5jb207IGFsZXgud2lsbGlhbXNvbkByZWRoYXQuY29tOw0K PiByb2JoK2R0QGtlcm5lbC5vcmc7IExlaXpoZW4gKFRodW5kZXJUb3duKSA8dGh1bmRlci5sZWl6 aGVuQGh1YXdlaS5jb20+Ow0KPiBiaGVsZ2Fhc0Bnb29nbGUuY29tOyBkd213MkBpbmZyYWRlYWQu b3JnOyBsaXVibyAoQ1UpDQo+IDxsaXVibzk1QGh1YXdlaS5jb20+OyByandAcmp3eXNvY2tpLm5l dDsgcm9iZGNsYXJrQGdtYWlsLmNvbTsNCj4gaGFuanVuLmd1b0BsaW5hcm8ub3JnOyBTdWRlZXAg SG9sbGEgPFN1ZGVlcC5Ib2xsYUBhcm0uY29tPjsgUm9iaW4NCj4gTXVycGh5IDxSb2Jpbi5NdXJw aHlAYXJtLmNvbT47IG53YXR0ZXJzQGNvZGVhdXJvcmEub3JnOyBMaW51eGFybQ0KPiA8bGludXhh cm1AaHVhd2VpLmNvbT4NCj4gU3ViamVjdDogUmU6IFtSRkN2MiBQQVRDSCAxNC8zNl0gaW9tbXUv YXJtLXNtbXUtdjM6IEFkZCBzdXBwb3J0IGZvcg0KPiBTdWJzdHJlYW0gSURzDQo+IA0KPiBIaSBT aGFtZWVyLA0KPiANCj4gT24gVGh1LCBOb3YgMDIsIDIwMTcgYXQgMTI6NDk6MzJQTSArMDAwMCwg U2hhbWVlcmFsaSBLb2xvdGh1bSBUaG9kaSB3cm90ZToNCj4gPiBXZSBoYWQgYSBnbyB3aXRoIHRo aXMgc2VyaWVzIG9uIEhpU0lsaWNvbiBEMDUgcGxhdGZvcm0gd2hpY2ggZG9lc24ndCBoYXZlDQo+ ID4gc3VwcG9ydCBmb3Igc3NpZHMvQVRTL1BSSSwgdG8gbWFrZSBzdXJlIGl0IGdlbmVyYWxseSB3 b3Jrcy4NCj4gPg0KPiA+IEJ1dCBvYnNlcnZlZCB0aGUgYmVsb3cgY3Jhc2ggb24gYm9vdCwNCj4g Pg0KPiA+IFsgICAxNi4wMDkwODRdIFdBUk5JTkc6IENQVTogNTkgUElEOiAzOTEgYXQgbW0vcGFn ZV9hbGxvYy5jOjM4ODMNCj4gX19hbGxvY19wYWdlc19ub2RlbWFzaysweDE5Yy8weGM0OA0KPiA+ IFsgICAxNi4wMjY3OTddIE1vZHVsZXMgbGlua2VkIGluOg0KPiA+IFsgICAxNi4wMzI5NDRdIENQ VTogNTkgUElEOiAzOTEgQ29tbToga3dvcmtlci81OToxIE5vdCB0YWludGVkIDQuMTQuMC1yYzEt DQo+IDE1OTUzOS1nZTQyYWNhMyAjMjM2DQo+ID4gWy4uLl0NCj4gPiBbICAgMTYuMDY4MjA2XSBX b3JrcXVldWU6IGV2ZW50cyBkZWZlcnJlZF9wcm9iZV93b3JrX2Z1bmMNCj4gPiBbICAgMTYuMDc4 NTU3XSB0YXNrOiBmZmZmODAxN2QzOGEwMDAwIHRhc2suc3RhY2s6IGZmZmYwMDAwMGIxOTgwMDAN Cj4gPiBbICAgMTYuMDkwNDg2XSBQQyBpcyBhdCBfX2FsbG9jX3BhZ2VzX25vZGVtYXNrKzB4MTlj LzB4YzQ4DQo+ID4gWyAgIDE2LjEwMTAxM10gTFIgaXMgYXQgX19hbGxvY19wYWdlc19ub2RlbWFz aysweGUwLzB4YzQ4DQo+ID4gWyAgIDE2LjQ2OTIyMF0gWzxmZmZmMDAwMDA4MTg2Yjk0Pl0gX19h bGxvY19wYWdlc19ub2RlbWFzaysweDE5Yy8weGM0OA0KPiA+IFsgICAxNi40ODE4NTRdIFs8ZmZm ZjAwMDAwODFkNjViMD5dIGFsbG9jX3BhZ2VzX2N1cnJlbnQrMHg4MC8weGNjDQo+ID4gWyAgIDE2 LjQ5MzYwN10gWzxmZmZmMDAwMDA4MTgyYmU4Pl0gX19nZXRfZnJlZV9wYWdlcysweGMvMHgzOA0K PiA+IFsgICAxNi41MDQ2NjFdIFs8ZmZmZjAwMDAwODNjNGQ1OD5dIHN3aW90bGJfYWxsb2NfY29o ZXJlbnQrMHg2NC8weDE5MA0KPiA+IFsgICAxNi41MTcxMTddIFs8ZmZmZjAwMDAwODA5ODI0Yz5d IF9fZG1hX2FsbG9jKzB4MTEwLzB4MjA0DQo+ID4gWyAgIDE2LjUyNzgyMF0gWzxmZmZmMDAwMDA4 NThlODUwPl0gZG1hbV9hbGxvY19jb2hlcmVudCsweDg4LzB4ZjANCj4gPiBbICAgMTYuNTM5NTc1 XSBbPGZmZmYwMDAwMDg1Njg4ODQ+XQ0KPiBhcm1fc21tdV9kb21haW5fZmluYWxpc2VfczErMHg2 MC8weDI0OA0KPiA+IFsgICAxNi41NTI5MDldIFs8ZmZmZjAwMDAwODU2YzEwND5dIGFybV9zbW11 X2F0dGFjaF9kZXYrMHgyNjQvMHgzMDANCj4gPiBbICAgMTYuNTY1MDEzXSBbPGZmZmYwMDAwMDg1 NWQ0MGM+XSBfX2lvbW11X2F0dGFjaF9kZXZpY2UrMHg0OC8weDVjDQo+ID4gWyAgIDE2LjU3NzEx N10gWzxmZmZmMDAwMDA4NTVlNjk4Pl0gaW9tbXVfZ3JvdXBfYWRkX2RldmljZSsweDE0NC8weDNh NA0KPiA+IFsgICAxNi41ODk3NDZdIFs8ZmZmZjAwMDAwODU1ZWQxOD5dIGlvbW11X2dyb3VwX2dl dF9mb3JfZGV2KzB4NzAvMHhmOA0KPiA+IFsgICAxNi42MDIyMDFdIFs8ZmZmZjAwMDAwODU2YTMx ND5dIGFybV9zbW11X2FkZF9kZXZpY2UrMHgxYTQvMHg0MTgNCj4gPiBbICAgMTYuNjE0MzA4XSBb PGZmZmYwMDAwMDg0OWRmY2M+XSBpb3J0X2lvbW11X2NvbmZpZ3VyZSsweGYwLzB4MTZjDQo+ID4g WyAgIDE2LjYyNjQxNl0gWzxmZmZmMDAwMDA4NDY4YzUwPl0gYWNwaV9kbWFfY29uZmlndXJlKzB4 MzAvMHg3MA0KPiA+IFsgICAxNi42Mzc5OTRdIFs8ZmZmZjAwMDAwODU4ZjAwYz5dIGRtYV9jb25m aWd1cmUrMHhhOC8weGQ0DQo+ID4gWyAgIDE2LjY0ODY5NV0gWzxmZmZmMDAwMDA4NTc3MDZjPl0g ZHJpdmVyX3Byb2JlX2RldmljZSsweDFhNC8weDJkYw0KPiA+IFsgICAxNi42NzMwODFdIFs8ZmZm ZjAwMDAwODU3NTJjOD5dIGJ1c19mb3JfZWFjaF9kcnYrMHg1NC8weDk0DQo+ID4gWyAgIDE2LjY4 NDMwN10gWzxmZmZmMDAwMDA4NTc2ZGIwPl0gX19kZXZpY2VfYXR0YWNoKzB4YzQvMHgxMmMNCj4g PiBbICAgMTYuNjk1NTMzXSBbPGZmZmYwMDAwMDg1NzczNTA+XSBkZXZpY2VfaW5pdGlhbF9wcm9i ZSsweDEwLzB4MTgNCj4gPiBbICAgMTYuNzA3NDYyXSBbPGZmZmYwMDAwMDg1NzYyYjQ+XSBidXNf cHJvYmVfZGV2aWNlKzB4OTAvMHg5OA0KPiA+DQo+ID4gQWZ0ZXIgYSBiaXQgb2YgZGVidWcgaXQg bG9va3MgbGlrZSBvbiBwbGF0Zm9ybXMgd2hlcmUgc3NpZCBpcyBub3Qgc3VwcG9ydGVkLA0KPiA+ IHMxX2NmZy5udW1fY29udGV4dHMgaXMgc2V0IHRvIHplcm8gYW5kIGl0IGV2ZW50dWFsbHkgcmVz dWx0cyBpbiB0aGlzIGNyYXNoDQo+ID4gaW4sDQo+ID4gYXJtX3NtbXVfZG9tYWluX2ZpbmFsaXNl X3MxKCkgLS0+YXJtX3NtbXVfYWxsb2NfY2RfdGFibGVzKCktLT4NCj4gPiBhcm1fc21tdV9hbGxv Y19jZF9sZWFmX3RhYmxlKCkgYXMgbnVtX2xlYWZfZW50cmllcyBpcyB6ZXJvLg0KPiA+DQo+ID4g V2l0aCB0aGUgYmVsb3cgZml4LCBpdCB3b3JrcyBvbiBEMDUgbm93LA0KPiA+DQo+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvaW9tbXUvYXJtLXNtbXUtdjMuYyBiL2RyaXZlcnMvaW9tbXUvYXJtLXNt bXUtdjMuYw0KPiA+IGluZGV4IDhhZDkwZTIuLjUxZjU4MjEgMTAwNjQ0DQo+ID4gLS0tIGEvZHJp dmVycy9pb21tdS9hcm0tc21tdS12My5jDQo+ID4gKysrIGIvZHJpdmVycy9pb21tdS9hcm0tc21t dS12My5jDQo+ID4gQEAgLTI0MzMsNyArMjQzMywxMCBAQCBzdGF0aWMgaW50IGFybV9zbW11X2Rv bWFpbl9maW5hbGlzZShzdHJ1Y3QNCj4gaW9tbXVfZG9tYWluICpkb21haW4sDQo+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgZG9tYWluLT5taW5fcGFzaWQgPSAxOw0KPiA+ICAgICAgICAgICAg ICAgICAgICAgICAgIGRvbWFpbi0+bWF4X3Bhc2lkID0gbWFzdGVyLT5udW1fc3NpZHMgLSAxOw0K PiA+ICAgICAgICAgICAgICAgICAgICAgICAgIHNtbXVfZG9tYWluLT5zMV9jZmcubnVtX2NvbnRl eHRzID0gbWFzdGVyLT5udW1fc3NpZHM7DQo+ID4gKyAgICAgICAgICAgICAgIH0gZWxzZSB7DQo+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgc21tdV9kb21haW4tPnMxX2NmZy5udW1fY29udGV4 dHMgPSAxOw0KPiA+ICAgICAgICAgICAgICAgICB9DQo+ID4gKw0KPiA+ICAgICAgICAgICAgICAg ICBzbW11X2RvbWFpbi0+czFfY2ZnLmNhbl9zdGFsbCA9IG1hc3Rlci0+c3RlLmNhbl9zdGFsbDsN Cj4gPiAgICAgICAgICAgICAgICAgYnJlYWs7DQo+ID4gICAgICAgICBjYXNlIEFSTV9TTU1VX0RP TUFJTl9ORVNURUQ6DQo+ID4NCj4gPg0KPiA+IEkgYW0gbm90IHN1cmUgdGhpcyBpcyByaWdodCBw bGFjZSBkbyB0aGlzLiBQbGVhc2UgdGFrZSBhIGxvb2suDQo+IA0KPiBUaGFua3MgZm9yIHRlc3Rp bmcgdGhlIHNlcmllcyBhbmQgcmVwb3J0aW5nIHRoZSBidWcuIEkgYWRkZWQgdGhlDQo+IGZvbGxv d2luZyBwYXRjaCB0byBicmFuY2ggc3ZtL2N1cnJlbnQsIGRvZXMgaXQgd29yayBmb3IgeW91Pw0K DQpZZXMsIGl0IGRvZXMuDQoNClRoYW5rcywNClNoYW1lZXINCiANCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvaW9tbXUvYXJtLXNtbXUtdjMuYyBiL2RyaXZlcnMvaW9tbXUvYXJtLXNtbXUtdjMuYw0K PiBpbmRleCA0MmM4Mzc4NjI0ZWQuLmVkZGE0NjZhZGM4MSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVy cy9pb21tdS9hcm0tc21tdS12My5jDQo+ICsrKyBiL2RyaXZlcnMvaW9tbXUvYXJtLXNtbXUtdjMu Yw0KPiBAQCAtMzE2OSw5ICszMTY5LDcgQEAgc3RhdGljIGludCBhcm1fc21tdV9hZGRfZGV2aWNl KHN0cnVjdCBkZXZpY2UgKmRldikNCj4gICAgICAgICAgICAgICAgIH0NCj4gICAgICAgICB9DQo+ IA0KPiAtICAgICAgIGlmIChzbW11LT5zc2lkX2JpdHMpDQo+IC0gICAgICAgICAgICAgICBtYXN0 ZXItPm51bV9zc2lkcyA9IDEgPDwgbWluKHNtbXUtPnNzaWRfYml0cywNCj4gLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZndzcGVjLT5udW1fcGFzaWRfYml0cyk7 DQo+ICsgICAgICAgbWFzdGVyLT5udW1fc3NpZHMgPSAxIDw8IG1pbihzbW11LT5zc2lkX2JpdHMs IGZ3c3BlYy0NCj4gPm51bV9wYXNpZF9iaXRzKTsNCj4gDQo+ICAgICAgICAgaWYgKGZ3c3BlYy0+ Y2FuX3N0YWxsICYmIHNtbXUtPmZlYXR1cmVzICYgQVJNX1NNTVVfRkVBVF9TVEFMTFMpIHsNCj4g ICAgICAgICAgICAgICAgIG1hc3Rlci0+Y2FuX2ZhdWx0ID0gdHJ1ZTsNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Shameerali Kolothum Thodi To: Jean-Philippe Brucker CC: "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "devicetree@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Mark Rutland , "xieyisheng (A)" , Gabriele Paoloni , Catalin Marinas , Will Deacon , "okaya@codeaurora.org" , "yi.l.liu@intel.com" , "Lorenzo Pieralisi" , "ashok.raj@intel.com" , "tn@semihalf.com" , "joro@8bytes.org" , "rfranz@cavium.com" , "lenb@kernel.org" , "jacob.jun.pan@linux.intel.com" , "alex.williamson@redhat.com" , "robh+dt@kernel.org" , "Leizhen (ThunderTown)" , "bhelgaas@google.com" , "dwmw2@infradead.org" , "liubo (CU)" , "rjw@rjwysocki.net" , "robdclark@gmail.com" , "hanjun.guo@linaro.org" , Sudeep Holla , Robin Murphy , "nwatters@codeaurora.org" , Linuxarm Subject: RE: [RFCv2 PATCH 14/36] iommu/arm-smmu-v3: Add support for Substream IDs Date: Thu, 2 Nov 2017 17:02:27 +0000 Message-ID: <5FC3163CFD30C246ABAA99954A238FA838454A9B@FRAEML521-MBX.china.huawei.com> References: <20171006133203.22803-1-jean-philippe.brucker@arm.com> <20171006133203.22803-15-jean-philippe.brucker@arm.com> <5FC3163CFD30C246ABAA99954A238FA838454887@FRAEML521-MBX.china.huawei.com> <20171102155152.GA11899@e106794-lin.localdomain> In-Reply-To: <20171102155152.GA11899@e106794-lin.localdomain> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-acpi-owner@vger.kernel.org List-ID: DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmVhbi1QaGlsaXBwZSBC cnVja2VyIFttYWlsdG86SmVhbi1QaGlsaXBwZS5CcnVja2VyQGFybS5jb21dDQo+IFNlbnQ6IFRo dXJzZGF5LCBOb3ZlbWJlciAwMiwgMjAxNyAzOjUyIFBNDQo+IFRvOiBTaGFtZWVyYWxpIEtvbG90 aHVtIFRob2RpIDxzaGFtZWVyYWxpLmtvbG90aHVtLnRob2RpQGh1YXdlaS5jb20+DQo+IENjOiBs aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LXBjaUB2Z2VyLmtlcm5l bC5vcmc7IGxpbnV4LQ0KPiBhY3BpQHZnZXIua2VybmVsLm9yZzsgZGV2aWNldHJlZUB2Z2VyLmtl cm5lbC5vcmc7IGlvbW11QGxpc3RzLmxpbnV4LQ0KPiBmb3VuZGF0aW9uLm9yZzsgTWFyayBSdXRs YW5kIDxNYXJrLlJ1dGxhbmRAYXJtLmNvbT47IHhpZXlpc2hlbmcgKEEpDQo+IDx4aWV5aXNoZW5n MUBodWF3ZWkuY29tPjsgR2FicmllbGUgUGFvbG9uaQ0KPiA8Z2FicmllbGUucGFvbG9uaUBodWF3 ZWkuY29tPjsgQ2F0YWxpbiBNYXJpbmFzDQo+IDxDYXRhbGluLk1hcmluYXNAYXJtLmNvbT47IFdp bGwgRGVhY29uIDxXaWxsLkRlYWNvbkBhcm0uY29tPjsNCj4gb2theWFAY29kZWF1cm9yYS5vcmc7 IHlpLmwubGl1QGludGVsLmNvbTsgTG9yZW56byBQaWVyYWxpc2kNCj4gPExvcmVuem8uUGllcmFs aXNpQGFybS5jb20+OyBhc2hvay5yYWpAaW50ZWwuY29tOyB0bkBzZW1paGFsZi5jb207DQo+IGpv cm9AOGJ5dGVzLm9yZzsgcmZyYW56QGNhdml1bS5jb207IGxlbmJAa2VybmVsLm9yZzsNCj4gamFj b2IuanVuLnBhbkBsaW51eC5pbnRlbC5jb207IGFsZXgud2lsbGlhbXNvbkByZWRoYXQuY29tOw0K PiByb2JoK2R0QGtlcm5lbC5vcmc7IExlaXpoZW4gKFRodW5kZXJUb3duKSA8dGh1bmRlci5sZWl6 aGVuQGh1YXdlaS5jb20+Ow0KPiBiaGVsZ2Fhc0Bnb29nbGUuY29tOyBkd213MkBpbmZyYWRlYWQu b3JnOyBsaXVibyAoQ1UpDQo+IDxsaXVibzk1QGh1YXdlaS5jb20+OyByandAcmp3eXNvY2tpLm5l dDsgcm9iZGNsYXJrQGdtYWlsLmNvbTsNCj4gaGFuanVuLmd1b0BsaW5hcm8ub3JnOyBTdWRlZXAg SG9sbGEgPFN1ZGVlcC5Ib2xsYUBhcm0uY29tPjsgUm9iaW4NCj4gTXVycGh5IDxSb2Jpbi5NdXJw aHlAYXJtLmNvbT47IG53YXR0ZXJzQGNvZGVhdXJvcmEub3JnOyBMaW51eGFybQ0KPiA8bGludXhh cm1AaHVhd2VpLmNvbT4NCj4gU3ViamVjdDogUmU6IFtSRkN2MiBQQVRDSCAxNC8zNl0gaW9tbXUv YXJtLXNtbXUtdjM6IEFkZCBzdXBwb3J0IGZvcg0KPiBTdWJzdHJlYW0gSURzDQo+IA0KPiBIaSBT aGFtZWVyLA0KPiANCj4gT24gVGh1LCBOb3YgMDIsIDIwMTcgYXQgMTI6NDk6MzJQTSArMDAwMCwg U2hhbWVlcmFsaSBLb2xvdGh1bSBUaG9kaSB3cm90ZToNCj4gPiBXZSBoYWQgYSBnbyB3aXRoIHRo aXMgc2VyaWVzIG9uIEhpU0lsaWNvbiBEMDUgcGxhdGZvcm0gd2hpY2ggZG9lc24ndCBoYXZlDQo+ ID4gc3VwcG9ydCBmb3Igc3NpZHMvQVRTL1BSSSwgdG8gbWFrZSBzdXJlIGl0IGdlbmVyYWxseSB3 b3Jrcy4NCj4gPg0KPiA+IEJ1dCBvYnNlcnZlZCB0aGUgYmVsb3cgY3Jhc2ggb24gYm9vdCwNCj4g Pg0KPiA+IFsgICAxNi4wMDkwODRdIFdBUk5JTkc6IENQVTogNTkgUElEOiAzOTEgYXQgbW0vcGFn ZV9hbGxvYy5jOjM4ODMNCj4gX19hbGxvY19wYWdlc19ub2RlbWFzaysweDE5Yy8weGM0OA0KPiA+ IFsgICAxNi4wMjY3OTddIE1vZHVsZXMgbGlua2VkIGluOg0KPiA+IFsgICAxNi4wMzI5NDRdIENQ VTogNTkgUElEOiAzOTEgQ29tbToga3dvcmtlci81OToxIE5vdCB0YWludGVkIDQuMTQuMC1yYzEt DQo+IDE1OTUzOS1nZTQyYWNhMyAjMjM2DQo+ID4gWy4uLl0NCj4gPiBbICAgMTYuMDY4MjA2XSBX b3JrcXVldWU6IGV2ZW50cyBkZWZlcnJlZF9wcm9iZV93b3JrX2Z1bmMNCj4gPiBbICAgMTYuMDc4 NTU3XSB0YXNrOiBmZmZmODAxN2QzOGEwMDAwIHRhc2suc3RhY2s6IGZmZmYwMDAwMGIxOTgwMDAN Cj4gPiBbICAgMTYuMDkwNDg2XSBQQyBpcyBhdCBfX2FsbG9jX3BhZ2VzX25vZGVtYXNrKzB4MTlj LzB4YzQ4DQo+ID4gWyAgIDE2LjEwMTAxM10gTFIgaXMgYXQgX19hbGxvY19wYWdlc19ub2RlbWFz aysweGUwLzB4YzQ4DQo+ID4gWyAgIDE2LjQ2OTIyMF0gWzxmZmZmMDAwMDA4MTg2Yjk0Pl0gX19h bGxvY19wYWdlc19ub2RlbWFzaysweDE5Yy8weGM0OA0KPiA+IFsgICAxNi40ODE4NTRdIFs8ZmZm ZjAwMDAwODFkNjViMD5dIGFsbG9jX3BhZ2VzX2N1cnJlbnQrMHg4MC8weGNjDQo+ID4gWyAgIDE2 LjQ5MzYwN10gWzxmZmZmMDAwMDA4MTgyYmU4Pl0gX19nZXRfZnJlZV9wYWdlcysweGMvMHgzOA0K PiA+IFsgICAxNi41MDQ2NjFdIFs8ZmZmZjAwMDAwODNjNGQ1OD5dIHN3aW90bGJfYWxsb2NfY29o ZXJlbnQrMHg2NC8weDE5MA0KPiA+IFsgICAxNi41MTcxMTddIFs8ZmZmZjAwMDAwODA5ODI0Yz5d IF9fZG1hX2FsbG9jKzB4MTEwLzB4MjA0DQo+ID4gWyAgIDE2LjUyNzgyMF0gWzxmZmZmMDAwMDA4 NThlODUwPl0gZG1hbV9hbGxvY19jb2hlcmVudCsweDg4LzB4ZjANCj4gPiBbICAgMTYuNTM5NTc1 XSBbPGZmZmYwMDAwMDg1Njg4ODQ+XQ0KPiBhcm1fc21tdV9kb21haW5fZmluYWxpc2VfczErMHg2 MC8weDI0OA0KPiA+IFsgICAxNi41NTI5MDldIFs8ZmZmZjAwMDAwODU2YzEwND5dIGFybV9zbW11 X2F0dGFjaF9kZXYrMHgyNjQvMHgzMDANCj4gPiBbICAgMTYuNTY1MDEzXSBbPGZmZmYwMDAwMDg1 NWQ0MGM+XSBfX2lvbW11X2F0dGFjaF9kZXZpY2UrMHg0OC8weDVjDQo+ID4gWyAgIDE2LjU3NzEx N10gWzxmZmZmMDAwMDA4NTVlNjk4Pl0gaW9tbXVfZ3JvdXBfYWRkX2RldmljZSsweDE0NC8weDNh NA0KPiA+IFsgICAxNi41ODk3NDZdIFs8ZmZmZjAwMDAwODU1ZWQxOD5dIGlvbW11X2dyb3VwX2dl dF9mb3JfZGV2KzB4NzAvMHhmOA0KPiA+IFsgICAxNi42MDIyMDFdIFs8ZmZmZjAwMDAwODU2YTMx ND5dIGFybV9zbW11X2FkZF9kZXZpY2UrMHgxYTQvMHg0MTgNCj4gPiBbICAgMTYuNjE0MzA4XSBb PGZmZmYwMDAwMDg0OWRmY2M+XSBpb3J0X2lvbW11X2NvbmZpZ3VyZSsweGYwLzB4MTZjDQo+ID4g WyAgIDE2LjYyNjQxNl0gWzxmZmZmMDAwMDA4NDY4YzUwPl0gYWNwaV9kbWFfY29uZmlndXJlKzB4 MzAvMHg3MA0KPiA+IFsgICAxNi42Mzc5OTRdIFs8ZmZmZjAwMDAwODU4ZjAwYz5dIGRtYV9jb25m aWd1cmUrMHhhOC8weGQ0DQo+ID4gWyAgIDE2LjY0ODY5NV0gWzxmZmZmMDAwMDA4NTc3MDZjPl0g ZHJpdmVyX3Byb2JlX2RldmljZSsweDFhNC8weDJkYw0KPiA+IFsgICAxNi42NzMwODFdIFs8ZmZm ZjAwMDAwODU3NTJjOD5dIGJ1c19mb3JfZWFjaF9kcnYrMHg1NC8weDk0DQo+ID4gWyAgIDE2LjY4 NDMwN10gWzxmZmZmMDAwMDA4NTc2ZGIwPl0gX19kZXZpY2VfYXR0YWNoKzB4YzQvMHgxMmMNCj4g PiBbICAgMTYuNjk1NTMzXSBbPGZmZmYwMDAwMDg1NzczNTA+XSBkZXZpY2VfaW5pdGlhbF9wcm9i ZSsweDEwLzB4MTgNCj4gPiBbICAgMTYuNzA3NDYyXSBbPGZmZmYwMDAwMDg1NzYyYjQ+XSBidXNf cHJvYmVfZGV2aWNlKzB4OTAvMHg5OA0KPiA+DQo+ID4gQWZ0ZXIgYSBiaXQgb2YgZGVidWcgaXQg bG9va3MgbGlrZSBvbiBwbGF0Zm9ybXMgd2hlcmUgc3NpZCBpcyBub3Qgc3VwcG9ydGVkLA0KPiA+ IHMxX2NmZy5udW1fY29udGV4dHMgaXMgc2V0IHRvIHplcm8gYW5kIGl0IGV2ZW50dWFsbHkgcmVz dWx0cyBpbiB0aGlzIGNyYXNoDQo+ID4gaW4sDQo+ID4gYXJtX3NtbXVfZG9tYWluX2ZpbmFsaXNl X3MxKCkgLS0+YXJtX3NtbXVfYWxsb2NfY2RfdGFibGVzKCktLT4NCj4gPiBhcm1fc21tdV9hbGxv Y19jZF9sZWFmX3RhYmxlKCkgYXMgbnVtX2xlYWZfZW50cmllcyBpcyB6ZXJvLg0KPiA+DQo+ID4g V2l0aCB0aGUgYmVsb3cgZml4LCBpdCB3b3JrcyBvbiBEMDUgbm93LA0KPiA+DQo+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvaW9tbXUvYXJtLXNtbXUtdjMuYyBiL2RyaXZlcnMvaW9tbXUvYXJtLXNt bXUtdjMuYw0KPiA+IGluZGV4IDhhZDkwZTIuLjUxZjU4MjEgMTAwNjQ0DQo+ID4gLS0tIGEvZHJp dmVycy9pb21tdS9hcm0tc21tdS12My5jDQo+ID4gKysrIGIvZHJpdmVycy9pb21tdS9hcm0tc21t dS12My5jDQo+ID4gQEAgLTI0MzMsNyArMjQzMywxMCBAQCBzdGF0aWMgaW50IGFybV9zbW11X2Rv bWFpbl9maW5hbGlzZShzdHJ1Y3QNCj4gaW9tbXVfZG9tYWluICpkb21haW4sDQo+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgZG9tYWluLT5taW5fcGFzaWQgPSAxOw0KPiA+ICAgICAgICAgICAg ICAgICAgICAgICAgIGRvbWFpbi0+bWF4X3Bhc2lkID0gbWFzdGVyLT5udW1fc3NpZHMgLSAxOw0K PiA+ICAgICAgICAgICAgICAgICAgICAgICAgIHNtbXVfZG9tYWluLT5zMV9jZmcubnVtX2NvbnRl eHRzID0gbWFzdGVyLT5udW1fc3NpZHM7DQo+ID4gKyAgICAgICAgICAgICAgIH0gZWxzZSB7DQo+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgc21tdV9kb21haW4tPnMxX2NmZy5udW1fY29udGV4 dHMgPSAxOw0KPiA+ICAgICAgICAgICAgICAgICB9DQo+ID4gKw0KPiA+ICAgICAgICAgICAgICAg ICBzbW11X2RvbWFpbi0+czFfY2ZnLmNhbl9zdGFsbCA9IG1hc3Rlci0+c3RlLmNhbl9zdGFsbDsN Cj4gPiAgICAgICAgICAgICAgICAgYnJlYWs7DQo+ID4gICAgICAgICBjYXNlIEFSTV9TTU1VX0RP TUFJTl9ORVNURUQ6DQo+ID4NCj4gPg0KPiA+IEkgYW0gbm90IHN1cmUgdGhpcyBpcyByaWdodCBw bGFjZSBkbyB0aGlzLiBQbGVhc2UgdGFrZSBhIGxvb2suDQo+IA0KPiBUaGFua3MgZm9yIHRlc3Rp bmcgdGhlIHNlcmllcyBhbmQgcmVwb3J0aW5nIHRoZSBidWcuIEkgYWRkZWQgdGhlDQo+IGZvbGxv d2luZyBwYXRjaCB0byBicmFuY2ggc3ZtL2N1cnJlbnQsIGRvZXMgaXQgd29yayBmb3IgeW91Pw0K DQpZZXMsIGl0IGRvZXMuDQoNClRoYW5rcywNClNoYW1lZXINCiANCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvaW9tbXUvYXJtLXNtbXUtdjMuYyBiL2RyaXZlcnMvaW9tbXUvYXJtLXNtbXUtdjMuYw0K PiBpbmRleCA0MmM4Mzc4NjI0ZWQuLmVkZGE0NjZhZGM4MSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVy cy9pb21tdS9hcm0tc21tdS12My5jDQo+ICsrKyBiL2RyaXZlcnMvaW9tbXUvYXJtLXNtbXUtdjMu Yw0KPiBAQCAtMzE2OSw5ICszMTY5LDcgQEAgc3RhdGljIGludCBhcm1fc21tdV9hZGRfZGV2aWNl KHN0cnVjdCBkZXZpY2UgKmRldikNCj4gICAgICAgICAgICAgICAgIH0NCj4gICAgICAgICB9DQo+ IA0KPiAtICAgICAgIGlmIChzbW11LT5zc2lkX2JpdHMpDQo+IC0gICAgICAgICAgICAgICBtYXN0 ZXItPm51bV9zc2lkcyA9IDEgPDwgbWluKHNtbXUtPnNzaWRfYml0cywNCj4gLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZndzcGVjLT5udW1fcGFzaWRfYml0cyk7 DQo+ICsgICAgICAgbWFzdGVyLT5udW1fc3NpZHMgPSAxIDw8IG1pbihzbW11LT5zc2lkX2JpdHMs IGZ3c3BlYy0NCj4gPm51bV9wYXNpZF9iaXRzKTsNCj4gDQo+ICAgICAgICAgaWYgKGZ3c3BlYy0+ Y2FuX3N0YWxsICYmIHNtbXUtPmZlYXR1cmVzICYgQVJNX1NNTVVfRkVBVF9TVEFMTFMpIHsNCj4g ICAgICAgICAgICAgICAgIG1hc3Rlci0+Y2FuX2ZhdWx0ID0gdHJ1ZTsNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: shameerali.kolothum.thodi@huawei.com (Shameerali Kolothum Thodi) Date: Thu, 2 Nov 2017 17:02:27 +0000 Subject: [RFCv2 PATCH 14/36] iommu/arm-smmu-v3: Add support for Substream IDs In-Reply-To: <20171102155152.GA11899@e106794-lin.localdomain> References: <20171006133203.22803-1-jean-philippe.brucker@arm.com> <20171006133203.22803-15-jean-philippe.brucker@arm.com> <5FC3163CFD30C246ABAA99954A238FA838454887@FRAEML521-MBX.china.huawei.com> <20171102155152.GA11899@e106794-lin.localdomain> Message-ID: <5FC3163CFD30C246ABAA99954A238FA838454A9B@FRAEML521-MBX.china.huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > -----Original Message----- > From: Jean-Philippe Brucker [mailto:Jean-Philippe.Brucker at arm.com] > Sent: Thursday, November 02, 2017 3:52 PM > To: Shameerali Kolothum Thodi > Cc: linux-arm-kernel at lists.infradead.org; linux-pci at vger.kernel.org; linux- > acpi at vger.kernel.org; devicetree at vger.kernel.org; iommu at lists.linux- > foundation.org; Mark Rutland ; xieyisheng (A) > ; Gabriele Paoloni > ; Catalin Marinas > ; Will Deacon ; > okaya at codeaurora.org; yi.l.liu at intel.com; Lorenzo Pieralisi > ; ashok.raj at intel.com; tn at semihalf.com; > joro at 8bytes.org; rfranz at cavium.com; lenb at kernel.org; > jacob.jun.pan at linux.intel.com; alex.williamson at redhat.com; > robh+dt at kernel.org; Leizhen (ThunderTown) ; > bhelgaas at google.com; dwmw2 at infradead.org; liubo (CU) > ; rjw at rjwysocki.net; robdclark at gmail.com; > hanjun.guo at linaro.org; Sudeep Holla ; Robin > Murphy ; nwatters at codeaurora.org; Linuxarm > > Subject: Re: [RFCv2 PATCH 14/36] iommu/arm-smmu-v3: Add support for > Substream IDs > > Hi Shameer, > > On Thu, Nov 02, 2017 at 12:49:32PM +0000, Shameerali Kolothum Thodi wrote: > > We had a go with this series on HiSIlicon D05 platform which doesn't have > > support for ssids/ATS/PRI, to make sure it generally works. > > > > But observed the below crash on boot, > > > > [ 16.009084] WARNING: CPU: 59 PID: 391 at mm/page_alloc.c:3883 > __alloc_pages_nodemask+0x19c/0xc48 > > [ 16.026797] Modules linked in: > > [ 16.032944] CPU: 59 PID: 391 Comm: kworker/59:1 Not tainted 4.14.0-rc1- > 159539-ge42aca3 #236 > > [...] > > [ 16.068206] Workqueue: events deferred_probe_work_func > > [ 16.078557] task: ffff8017d38a0000 task.stack: ffff00000b198000 > > [ 16.090486] PC is at __alloc_pages_nodemask+0x19c/0xc48 > > [ 16.101013] LR is at __alloc_pages_nodemask+0xe0/0xc48 > > [ 16.469220] [] __alloc_pages_nodemask+0x19c/0xc48 > > [ 16.481854] [] alloc_pages_current+0x80/0xcc > > [ 16.493607] [] __get_free_pages+0xc/0x38 > > [ 16.504661] [] swiotlb_alloc_coherent+0x64/0x190 > > [ 16.517117] [] __dma_alloc+0x110/0x204 > > [ 16.527820] [] dmam_alloc_coherent+0x88/0xf0 > > [ 16.539575] [] > arm_smmu_domain_finalise_s1+0x60/0x248 > > [ 16.552909] [] arm_smmu_attach_dev+0x264/0x300 > > [ 16.565013] [] __iommu_attach_device+0x48/0x5c > > [ 16.577117] [] iommu_group_add_device+0x144/0x3a4 > > [ 16.589746] [] iommu_group_get_for_dev+0x70/0xf8 > > [ 16.602201] [] arm_smmu_add_device+0x1a4/0x418 > > [ 16.614308] [] iort_iommu_configure+0xf0/0x16c > > [ 16.626416] [] acpi_dma_configure+0x30/0x70 > > [ 16.637994] [] dma_configure+0xa8/0xd4 > > [ 16.648695] [] driver_probe_device+0x1a4/0x2dc > > [ 16.673081] [] bus_for_each_drv+0x54/0x94 > > [ 16.684307] [] __device_attach+0xc4/0x12c > > [ 16.695533] [] device_initial_probe+0x10/0x18 > > [ 16.707462] [] bus_probe_device+0x90/0x98 > > > > After a bit of debug it looks like on platforms where ssid is not supported, > > s1_cfg.num_contexts is set to zero and it eventually results in this crash > > in, > > arm_smmu_domain_finalise_s1() -->arm_smmu_alloc_cd_tables()--> > > arm_smmu_alloc_cd_leaf_table() as num_leaf_entries is zero. > > > > With the below fix, it works on D05 now, > > > > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > > index 8ad90e2..51f5821 100644 > > --- a/drivers/iommu/arm-smmu-v3.c > > +++ b/drivers/iommu/arm-smmu-v3.c > > @@ -2433,7 +2433,10 @@ static int arm_smmu_domain_finalise(struct > iommu_domain *domain, > > domain->min_pasid = 1; > > domain->max_pasid = master->num_ssids - 1; > > smmu_domain->s1_cfg.num_contexts = master->num_ssids; > > + } else { > > + smmu_domain->s1_cfg.num_contexts = 1; > > } > > + > > smmu_domain->s1_cfg.can_stall = master->ste.can_stall; > > break; > > case ARM_SMMU_DOMAIN_NESTED: > > > > > > I am not sure this is right place do this. Please take a look. > > Thanks for testing the series and reporting the bug. I added the > following patch to branch svm/current, does it work for you? Yes, it does. Thanks, Shameer > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > index 42c8378624ed..edda466adc81 100644 > --- a/drivers/iommu/arm-smmu-v3.c > +++ b/drivers/iommu/arm-smmu-v3.c > @@ -3169,9 +3169,7 @@ static int arm_smmu_add_device(struct device *dev) > } > } > > - if (smmu->ssid_bits) > - master->num_ssids = 1 << min(smmu->ssid_bits, > - fwspec->num_pasid_bits); > + master->num_ssids = 1 << min(smmu->ssid_bits, fwspec- > >num_pasid_bits); > > if (fwspec->can_stall && smmu->features & ARM_SMMU_FEAT_STALLS) { > master->can_fault = true;