From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753228AbdLUPjx (ORCPT ); Thu, 21 Dec 2017 10:39:53 -0500 Received: from mga03.intel.com ([134.134.136.65]:21651 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752838AbdLUPjs (ORCPT ); Thu, 21 Dec 2017 10:39:48 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,436,1508828400"; d="scan'208";a="15542858" From: "Shaikh, Azhar" To: Javier Martinez Canillas , Jason Gunthorpe CC: "linux-kernel@vger.kernel.org" , James Ettle , Hans de Goede , Arnd Bergmann , Jarkko Sakkinen , "Peter Huewe" , Greg Kroah-Hartman , "linux-integrity@vger.kernel.org" Subject: RE: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O memory region Thread-Topic: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O memory region Thread-Index: AQHTeb9bmq32R+iVBkysqRaAWn4zXKNNGq0A//9/aOCAAayJAP//pAEg Date: Thu, 21 Dec 2017 15:39:44 +0000 Message-ID: <5FFFAD06ADE1CA4381B3F0F7C6AF5828988F88@ORSMSX109.amr.corp.intel.com> References: <20171220113538.16099-1-javierm@redhat.com> <20171220113538.16099-2-javierm@redhat.com> <20171220180855.GB22908@ziepe.ca> <20171220185458.GE22908@ziepe.ca> <5FFFAD06ADE1CA4381B3F0F7C6AF5828988917@ORSMSX109.amr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzUwODA5ZDItNjU3Yy00NDc1LWI0YjUtOTQ0YTBjYmViOGNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiI1NXJuRlowQVwvaUtcL3F6YmVWMWZTNFQzdzhQNkRnc1lrUkVkTWlLVFVreXByOUdlNEVoTU1GWEJSQnlQT1wvUkRSIn0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id vBLFdwls026372 HI Javier, >-----Original Message----- >From: linux-integrity-owner@vger.kernel.org [mailto:linux-integrity- >owner@vger.kernel.org] On Behalf Of Javier Martinez Canillas >Sent: Thursday, December 21, 2017 4:49 AM >To: Shaikh, Azhar ; Jason Gunthorpe > >Cc: linux-kernel@vger.kernel.org; James Ettle ; Hans de >Goede ; Arnd Bergmann ; Jarkko >Sakkinen ; Peter Huewe >; Greg Kroah-Hartman >; linux-integrity@vger.kernel.org >Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O >memory region > >Hello Azhar, > >On 12/20/2017 08:15 PM, Shaikh, Azhar wrote: >> >> >>> -----Original Message----- >>> From: Jason Gunthorpe [mailto:jgg@ziepe.ca] >>> Sent: Wednesday, December 20, 2017 10:55 AM >>> To: Javier Martinez Canillas >>> Cc: linux-kernel@vger.kernel.org; James Ettle ; >>> Hans de Goede ; Shaikh, Azhar >>> ; Arnd Bergmann ; Jarkko >>> Sakkinen ; Peter Huewe >>> ; Greg Kroah-Hartman >; >>> linux- integrity@vger.kernel.org >>> Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already >>> unmapped I/O memory region >>> >>> On Wed, Dec 20, 2017 at 07:21:31PM +0100, Javier Martinez Canillas wrote: >>> >>>>> The below draft fixes everything except #1. That needs a more >>>>> thoughtful idea.. >>>>> >>>> >>>> I'll just drop this patch from the series and you can fix all the >>>> issues in the error / driver removal paths. It's not a dependency >>>> anyways, I included it just because noticed the issue while reading the >code. >>> >>> Azhar, this means it becomes your problem :) >>> >> >> Sure, I will fix this. >> Javier you can drop this patch. >> > >On a second though, we should just merge $SUBJECT since is an obvious fix >for one of the issues. Then you could fix the remaining bugs in error and >driver removal paths. I think you are asking to keep this patch as a part of this series, itself and not upload separately. Is this correct? Please correct me if I am wrong. > >>> Since the patches Jarkko has queued from you introduce oops's you >>> need to fix them.. >>> >>> Jason >> >> Regards, >> Azhar Shaikh >> > >Best regards, >-- >Javier Martinez Canillas >Software Engineer - Desktop Hardware Enablement Red Hat Regards, Azhar Shaikh