From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 496E6C433F5 for ; Fri, 4 Mar 2022 19:38:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E9A4113420; Fri, 4 Mar 2022 19:38:42 +0000 (UTC) Received: from aposti.net (aposti.net [89.234.176.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id B9FB5113420 for ; Fri, 4 Mar 2022 19:38:41 +0000 (UTC) Date: Fri, 04 Mar 2022 19:38:29 +0000 From: Paul Cercueil Subject: Re: [PATCH] drm/bridge_connector: enable HPD by default if supported To: Nikita Yushchenko Message-Id: <5WJ88R.LXNASHJRBDGL1@crapouillou.net> In-Reply-To: <20211225063151.2110878-1-nikita.yoush@cogentembedded.com> References: <20211225063151.2110878-1-nikita.yoush@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Pinchart , Thomas Zimmermann , David Airlie , linux-kernel@vger.kernel.org, Kieran Bingham , Jacopo Mondi , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Nikita, Le sam., d=E9c. 25 2021 at 09:31:51 +0300, Nikita Yushchenko=20 a =E9crit : > Hotplug events reported by bridge drivers over drm_bridge_hpd_notify() > get ignored unless somebody calls drm_bridge_hpd_enable(). When the > connector for the bridge is bridge_connector, such a call is done from > drm_bridge_connector_enable_hpd(). >=20 > However drm_bridge_connector_enable_hpd() is never called on init=20 > paths, > documentation suggests that it is intended for suspend/resume paths. >=20 > In result, once encoders are switched to bridge_connector, > bridge-detected HPD stops working. >=20 > This patch adds a call to that API on init path. >=20 > This fixes HDMI HPD with rcar-du + adv7513 case when adv7513 reports=20 > HPD > events via interrupts. >=20 > Fixes: c24110a8fd09 ("drm: rcar-du: Use drm_bridge_connector_init()=20 > helper") > Signed-off-by: Nikita Yushchenko Merged to drm-misc-next. Thanks! Cheers, -Paul > --- > drivers/gpu/drm/drm_bridge_connector.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/drm_bridge_connector.c=20 > b/drivers/gpu/drm/drm_bridge_connector.c > index 791379816837..4f20137ef21d 100644 > --- a/drivers/gpu/drm/drm_bridge_connector.c > +++ b/drivers/gpu/drm/drm_bridge_connector.c > @@ -369,8 +369,10 @@ struct drm_connector=20 > *drm_bridge_connector_init(struct drm_device *drm, > connector_type, ddc); > drm_connector_helper_add(connector,=20 > &drm_bridge_connector_helper_funcs); >=20 > - if (bridge_connector->bridge_hpd) > + if (bridge_connector->bridge_hpd) { > connector->polled =3D DRM_CONNECTOR_POLL_HPD; > + drm_bridge_connector_enable_hpd(connector); > + } > else if (bridge_connector->bridge_detect) > connector->polled =3D DRM_CONNECTOR_POLL_CONNECT > | DRM_CONNECTOR_POLL_DISCONNECT; > -- > 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD5EBC4332F for ; Fri, 4 Mar 2022 20:01:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230082AbiCDUBz convert rfc822-to-8bit (ORCPT ); Fri, 4 Mar 2022 15:01:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230035AbiCDUBs (ORCPT ); Fri, 4 Mar 2022 15:01:48 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F9F5972F2 for ; Fri, 4 Mar 2022 11:56:02 -0800 (PST) Date: Fri, 04 Mar 2022 19:38:29 +0000 From: Paul Cercueil Subject: Re: [PATCH] drm/bridge_connector: enable HPD by default if supported To: Nikita Yushchenko Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Kieran Bingham , Laurent Pinchart , Jacopo Mondi , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-Id: <5WJ88R.LXNASHJRBDGL1@crapouillou.net> In-Reply-To: <20211225063151.2110878-1-nikita.yoush@cogentembedded.com> References: <20211225063151.2110878-1-nikita.yoush@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nikita, Le sam., déc. 25 2021 at 09:31:51 +0300, Nikita Yushchenko a écrit : > Hotplug events reported by bridge drivers over drm_bridge_hpd_notify() > get ignored unless somebody calls drm_bridge_hpd_enable(). When the > connector for the bridge is bridge_connector, such a call is done from > drm_bridge_connector_enable_hpd(). > > However drm_bridge_connector_enable_hpd() is never called on init > paths, > documentation suggests that it is intended for suspend/resume paths. > > In result, once encoders are switched to bridge_connector, > bridge-detected HPD stops working. > > This patch adds a call to that API on init path. > > This fixes HDMI HPD with rcar-du + adv7513 case when adv7513 reports > HPD > events via interrupts. > > Fixes: c24110a8fd09 ("drm: rcar-du: Use drm_bridge_connector_init() > helper") > Signed-off-by: Nikita Yushchenko Merged to drm-misc-next. Thanks! Cheers, -Paul > --- > drivers/gpu/drm/drm_bridge_connector.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_bridge_connector.c > b/drivers/gpu/drm/drm_bridge_connector.c > index 791379816837..4f20137ef21d 100644 > --- a/drivers/gpu/drm/drm_bridge_connector.c > +++ b/drivers/gpu/drm/drm_bridge_connector.c > @@ -369,8 +369,10 @@ struct drm_connector > *drm_bridge_connector_init(struct drm_device *drm, > connector_type, ddc); > drm_connector_helper_add(connector, > &drm_bridge_connector_helper_funcs); > > - if (bridge_connector->bridge_hpd) > + if (bridge_connector->bridge_hpd) { > connector->polled = DRM_CONNECTOR_POLL_HPD; > + drm_bridge_connector_enable_hpd(connector); > + } > else if (bridge_connector->bridge_detect) > connector->polled = DRM_CONNECTOR_POLL_CONNECT > | DRM_CONNECTOR_POLL_DISCONNECT; > -- > 2.30.2