From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E2F7C433E0 for ; Tue, 23 Feb 2021 11:34:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD3876186A for ; Tue, 23 Feb 2021 11:34:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD3876186A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEVx4-0003aE-To for qemu-devel@archiver.kernel.org; Tue, 23 Feb 2021 06:34:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEVwG-0002YT-T0 for qemu-devel@nongnu.org; Tue, 23 Feb 2021 06:33:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:44442) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEVwF-0007f8-3x for qemu-devel@nongnu.org; Tue, 23 Feb 2021 06:33:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614079990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=syDsQho4IHX9F8BHNatwacJ/qpLTQrnr8JiN8KEm3sI=; b=fj313HkdiWOeexeVBCTCtS5vMl/S8ZNWRRZYI+66xXCaoIcAerAZe+qe+4eeGSE+4lgd0g XnR4Pt28yrayPRl5KDuqXHaKUy3EIgZgEvvM9MueHDT8HXkFZFlW8BLUTSX9pXzh9zvc+P AKqf0PTzsLzf8kPyU7yK8hdK8tW4D44= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-ayI9VzBAN_6VtN-7eeY7rA-1; Tue, 23 Feb 2021 06:33:05 -0500 X-MC-Unique: ayI9VzBAN_6VtN-7eeY7rA-1 Received: by mail-wm1-f69.google.com with SMTP id b62so1076600wmc.5 for ; Tue, 23 Feb 2021 03:33:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=syDsQho4IHX9F8BHNatwacJ/qpLTQrnr8JiN8KEm3sI=; b=YI/1+alYr6dg8DsdxiiadPTqJzL9ynSBvdLMbPBMRWieJgG0k1FFstPPn9q/VeOe8U IaXdtZQXj+gzwIYh2MHfFm+8QRs3qpCLEGxyQTiPnZbdCKeOt++l7ylZhj5rhCv7kMIA EE0AfOebDkZPOcq+uX4n6l1B6+EaYsNqlkBDb3x2etPL5/dQ77G99UGQGbknb+5sgs93 xv4C5MSaQk0H9+7BP1zXKeO5JpFdU6Hr8JpZU9iQATYgbuuwPymaIo6WN7FUhfjdjAnJ Ucdb03jqmC1TbIWtHTd9evD8STV3vU4mBtyne1qn4vaKvGwQtdB112ctoqX3GXZvKmr6 73UA== X-Gm-Message-State: AOAM5307BMVvG3nwBFf/4n+7VA+WRdT+bm+zepISEKTNthaX9HgoVqfg Uv2otL4tH2Ol2CiLUkCiwc179XuF5fffOo4zQkuzBUuWlt4bdBlo6WNmejiujDOTHV8PD6hI8O9 zkb/kkBl+riyEwW4= X-Received: by 2002:adf:b345:: with SMTP id k5mr1639006wrd.14.1614079984289; Tue, 23 Feb 2021 03:33:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJyhRMCfkgNzV5r/SXJpBN3DqwCRSq9qnADP1OnC2jV0lG8AQA4dwg4ndLgOSdgq/z2vntQ9iA== X-Received: by 2002:adf:b345:: with SMTP id k5mr1638990wrd.14.1614079984121; Tue, 23 Feb 2021 03:33:04 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id c6sm30842304wrt.26.2021.02.23.03.33.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Feb 2021 03:33:03 -0800 (PST) Subject: Re: [PATCH] docs: move CODING_STYLE into the developer documentation From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210223095931.16908-1-alex.bennee@linaro.org> <2ee6c3b3-7b90-e10c-8950-bfd07c963558@redhat.com> Message-ID: <5a1c4191-b0e6-8dcf-d5db-7335b5f41628@redhat.com> Date: Tue, 23 Feb 2021 12:33:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <2ee6c3b3-7b90-e10c-8950-bfd07c963558@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, CONTENT_AFTER_HTML=2.328, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P . Berrange" , QEMU Developers , Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/23/21 12:29 PM, Philippe Mathieu-Daudé wrote: > On 2/23/21 12:07 PM, Peter Maydell wrote: >> On Tue, 23 Feb 2021 at 10:02, Alex Bennée wrote: >>> >>> There is no particular reason to keep this on it's own in the root of >>> the tree. Move it into the rest of the fine developer manual and fixup >>> any links to it. The only tweak I've made is to fix the code-block >>> annotations to mention the language C. >>> >>> Signed-off-by: Alex Bennée >>> --- >>> diff --git a/README.rst b/README.rst >>> index ce39d89077..f5d41e59b1 100644 >>> --- a/README.rst >>> +++ b/README.rst >>> @@ -66,7 +66,9 @@ When submitting patches, one common approach is to use 'git >>> format-patch' and/or 'git send-email' to format & send the mail to the >>> qemu-devel@nongnu.org mailing list. All patches submitted must contain >>> a 'Signed-off-by' line from the author. Patches should follow the >>> -guidelines set out in the CODING_STYLE.rst file. >>> +guidelines set out in the `style section >>> +` of >>> +the Developers Guide. >> >> This is the first instance of a qemu.readthedocs.io URL in the >> tree. Do we really want to have our references to our documentation >> be to a third party website ? > > We can use https://www.qemu.org/docs/master/devel/style.html: > > $ curl https://www.qemu.org/docs/master/devel/style.html > > > 302 Found > >

Found

>

The document has moved href="https://qemu.readthedocs.io/en/latest/devel/style.html">here.

> Or even better since we have a job pushing to Gitlab pages accessible on https://qemu-project.gitlab.io/qemu/: https://qemu-project.gitlab.io/qemu/devel/style.html Maybe the https://www.qemu.org/docs/ redirect should go to gitlab page now? Phil.