From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laszlo Ersek Subject: Re: [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg Date: Wed, 22 Jun 2016 17:51:53 +0200 Message-ID: <5a3b61d2-c981-2424-a94b-e8d1131b2751@redhat.com> References: <20160616060621.30422-1-haozhong.zhang@intel.com> <20160616060621.30422-4-haozhong.zhang@intel.com> <20160616111951.yvmr6tznzw6tyxlx@hz-desktop> <603c703c-5142-4721-e5a3-2d147c32ccd1@redhat.com> <20160622101833.kb37aukooifeer32@hz-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Paolo Bonzini , qemu-devel@nongnu.org, Richard Henderson , Eduardo Habkost , "Michael S . Tsirkin" , Marcelo Tosatti , kvm@vger.kernel.org, Boris Petkov , Tony Luck , Andi Kleen , rkrcmar@redhat.com, Ashok Raj Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49155 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752993AbcFVPwD (ORCPT ); Wed, 22 Jun 2016 11:52:03 -0400 In-Reply-To: <20160622101833.kb37aukooifeer32@hz-desktop> Sender: kvm-owner@vger.kernel.org List-ID: On 06/22/16 12:18, Haozhong Zhang wrote: > On 06/17/16 19:31, Laszlo Ersek wrote: >> Hi Haozhong, >> >> On 06/16/16 13:19, Haozhong Zhang wrote: >>> On 06/16/16 11:52, Paolo Bonzini wrote: > [..] >>>> Have you prepared a patch for SeaBIOS already? >>> >>> Yes, I'll send it after I fix the type error (uint32_t => uint64_t) in >>> next version. >> >> This should be supported by OVMF as well (thanks Paolo for the heads-up). >> >> I'm glad to code that up, but I'd like to ask you to file an RFE >> (Request For Enhancement) in the upstream edk2 tracker for OVMF: >> >> https://github.com/tianocore/edk2/issues/new >> >> In the RFE, >> - the subject line should include "OvmfPkg", >> - please describe what the feature is good for (going into the details >> of a specific use case is welcome), >> - please specify the pathname and the internal format of the fw_cfg >> file, >> - please clarify if this MSR is considered part of the "chipset state" >> that the firmware is responsible for at *every* boot. In particular >> whether you expect that the firmware program this MSR at S3 resume as >> well. >> > > Done. Pls check https://github.com/tianocore/edk2/issues/97. Thanks. Looks good. I asked a few more questions in there. Especially if the APs are involved in this, then the feature is going to be significantly more complex than I expected. Thanks Laszlo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFkRh-0002w9-VQ for qemu-devel@nongnu.org; Wed, 22 Jun 2016 11:52:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFkRa-0002Gz-TB for qemu-devel@nongnu.org; Wed, 22 Jun 2016 11:52:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFkRa-0002Gu-ND for qemu-devel@nongnu.org; Wed, 22 Jun 2016 11:51:58 -0400 References: <20160616060621.30422-1-haozhong.zhang@intel.com> <20160616060621.30422-4-haozhong.zhang@intel.com> <20160616111951.yvmr6tznzw6tyxlx@hz-desktop> <603c703c-5142-4721-e5a3-2d147c32ccd1@redhat.com> <20160622101833.kb37aukooifeer32@hz-desktop> From: Laszlo Ersek Message-ID: <5a3b61d2-c981-2424-a94b-e8d1131b2751@redhat.com> Date: Wed, 22 Jun 2016 17:51:53 +0200 MIME-Version: 1.0 In-Reply-To: <20160622101833.kb37aukooifeer32@hz-desktop> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org, Richard Henderson , Eduardo Habkost , "Michael S . Tsirkin" , Marcelo Tosatti , kvm@vger.kernel.org, Boris Petkov , Tony Luck , Andi Kleen , rkrcmar@redhat.com, Ashok Raj On 06/22/16 12:18, Haozhong Zhang wrote: > On 06/17/16 19:31, Laszlo Ersek wrote: >> Hi Haozhong, >> >> On 06/16/16 13:19, Haozhong Zhang wrote: >>> On 06/16/16 11:52, Paolo Bonzini wrote: > [..] >>>> Have you prepared a patch for SeaBIOS already? >>> >>> Yes, I'll send it after I fix the type error (uint32_t => uint64_t) in >>> next version. >> >> This should be supported by OVMF as well (thanks Paolo for the heads-up). >> >> I'm glad to code that up, but I'd like to ask you to file an RFE >> (Request For Enhancement) in the upstream edk2 tracker for OVMF: >> >> https://github.com/tianocore/edk2/issues/new >> >> In the RFE, >> - the subject line should include "OvmfPkg", >> - please describe what the feature is good for (going into the details >> of a specific use case is welcome), >> - please specify the pathname and the internal format of the fw_cfg >> file, >> - please clarify if this MSR is considered part of the "chipset state" >> that the firmware is responsible for at *every* boot. In particular >> whether you expect that the firmware program this MSR at S3 resume as >> well. >> > > Done. Pls check https://github.com/tianocore/edk2/issues/97. Thanks. Looks good. I asked a few more questions in there. Especially if the APs are involved in this, then the feature is going to be significantly more complex than I expected. Thanks Laszlo