All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "McMillan, Erich" <erich.mcmillan@hp.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"mst@redhat.com" <mst@redhat.com>,
	"qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>
Subject: Re: PATCH: Increase System Firmware Max Size
Date: Wed, 16 Sep 2020 12:00:44 +0200	[thread overview]
Message-ID: <5a407d82-49bb-ce57-f7bc-ceeb8cc5fc2c@redhat.com> (raw)
In-Reply-To: <eaa64c6a-18cb-69df-3154-614744e1bfa9@redhat.com>

On 09/16/20 11:52, Laszlo Ersek wrote:

> (5) In my opinion (which could be wrong of course), we shouldn't
> introduce a new command line option for this, but a new PC machine type
> property called "x-firmware-max-size".
> 
> Please look at the object_class_property_add() calls in
> pc_machine_class_init() [hw/i386/pc.c].
> 
> I think the PC_MACHINE_MAX_RAM_BELOW_4G property is a good example to
> imitate:
> 
> - It has type "size".
> 
> - It comes with a getter and a setter, and an associated field in
> PCMachineState ("max_ram_below_4g").
> 
> - It has a nice description.
> 
> Then in pc_system_flash_map() [hw/i386/pc_sysfw.c], I suggest replacing
> FLASH_SIZE_LIMIT with "pcms->firmware_max_size".

The default value (8MB) should be set in pc_machine_initfn() [hw/i386/pc.c].

Thanks
Laszlo



      parent reply	other threads:[~2020-09-16 10:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11  1:45 PATCH: Increase System Firmware Max Size McMillan, Erich
2020-09-11  7:55 ` Laszlo Ersek
2020-09-11  8:34   ` Dr. David Alan Gilbert
2020-09-11 14:53     ` Laszlo Ersek
2020-09-11 15:06       ` Dr. David Alan Gilbert
2020-09-11 15:22         ` McMillan, Erich via
2020-09-11 16:11           ` Laszlo Ersek
2020-09-11 15:23         ` Daniel P. Berrangé
2020-09-11 16:06           ` Laszlo Ersek
2020-09-11 16:21             ` Daniel P. Berrangé
2020-09-11 16:45               ` Laszlo Ersek
2020-09-11 15:57         ` Laszlo Ersek
2020-09-11 16:22           ` Dr. David Alan Gilbert
2020-09-11 16:53             ` Laszlo Ersek
2020-09-11 16:59               ` Dr. David Alan Gilbert
2020-09-11 17:51                 ` McMillan, Erich via
2020-09-15 19:09 ` McMillan, Erich
2020-09-15 19:10   ` McMillan, Erich via
2020-09-16  9:52     ` Laszlo Ersek
2020-09-16  9:56       ` Daniel P. Berrangé
2020-09-16 11:31         ` Laszlo Ersek
2020-09-16 11:43           ` Daniel P. Berrangé
2020-09-16 10:00       ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a407d82-49bb-ce57-f7bc-ceeb8cc5fc2c@redhat.com \
    --to=lersek@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=erich.mcmillan@hp.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.