From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/sox: work around gcc bug 68485
Date: Sun, 11 Sep 2022 21:19:33 +0200 [thread overview]
Message-ID: <5a597da6-8f7d-5516-91a6-6905db764b00@benettiengineering.com> (raw)
In-Reply-To: <20220911191742.GG898622@scaer>
Hi Yann,
On 11/09/22 21:17, Yann E. MORIN wrote:
> Giulio, All,
>
> On 2022-09-10 00:15 +0200, Giulio Benetti spake thusly:
>> With Microblaze Gcc version <= 12.x the build fails due to gcc bug 68485:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485. The bug show up when
>> building sox with optimization but not when building with -O0. To work
>> around this, if BR2_TOOLCHAIN_HAS_GCC_BUG_68458=y, we force using -O0.
>
> Given your feedback on my review, I have amended the commit log into a
> form that looks (at least to me) more appropriate. Please review it and
> yell if I made a mistake.
It sounds very good.
Thank you!
--
Giulio Benetti
Benetti Engineering sas
> Applied to master, thanks.
>
> Regards,
> Yann E. MORIN.
>
>> Fixes:
>> http://autobuild.buildroot.net/results/ac4/ac4fbd55529ac7b4e635a11766f842cd25a833a1/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>> package/sox/sox.mk | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/package/sox/sox.mk b/package/sox/sox.mk
>> index 1896437ad4..d0329bf50d 100644
>> --- a/package/sox/sox.mk
>> +++ b/package/sox/sox.mk
>> @@ -26,6 +26,14 @@ SOX_CONF_OPTS = \
>> --with-distro="Buildroot" \
>> --disable-stack-protector
>>
>> +SOX_CFLAGS = $(TARGET_CFLAGS)
>> +
>> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
>> +SOX_CFLAGS += -O0
>> +endif
>> +
>> +SOX_CONF_ENV += CFLAGS="$(SOX_CFLAGS)"
>> +
>> ifeq ($(BR2_PACKAGE_ALSA_LIB_PCM),y)
>> SOX_DEPENDENCIES += alsa-lib
>> SOX_CONF_OPTS += --enable-alsa
>> --
>> 2.34.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-11 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 22:15 [Buildroot] [PATCH] package/sox: work around gcc bug 68485 Giulio Benetti
2022-09-10 7:05 ` Yann E. MORIN
2022-09-10 14:22 ` Giulio Benetti
2022-09-11 19:17 ` Yann E. MORIN
2022-09-11 19:19 ` Giulio Benetti [this message]
2022-09-18 21:12 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a597da6-8f7d-5516-91a6-6905db764b00@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=buildroot@buildroot.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.