From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3AD6C433EF for ; Mon, 14 Mar 2022 21:32:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 19BDC837C7; Mon, 14 Mar 2022 22:32:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Bo94R7Vg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 710F5837C7; Mon, 14 Mar 2022 22:32:00 +0100 (CET) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E6BA0836A9 for ; Mon, 14 Mar 2022 22:31:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-wm1-x330.google.com with SMTP id n31-20020a05600c3b9f00b003898fc06f1eso341165wms.1 for ; Mon, 14 Mar 2022 14:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=LBVqSLlgSyjhfHMUATs7BJCVw2EBwLV2AcYD3CvovhI=; b=Bo94R7VgJTKszQ96f5EoofOUY+QRQaHTSGQEUPVqXANUTB5Ew1fDzheyETbTGhAtyr 5SFvsv1cMsIlrUq3Ue+wIq1wb6Te26wrY2nsERlezpxsFaEgJ1VMQW2pmQeH3js9BueP OD1I6uDC06JuFBmVfrJ5NoMbq0bVVjdMRI6MgwMGNpKcy/pz4PH3s9CY0e5o+DEzfLEj h2REb88M/Cg27X52Z0V+lFo3TcHQz5/7aPTcUId/Fc8xvJ2kSJKtYhiGxScCrhR+1f3Y z51PC1JYcGZGlkx1az6oJODntLh3EYCnZI+5o17mVG/a1C6AIsw27p2WkSpZGftpBzcR D71Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=LBVqSLlgSyjhfHMUATs7BJCVw2EBwLV2AcYD3CvovhI=; b=r++9D99zx4mHP2U4HwDVZ6cJ8RLXhHG6t0BcUOh6gXF5foBJ2TBNI2vyHO6hsL1ohk Ai48LvIvYlSrxy3jVFqCOGoOSkBqh9+M3qIRuFe5t2j55fTBC49SuJVYdSb8gs4iVWLB a7zzUa/tiQO9ryMqfHNMBdNk4ftmB7RZ03pFLz8aYvn1OOO4/VAwm8Gzzq+pZJxlCcqB 7znw7j8uq6dDBvx3oviVMbUWmftzKq17qAG3PiHY0yJSdCxxsacirgLRC2cLer/TN9iM /D4FHiLYjWfiebMPZPe8yADAXXWr/FqkVSOrAynjR6I6Wp3pHfc794CDJTWCvKB8y0EK nV6w== X-Gm-Message-State: AOAM5325hvnH+euZPHyhaIHHBPr5kaHIs1I5f3fMuI4EYr0SXw8PyEYv ZoRqQ/vi6CM6DoCmadUk+Ic= X-Google-Smtp-Source: ABdhPJxZLgzLEzQsii7IUx8WAhOq2MTBMjEhzB0lvNeEKUSZDfVEzhf/ofNRX2CsWxTcGkvCuFS4pw== X-Received: by 2002:a7b:c1c7:0:b0:382:ab44:3688 with SMTP id a7-20020a7bc1c7000000b00382ab443688mr805710wmj.153.1647293516316; Mon, 14 Mar 2022 14:31:56 -0700 (PDT) Received: from [192.168.0.74] ([178.233.26.119]) by smtp.gmail.com with ESMTPSA id ay24-20020a05600c1e1800b00389a420e1ecsm548316wmb.37.2022.03.14.14.31.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Mar 2022 14:31:55 -0700 (PDT) Message-ID: <5a67bbf5-c305-025b-0834-28ac1afa24b6@gmail.com> Date: Tue, 15 Mar 2022 00:29:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 From: Alper Nebi Yasak Subject: Re: [PATCH v2 12/25] binman: Change how faked blobs are created To: Simon Glass Cc: Ivan Mikhaylov , Tom Rini , Philippe Reynes , huang lin , Jeffy Chen , Kever Yang , U-Boot Mailing List References: <20220223230040.159317-1-sjg@chromium.org> <20220223230040.159317-13-sjg@chromium.org> <22d5d296-65b4-2a97-5879-d038d400efc5@gmail.com> <263b8679-75dd-ada5-7d1f-409702320d27@gmail.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 12/03/2022 08:02, Simon Glass wrote: > On Thu, 10 Mar 2022 at 12:36, Alper Nebi Yasak wrote: >> On 06/03/2022 06:08, Simon Glass wrote: >>> On Thu, 3 Mar 2022 at 14:16, Alper Nebi Yasak wrote: >>>> Do we need to create actual files, or is it a convenience thing for blob >>>> entry types (because they already read their contents from files)? >>> >>> We need the files for mkimage. >> >> But the mkimage etype creates its own files to pass to mkimage anyway, >> using entry.GetData() in collect_contents_to_file() without reaching >> into subentries' files. >> >> More specifically, what I'm thinking of is removing check_fake_fname() >> entirely, instead of managing/removing the files it creates. At a >> cursory glance, only blob and blob-ext-list seem to use that directly. > > OK, but if the files don't get created, then mkimage will fail, right? I don't think it will, but maybe it's better that I try removing it to see if anything breaks.