From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71E12C433E9 for ; Thu, 11 Mar 2021 12:39:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 230F564FFB for ; Thu, 11 Mar 2021 12:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233411AbhCKMig (ORCPT ); Thu, 11 Mar 2021 07:38:36 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:63340 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233396AbhCKMiI (ORCPT ); Thu, 11 Mar 2021 07:38:08 -0500 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4Dx7lF5W0Kz9typg; Thu, 11 Mar 2021 13:38:01 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id Zg2vF4EyxMrh; Thu, 11 Mar 2021 13:38:01 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4Dx7lF478Pz9typf; Thu, 11 Mar 2021 13:38:01 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id E028F8B80A; Thu, 11 Mar 2021 13:38:02 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id TXSY3mhLfLtq; Thu, 11 Mar 2021 13:38:02 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 5FCCF8B80D; Thu, 11 Mar 2021 13:38:02 +0100 (CET) Subject: Re: [PATCH v2 36/43] powerpc/32: Set current->thread.regs in C interrupt entry From: Christophe Leroy To: Nicholas Piggin , Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <8d523f9ecee1de0515cc31d43030c12ab171a670.1615291474.git.christophe.leroy@csgroup.eu> <1615339900.vmbtzuirqw.astroid@bobo.none> <035298ad-4d0b-5e74-6f5c-e03677580924@csgroup.eu> Message-ID: <5a80e05e-27d7-0e95-67c7-0fe3255c4be1@csgroup.eu> Date: Thu, 11 Mar 2021 13:38:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <035298ad-4d0b-5e74-6f5c-e03677580924@csgroup.eu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 11/03/2021 à 11:38, Christophe Leroy a écrit : > > > Le 10/03/2021 à 02:33, Nicholas Piggin a écrit : >> Excerpts from Christophe Leroy's message of March 9, 2021 10:10 pm: >>> No need to do that is assembly, do it in C. >> >> Hmm. No issues with the patch as such, but why does ppc32 need this but >> not 64? AFAIKS 64 sets this when a thread is created. > > Looks like ppc64 was doing the same in function save_remaining_regs() in arch/ppc64/kernel/head.S > until commit https://github.com/mpe/linux-fullhistory/commit/e5bb080d > > But I can't find what happend to it in that commit. > > Where is it done now ? Maybe that's also already done for ppc32. > I digged a bit more and found a later bug fix which adds that setting of current->thread.regs at task creation: https://github.com/mpe/linux-fullhistory/commit/3eac1897 That was in the ppc64 tree only at that time, and was merged into the common powerpc tree via commit https://github.com/mpe/linux-fullhistory/commit/06d67d54 So we have it for both ppc32 and ppc64 and ppc32 doesn't need to do it at exception entry anymore. I'll remove it. Thanks Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AF43C433E0 for ; Thu, 11 Mar 2021 12:38:32 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64BD664FDF for ; Thu, 11 Mar 2021 12:38:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64BD664FDF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Dx7ln4ShQz3cYr for ; Thu, 11 Mar 2021 23:38:29 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@csgroup.eu; receiver=) Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Dx7lQ55nkz3cKK for ; Thu, 11 Mar 2021 23:38:06 +1100 (AEDT) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4Dx7lF5W0Kz9typg; Thu, 11 Mar 2021 13:38:01 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id Zg2vF4EyxMrh; Thu, 11 Mar 2021 13:38:01 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4Dx7lF478Pz9typf; Thu, 11 Mar 2021 13:38:01 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id E028F8B80A; Thu, 11 Mar 2021 13:38:02 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id TXSY3mhLfLtq; Thu, 11 Mar 2021 13:38:02 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 5FCCF8B80D; Thu, 11 Mar 2021 13:38:02 +0100 (CET) Subject: Re: [PATCH v2 36/43] powerpc/32: Set current->thread.regs in C interrupt entry From: Christophe Leroy To: Nicholas Piggin , Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras References: <8d523f9ecee1de0515cc31d43030c12ab171a670.1615291474.git.christophe.leroy@csgroup.eu> <1615339900.vmbtzuirqw.astroid@bobo.none> <035298ad-4d0b-5e74-6f5c-e03677580924@csgroup.eu> Message-ID: <5a80e05e-27d7-0e95-67c7-0fe3255c4be1@csgroup.eu> Date: Thu, 11 Mar 2021 13:38:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <035298ad-4d0b-5e74-6f5c-e03677580924@csgroup.eu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 11/03/2021 à 11:38, Christophe Leroy a écrit : > > > Le 10/03/2021 à 02:33, Nicholas Piggin a écrit : >> Excerpts from Christophe Leroy's message of March 9, 2021 10:10 pm: >>> No need to do that is assembly, do it in C. >> >> Hmm. No issues with the patch as such, but why does ppc32 need this but >> not 64? AFAIKS 64 sets this when a thread is created. > > Looks like ppc64 was doing the same in function save_remaining_regs() in arch/ppc64/kernel/head.S > until commit https://github.com/mpe/linux-fullhistory/commit/e5bb080d > > But I can't find what happend to it in that commit. > > Where is it done now ? Maybe that's also already done for ppc32. > I digged a bit more and found a later bug fix which adds that setting of current->thread.regs at task creation: https://github.com/mpe/linux-fullhistory/commit/3eac1897 That was in the ppc64 tree only at that time, and was merged into the common powerpc tree via commit https://github.com/mpe/linux-fullhistory/commit/06d67d54 So we have it for both ppc32 and ppc64 and ppc32 doesn't need to do it at exception entry anymore. I'll remove it. Thanks Christophe