Re: [PATCH v1 5/5] Convert CONFIG_AT91_EFLASH to Kconfig

From: Stefan Roese <sr@denx.de>
To: Patrick Delaunay <patrick.delaunay@foss.st.com>, u-boot@lists.denx.de
Cc: "Marek Vasut" <marex@denx.de>, "Simon Glass" <sjg@chromium.org>,
	"Eugen Hristev" <eugen.hristev@microchip.com>,
	"Marek Behún" <marek.behun@nic.cz>,
	"Priyanka Jain" <priyanka.jain@nxp.com>,
	"egnite GmbH" <info@egnite.de>,
	"U-Boot STM32" <uboot-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH v1 5/5] Convert CONFIG_AT91_EFLASH to Kconfig
Date: Wed, 5 Jan 2022 09:44:30 +0100	[thread overview]
Message-ID: <5a8697e7-e2cc-7988-9496-06a051fe0ef6@denx.de> (raw)
In-Reply-To: <20220104142328.v1.5.I5fc8065d06afb12c358588f9078ba15b1cbbe94c@changeid>

On 1/4/22 14:24, Patrick Delaunay wrote:
> This converts the following to Kconfig:
>     CONFIG_AT91_EFLASH
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> 
>   arch/arm/mach-at91/Kconfig   | 8 ++++++++
>   configs/ethernut5_defconfig  | 2 +-
>   include/configs/ethernut5.h  | 1 -
>   scripts/config_whitelist.txt | 1 -
>   4 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 4448ca1592..00f31045d6 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -302,6 +302,14 @@ config ATMEL_SFR
>   config SYS_SOC
>   	default "at91"
>   
> +config AT91_EFLASH
> +	bool "Support AT91 flash driver"
> +	depends on AT91SAM9XE
> +	select USE_SYS_MAX_FLASH_BANKS
> +	help
> +	  Enable the driver for the embedded flash used in the Atmel
> +	  AT91SAM9XE devices.
> +
>   source "board/atmel/at91sam9260ek/Kconfig"
>   source "board/atmel/at91sam9261ek/Kconfig"
>   source "board/atmel/at91sam9263ek/Kconfig"
> diff --git a/configs/ethernut5_defconfig b/configs/ethernut5_defconfig
> index 5d98318aab..7a701db0e1 100644
> --- a/configs/ethernut5_defconfig
> +++ b/configs/ethernut5_defconfig
> @@ -4,6 +4,7 @@ CONFIG_ARCH_CPU_INIT=y
>   CONFIG_ARCH_AT91=y
>   CONFIG_SYS_TEXT_BASE=0x27000000
>   CONFIG_SYS_MALLOC_LEN=0x121000
> +CONFIG_AT91_EFLASH=y
>   CONFIG_SYS_MALLOC_F_LEN=0x2000
>   CONFIG_TARGET_ETHERNUT5=y
>   CONFIG_NR_DRAM_BANKS=1
> @@ -66,7 +67,6 @@ CONFIG_SYS_I2C_SOFT_SLAVE=0
>   CONFIG_GENERIC_ATMEL_MCI=y
>   CONFIG_MTD=y
>   CONFIG_MTD_NOR_FLASH=y
> -CONFIG_USE_SYS_MAX_FLASH_BANKS=y
>   CONFIG_MTD_RAW_NAND=y
>   # CONFIG_SYS_NAND_USE_FLASH_BBT is not set
>   CONFIG_NAND_ATMEL=y
> diff --git a/include/configs/ethernut5.h b/include/configs/ethernut5.h
> index d72f704636..d88c14ac44 100644
> --- a/include/configs/ethernut5.h
> +++ b/include/configs/ethernut5.h
> @@ -33,7 +33,6 @@
>   
>   /* 512kB on-chip NOR flash */
>   # define CONFIG_SYS_FLASH_BASE		0x00200000 /* AT91SAM9XE_FLASH_BASE */
> -# define CONFIG_AT91_EFLASH
>   # define CONFIG_SYS_MAX_FLASH_SECT	32
>   # define CONFIG_EFLASH_PROTSECTORS	1
>   
> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt
> index 7726243f22..3a923abf7e 100644
> --- a/scripts/config_whitelist.txt
> +++ b/scripts/config_whitelist.txt
> @@ -18,7 +18,6 @@ CONFIG_AT91SAM9G20EK
>   CONFIG_AT91SAM9G20EK_2MMC
>   CONFIG_AT91SAM9G45_LCD_BASE
>   CONFIG_AT91SAM9M10G45EK
> -CONFIG_AT91_EFLASH
>   CONFIG_AT91_GPIO_PULLUP
>   CONFIG_AT91_LED
>   CONFIG_AT91_WANTS_COMMON_PHY
> 

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de