All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Wenwu Ma <wenwux.ma@intel.com>, <dev@dpdk.org>
Cc: <maxime.coquelin@redhat.com>, <chenbo.xia@intel.com>,
	<cheng1.jiang@intel.com>, <jiayu.hu@intel.com>,
	<yvonnex.yang@intel.com>, <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] examples/vhost: change the default value of NIC's max queues
Date: Thu, 21 Oct 2021 18:10:03 +0100	[thread overview]
Message-ID: <5ab40d4e-0fb0-8291-6bb8-c124be4fbdf0@intel.com> (raw)
In-Reply-To: <20211015164832.8865-1-wenwux.ma@intel.com>

On 10/15/2021 5:48 PM, Wenwu Ma wrote:
> vswitch can't launch with a 40G i40e port due to device start fails

what is 'vswitch' that is referred? I expect what can't launch should
be this sample app but why referring it as 'vswitch'?

Also patch title describes what is done, better to describe why it is done,
like:
examples/vhost: fix init for devices that has big max queue number

btw, why a device with big max queue number causes failure in the sample app?
Can you please provide more detail on the error? What and why fails on
device start?

> if NIC’s max queues > the default number of 128, so, we changed
> the default value from 128 to 512.
> 
> Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
> ---
>   examples/vhost/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index bc3d71c898..36969a4de5 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -29,7 +29,7 @@
>   #include "main.h"
>   
>   #ifndef MAX_QUEUES
> -#define MAX_QUEUES 128
> +#define MAX_QUEUES 512
>   #endif
>   
>   /* the maximum number of external ports supported */
> 


  parent reply	other threads:[~2021-10-21 17:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 13:52 [dpdk-dev] [PATCH] examples/vhost: change the default value of NIC's max queues Wenwu Ma
2021-09-10  2:12 ` Jiang, Cheng1
2021-09-10  3:17 ` Xia, Chenbo
2021-09-13 15:49   ` Maxime Coquelin
2021-10-15  7:30   ` Maxime Coquelin
2021-10-15  8:52   ` David Marchand
2021-10-15 16:48 ` [dpdk-dev] [PATCH v3] " Wenwu Ma
2021-10-21 11:29   ` Maxime Coquelin
2021-10-21 12:34   ` Maxime Coquelin
2021-10-21 17:10   ` Ferruh Yigit [this message]
2021-11-03 14:17   ` [dpdk-dev] [PATCH v4] examples/vhost: fix failure to launch dpdk-vhost Wenwu Ma
2021-11-03  4:58     ` Xia, Chenbo
2021-11-03  8:07       ` Maxime Coquelin
2021-10-15 20:01 ` [dpdk-dev] [PATCH v2] examples/vhost: change the default value of NIC's max queues Wenwu Ma
2021-10-15  8:21   ` Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ab40d4e-0fb0-8291-6bb8-c124be4fbdf0@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=cheng1.jiang@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=wenwux.ma@intel.com \
    --cc=yvonnex.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.