From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABBF9C433E1 for ; Sat, 20 Mar 2021 17:17:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FE8C61927 for ; Sat, 20 Mar 2021 17:17:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229870AbhCTRQ6 (ORCPT ); Sat, 20 Mar 2021 13:16:58 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:16251 "EHLO mail-40134.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229834AbhCTRQy (ORCPT ); Sat, 20 Mar 2021 13:16:54 -0400 Date: Sat, 20 Mar 2021 17:16:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connolly.tech; s=protonmail; t=1616260611; bh=XHD5SNh+JKh0y8dumYp4YnG/TSTm/z8ZjC7Ay7aNkvI=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=Zzcz8jnVlrGykUWjhEwsd3PP2HLzin8LdqVKriRM7EwIUfo5z0kzLyTSHudAeJrwl HRfgu0REkoxNRMdCT1/0JoDJ5Y3ZHVFaluT2bGik2/3b3Z4+06ytW0hLlSt2D41tj+ ZxXZddxGiWUNBvl8I9nwWq3WNpdcqsj92l1D3/3U= To: Vinod Koul From: Caleb Connolly Cc: Andy Gross , Bjorn Andersson , Rob Herring , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Caleb Connolly Subject: Re: [PATCH 2/3] arm64: dts: qcom: sm8150: add iommus to qups Message-ID: <5ab5b7df-1624-10bf-f268-c32dc5bf0bb6@connolly.tech> In-Reply-To: References: <20210310163024.393578-1-caleb@connolly.tech> <20210310163024.393578-3-caleb@connolly.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Vinod, On 16/03/2021 6:15 am, Vinod Koul wrote: > On 10-03-21, 16:31, Caleb Connolly wrote: >> Hook up the SMMU for doing DMA over i2c. Some peripherals like >> touchscreens easily exceed 32-bytes per transfer, causing errors and >> lockups without this. > Why not squash this to patch 1..? I thought it made more sense to separate these patches to keep the=20 history a bit cleaner. I can squash them if you'd prefer. =C2=A0=C2=A0=C2=A0 Caleb > >> Signed-off-by: Caleb Connolly >> --- >> Fixes i2c on the OnePlus 7, without this touching the screen with more >> than 4 fingers causes the device to lock up and reboot. >> --- >> arch/arm64/boot/dts/qcom/sm8150.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/= qcom/sm8150.dtsi >> index 03e05d98daf2..543417d74216 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi >> @@ -583,6 +583,7 @@ qupv3_id_0: geniqup@8c0000 { >> =09=09=09clock-names =3D "m-ahb", "s-ahb"; >> =09=09=09clocks =3D <&gcc GCC_QUPV3_WRAP_0_M_AHB_CLK>, >> =09=09=09=09 <&gcc GCC_QUPV3_WRAP_0_S_AHB_CLK>; >> +=09=09=09iommus =3D <&apps_smmu 0xc3 0x0>; >> =09=09=09#address-cells =3D <2>; >> =09=09=09#size-cells =3D <2>; >> =09=09=09ranges; >> @@ -595,6 +596,7 @@ qupv3_id_1: geniqup@ac0000 { >> =09=09=09clock-names =3D "m-ahb", "s-ahb"; >> =09=09=09clocks =3D <&gcc GCC_QUPV3_WRAP_1_M_AHB_CLK>, >> =09=09=09=09 <&gcc GCC_QUPV3_WRAP_1_S_AHB_CLK>; >> +=09=09=09iommus =3D <&apps_smmu 0x603 0x0>; >> =09=09=09#address-cells =3D <2>; >> =09=09=09#size-cells =3D <2>; >> =09=09=09ranges; >> @@ -617,6 +619,7 @@ qupv3_id_2: geniqup@cc0000 { >> =09=09=09clock-names =3D "m-ahb", "s-ahb"; >> =09=09=09clocks =3D <&gcc GCC_QUPV3_WRAP_2_M_AHB_CLK>, >> =09=09=09=09 <&gcc GCC_QUPV3_WRAP_2_S_AHB_CLK>; >> +=09=09=09iommus =3D <&apps_smmu 0x7a3 0x0>; >> =09=09=09#address-cells =3D <2>; >> =09=09=09#size-cells =3D <2>; >> =09=09=09ranges; >> -- >> 2.29.2 >> > -- > ~Vinod