From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09ACEC54FD3 for ; Mon, 20 Apr 2020 13:48:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DED8A20672 for ; Mon, 20 Apr 2020 13:48:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MjROekO0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728798AbgDTNsn (ORCPT ); Mon, 20 Apr 2020 09:48:43 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:42811 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726451AbgDTNsi (ORCPT ); Mon, 20 Apr 2020 09:48:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587390517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7y4WU1T9l13UE4AeSAMeV0dvLVDo/1wJoF790VrkXE=; b=MjROekO0eJQYdahTnITYjsf30ZZtcQjDLV0W3qbOSfWc7rEFKCdyVOsLe+xA4KEf15rvTR qOx4x5/cqn2UmQ495TJGzl9GgcpRwyND4gTMCaERDRlvhyV5JdWzisYc/aLYdEe071Ooya 3oRRZpnvVFfPKKI2fAxDvSyfiLiBDTs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-N9UYrC5qPM-27Q4o2iNAMA-1; Mon, 20 Apr 2020 09:48:34 -0400 X-MC-Unique: N9UYrC5qPM-27Q4o2iNAMA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3D87F190D343; Mon, 20 Apr 2020 13:48:33 +0000 (UTC) Received: from [IPv6:::1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6011312656B; Mon, 20 Apr 2020 13:48:32 +0000 (UTC) Subject: Re: [PATCH 2/2 V2] man2: New page documenting filesystem get/set label ioctls To: mtk.manpages@gmail.com, Eric Sandeen Cc: fsdevel , "linux-btrfs@vger.kernel.org" , Linux API , linux-man References: <708b8e2a-2bc2-df38-ec9c-c605203052b5@sandeen.net> <7d74cc3b-52cc-be60-0a69-1a5ee1499f47@sandeen.net> From: Eric Sandeen Message-ID: <5ac17186-4463-4f61-4733-125f2af9b73d@redhat.com> Date: Mon, 20 Apr 2020 08:48:31 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 4/20/20 7:04 AM, Michael Kerrisk (man-pages) wrote: > Hello Eric, > > So it seems like this feature eventually got merged in Linux 4.18. Is > this page up to date with what went into the kernel? Yes, I believe that it's all still accurate. Thanks, -Eric > Thanks, > > Michael > > On Thu, 10 May 2018 at 19:29, Eric Sandeen wrote: >> >> This documents the proposed new vfs-level ioctls which can >> get or set a mounted filesytem's label. >> >> Signed-off-by: Eric Sandeen >> --- >> >> V2: make primary file ioctl_getfslabel, link ioctl_setfslabel to it >> note that getfslabel requires CAP_SYS_ADMIN >> >> diff --git a/man2/ioctl_getfslabel.2 b/man2/ioctl_getfslabel.2 >> new file mode 100644 >> index 0000000..2c3375c >> --- /dev/null >> +++ b/man2/ioctl_getfslabel.2 >> @@ -0,0 +1,87 @@ >> +.\" Copyright (c) 2018, Red Hat, Inc. All rights reserved. >> +.\" >> +.\" %%%LICENSE_START(GPLv2+_DOC_FULL) >> +.\" This is free documentation; you can redistribute it and/or >> +.\" modify it under the terms of the GNU General Public License as >> +.\" published by the Free Software Foundation; either version 2 of >> +.\" the License, or (at your option) any later version. >> +.\" >> +.\" The GNU General Public License's references to "object code" >> +.\" and "executables" are to be interpreted as the output of any >> +.\" document formatting or typesetting system, including >> +.\" intermediate and printed output. >> +.\" >> +.\" This manual is distributed in the hope that it will be useful, >> +.\" but WITHOUT ANY WARRANTY; without even the implied warranty of >> +.\" MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +.\" GNU General Public License for more details. >> +.\" >> +.\" You should have received a copy of the GNU General Public >> +.\" License along with this manual; if not, see >> +.\" . >> +.\" %%%LICENSE_END >> +.TH IOCTL-FSLABEL 2 2018-05-02 "Linux" "Linux Programmer's Manual" >> +.SH NAME >> +ioctl_fslabel \- get or set a filesystem label >> +.SH SYNOPSIS >> +.br >> +.B #include >> +.br >> +.B #include >> +.sp >> +.BI "int ioctl(int " fd ", FS_IOC_GETFSLABEL, char " label [FSLABEL_MAX]); >> +.br >> +.BI "int ioctl(int " fd ", FS_IOC_SETFSLABEL, char " label [FSLABEL_MAX]); >> +.SH DESCRIPTION >> +If a filesystem supports online label manipulation, these >> +.BR ioctl (2) >> +operations can be used to get or set the filesystem label for the filesystem >> +on which >> +.B fd >> +resides. >> +The >> +.B FS_IOC_SETFSLABEL >> +operation requires privilege >> +.RB ( CAP_SYS_ADMIN ). >> +.SH RETURN VALUE >> +On success zero is returned. On error, \-1 is returned, and >> +.I errno >> +is set to indicate the error. >> +.PP >> +.SH ERRORS >> +Error codes can be one of, but are not limited to, the following: >> +.TP >> +.B EINVAL >> +The specified label exceeds the maximum label length for the filesystem. >> +.TP >> +.B ENOTTY >> +This can appear if the filesystem does not support online label manipulation. >> +.TP >> +.B EPERM >> +The calling process does not have sufficient permissions to set the label. >> +.TP >> +.B EFAULT >> +.I label >> +references an inaccessible memory area. >> +.SH VERSIONS >> +These ioctl operations first appeared in Linux 4.18. >> +They were previously known as >> +.B BTRFS_IOC_GET_FSLABEL >> +and >> +.B BTRFS_IOC_SET_FSLABEL >> +and were private to Btrfs. >> +.SH CONFORMING TO >> +This API is Linux-specific. >> +.SH NOTES >> +The maximum string length for this interface is >> +.BR FSLABEL_MAX , >> +including the terminating null byte (\(aq\\0\(aq). >> +Filesystems have differing maximum label lengths, which may or >> +may not include the terminating null. The string provided to >> +.B FS_IOC_SETFSLABEL >> +must always be null-terminated, and the string returned by >> +.B FS_IOC_GETFSLABEL >> +will always be null-terminated. >> +.SH SEE ALSO >> +.BR ioctl (2), >> +.BR blkid (8) >> diff --git a/man2/ioctl_setfslabel.2 b/man2/ioctl_setfslabel.2 >> new file mode 100644 >> index 0000000..2119835 >> --- /dev/null >> +++ b/man2/ioctl_setfslabel.2 >> @@ -0,0 +1 @@ >> +.so man2/ioctl_getfslabel.2 >> > >