From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A847C433EF for ; Fri, 18 Mar 2022 10:49:47 +0000 (UTC) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.groups.io with SMTP id smtpd.web10.8324.1647600585709532168 for ; Fri, 18 Mar 2022 03:49:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=VxfJ6mTU; spf=pass (domain: linuxfoundation.org, ip: 209.85.128.54, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wm1-f54.google.com with SMTP id q7-20020a7bce87000000b00382255f4ca9so6475273wmj.2 for ; Fri, 18 Mar 2022 03:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=6EJGZypxIFl65BZhBz8duvWwBPRwWyDJ+aSfNuoxigM=; b=VxfJ6mTU2uIkQFhTeH7rWwXoXX05KDS8LfPqo2nieeUV2oBG7xY25tb5lNoyIOmmiI 5DKZUvhf7jqVX94uwmdhZdO5fTRncR6XC1xRFJ+6GA78AWlc7to6/dqzL7It9Kl/bshQ UEat3sCzroXMTOiR/7KgIMvmzwF4DRb4rkPw8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=6EJGZypxIFl65BZhBz8duvWwBPRwWyDJ+aSfNuoxigM=; b=D8W3qC1ECQlVkyyajTUfeYi/IsZu4INzK9RVm61uhsM8lM5y1EHg3dexRMCEk+aQgo lAIG1K4YEW/ol6Kd8ERloLVWOqymWDqy363KuG/svOwxfHXgEOjTqSj6QTtjO9om9wAb ADFOz0P/aYWQRV5O77lUVaiY/wn+6OLxzrmkUQ44ef2OAUiUzY3eiz8zDGspazwZtxU0 oisf+yIFsSctQFCParH1mZFqcKt6eTyPe5iYpvTdZhmhBGM4bxgZQyzdYi6bGy8a/b+q Twe7n/vdg+BnWGgvDDruAyFho58RULrEh2Q/WT9Wo09nHc/BU8Y0SDRjD6CmyirIQwVI fcRg== X-Gm-Message-State: AOAM5336MaXkTkVNgGHc2ozBtkuka25PQ8R1pNkZ93co/mwpRaqItJF0 0XgFb4ePt08NfHxMsf28x6wPJiUWIR3EioZz X-Google-Smtp-Source: ABdhPJxtxZr63ol1xIOg6u5pvfrv2HJwBW5xoYvIe6WxhmJh86JQG1OPCi55FNTFAf7bGfexq2KRdw== X-Received: by 2002:a05:600c:a06:b0:37b:fdd8:4f8 with SMTP id z6-20020a05600c0a0600b0037bfdd804f8mr15523951wmp.41.1647600584151; Fri, 18 Mar 2022 03:49:44 -0700 (PDT) Received: from ?IPv6:2001:8b0:aba:5f3c:ac92:797e:3dcd:ed37? ([2001:8b0:aba:5f3c:ac92:797e:3dcd:ed37]) by smtp.gmail.com with ESMTPSA id g1-20020a1c4e01000000b003899c8053e1sm7969725wmh.41.2022.03.18.03.49.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 03:49:43 -0700 (PDT) Message-ID: <5add1e9d2e60b63604014c0db6b7ecf64d9b1d69.camel@linuxfoundation.org> Subject: Re: [Toaster] [PATCH] toaster: handle changes to "ImagePkgList" event From: Richard Purdie To: "Reyna, David" , toaster@lists.yoctoproject.org Date: Fri, 18 Mar 2022 10:49:41 +0000 In-Reply-To: <20220318104304.18460-1-david.reyna@windriver.com> References: <20220318104304.18460-1-david.reyna@windriver.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 18 Mar 2022 10:49:47 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/toaster/message/5781 On Fri, 2022-03-18 at 03:43 -0700, Reyna, David wrote: > From: David Reyna > > There are several changes to the "ImagePkgList" content to work around: > 1) The key field for the package size ('PKGSIZE') is currently an empty string > 2) The list of files changed from 'FILES_INFO' to 'FILES' > 3) The 'FILES' is now a dictionary in string form > 4) Not all fields are always present for all packages, for example 'LICENSE' and 'SUMMARY' > > [YOCTO #14763] > > Signed-off-by: David Reyna I'm not sure this looks entirely correct to me. FILES is the pre expanded version of the files list so it could contain wildcards and FILES_INFO was meant to be the version where the list of files was expanded out (and may have also been tweaked by other package processing, e.g. creation of debug files). I think the fact that some values are "disappearing" is a sign the overrides change has some impact here which needs to be fixed and this patch is just partially working around it. Cheers, Richard