Re: [PATCH] ipmi:pci: Blacklist a Realtek "IPMI" device

From: Corey Minyard <minyard@acm.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Chris Chiu <chiu@endlessm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Upstreaming Team <linux@endlessm.com>,
	openipmi-developer@lists.sourceforge.net,
	Corey Minyard <cminyard@mvista.com>
Subject: Re: [PATCH] ipmi:pci: Blacklist a Realtek "IPMI" device
Date: Mon, 26 Feb 2018 08:48:07 -0600	[thread overview]
Message-ID: <5ae019f4-a997-fe96-4f16-c12893b816cf@acm.org> (raw)
In-Reply-To: <CAHp75Vd8mEZRTVYiR5Nz4X8HM8VUHArc5C1SyfN4K8c-Y9+taw@mail.gmail.com>

On 02/26/2018 08:34 AM, Andy Shevchenko wrote:
> On Mon, Feb 26, 2018 at 4:50 AM,  <minyard@acm.org> wrote:
>
>> Realtek has some sort of "Virtual" IPMI device on the PCI bus as a
>> KCS controller, but whatever it is, it's not one.  Ignore it if seen.
>> +static struct pci_device_id ipmi_pci_blacklist[] = {
>> +       /*
>> +        * This is a "Virtual IPMI device", whatever that is.  It appears
>> +        * as a KCS device by the class, but it is not one.
>> +        */
>> +       { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x816c) },
>> +       { 0, }
> { PCI_VDEVICE(REALTEK, 0x816c) },
> { }
>
> ?

That's better, thanks.

-corey

>
>> +};
>> +       if (pci_match_id(ipmi_pci_blacklist, pdev))
>> +               return -ENODEV;
>