From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Lagerwall Subject: Re: [PATCH v3 5/9] livepatch: Move code from prepare_payload to own routine Date: Fri, 19 Aug 2016 10:37:41 +0100 Message-ID: <5ae25e7b-2220-1653-24db-8924cc976238@citrix.com> References: <1471211546-2235-1-git-send-email-konrad.wilk@oracle.com> <1471211546-2235-6-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bagFF-0005UF-K7 for xen-devel@lists.xenproject.org; Fri, 19 Aug 2016 09:37:45 +0000 In-Reply-To: <1471211546-2235-6-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gMDgvMTQvMjAxNiAxMDo1MiBQTSwgS29ucmFkIFJ6ZXN6dXRlayBXaWxrIHdyb3RlOgo+IFNw ZWNpZmljYWxseSB0aGUgY29kZSB0aGF0IGlzIGxvb2tpbmcgdXAgZi0+b2xkX2FkZHIgLSB3aGlj aAo+IGNhbiBiZSBpbiBpdHMgb3duIHJvdXRpbmUgaW5zdGVhZCBvZiBoYXZpbmcgaXQgcGFydCBv ZiBwcmVwYXJlX3BheWxvYWQuCj4KPiBObyBmdW5jdGlvbmFsIGNoYW5nZS4KPgo+IFNpZ25lZC1v ZmYtYnk6IEtvbnJhZCBSemVzenV0ZWsgV2lsayA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT4KPgo+ IC0tLQo+IENjOiBSb3NzIExhZ2Vyd2FsbCA8cm9zcy5sYWdlcndhbGxAY2l0cml4LmNvbT4KPgo+ IHYzOiBGaXJzdCBzdWJtaXNzaW9uLgo+IC0tLQo+ICB4ZW4vY29tbW9uL2xpdmVwYXRjaC5jIHwg NDMgKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEveGVuL2NvbW1vbi9saXZlcGF0Y2guYyBiL3hlbi9jb21tb24vbGl2ZXBhdGNoLmMKPiBpbmRl eCAyOGE0MDBmLi5jYmZlYWMxIDEwMDY0NAo+IC0tLSBhL3hlbi9jb21tb24vbGl2ZXBhdGNoLmMK PiArKysgYi94ZW4vY29tbW9uL2xpdmVwYXRjaC5jCj4gQEAgLTIzMiw2ICsyMzIsMjkgQEAgc3Rh dGljIGNvbnN0IGNoYXIgKmxpdmVwYXRjaF9zeW1ib2xzX2xvb2t1cCh1bnNpZ25lZCBsb25nIGFk ZHIsCj4gICAgICByZXR1cm4gbjsKPiAgfQo+Cj4gK3N0YXRpYyBpbnQgbG9va3VwX3N5bWJvbChz dHJ1Y3QgbGl2ZXBhdGNoX2Z1bmMgKmYsIHN0cnVjdCBsaXZlcGF0Y2hfZWxmICplbGYpCj4gK3sK PiArICAgIGlmICggZi0+b2xkX2FkZHIgKQo+ICsgICAgICAgIHJldHVybiAwOwo+ICsKPiArICAg IC8qIExvb2t1cCBmdW5jdGlvbidzIG9sZCBhZGRyZXNzIGlmIG5vdCBhbHJlYWR5IHJlc29sdmVk LiAqLwoKVGhpcyBjb21tZW50IG5lZWRzIHRvIG1vdmUgZnVydGhlciB1cCBmb3IgaXQgdG8gYmUg Y29ycmVjdCwgc2luY2UgYXQgCnRoaXMgcG9pbnQgd2Uga25vdyB0aGF0IGl0IGlzIG5vdCB5ZXQg cmVzb2x2ZWQuIEhvdyBhYm91dCBwdXR0aW5nIGl0IGF0IAp0aGUgdG9wIG9mIHRoZSBmdW5jdGlv bj8KCj4gKyAgICBmLT5vbGRfYWRkciA9ICh2b2lkICopc3ltYm9sc19sb29rdXBfYnlfbmFtZShm LT5uYW1lKTsKPiArICAgIGlmICggIWYtPm9sZF9hZGRyICkKPiArICAgIHsKPiArICAgICAgICBm LT5vbGRfYWRkciA9ICh2b2lkICopbGl2ZXBhdGNoX3N5bWJvbHNfbG9va3VwX2J5X25hbWUoZi0+ bmFtZSk7Cj4gKyAgICAgICAgaWYgKCAhZi0+b2xkX2FkZHIgKQo+ICsgICAgICAgIHsKPiArICAg ICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSLCBMSVZFUEFUQ0ggIiVzOiBDb3VsZCBub3QgcmVz b2x2ZSBvbGQgYWRkcmVzcyBvZiAlc1xuIiwKPiArICAgICAgICAgICAgICAgICAgICBlbGYtPm5h bWUsIGYtPm5hbWUpOwo+ICsgICAgICAgICAgICByZXR1cm4gLUVOT0VOVDsKPiArICAgICAgICB9 Cj4gKyAgICB9Cj4gKyAgICBkcHJpbnRrKFhFTkxPR19ERUJVRywgTElWRVBBVENIICIlczogUmVz b2x2ZWQgb2xkIGFkZHJlc3MgJXMgPT4gJXBcbiIsCj4gKyAgICAgICAgICAgIGVsZi0+bmFtZSwg Zi0+bmFtZSwgZi0+b2xkX2FkZHIpOwo+ICsKPiArICAgIHJldHVybiAwOwo+ICt9Cj4gKwo+ICBz dGF0aWMgc3RydWN0IHBheWxvYWQgKmZpbmRfcGF5bG9hZChjb25zdCBjaGFyICpuYW1lKQo+ICB7 Cj4gICAgICBzdHJ1Y3QgcGF5bG9hZCAqZGF0YSwgKmZvdW5kID0gTlVMTDsKPiBAQCAtNTEwLDIz ICs1MzMsOSBAQCBzdGF0aWMgaW50IHByZXBhcmVfcGF5bG9hZChzdHJ1Y3QgcGF5bG9hZCAqcGF5 bG9hZCwKPiAgICAgICAgICBpZiAoIHJjICkKPiAgICAgICAgICAgICAgcmV0dXJuIHJjOwo+Cj4g LSAgICAgICAgLyogTG9va3VwIGZ1bmN0aW9uJ3Mgb2xkIGFkZHJlc3MgaWYgbm90IGFscmVhZHkg cmVzb2x2ZWQuICovCj4gLSAgICAgICAgaWYgKCAhZi0+b2xkX2FkZHIgKQo+IC0gICAgICAgIHsK PiAtICAgICAgICAgICAgZi0+b2xkX2FkZHIgPSAodm9pZCAqKXN5bWJvbHNfbG9va3VwX2J5X25h bWUoZi0+bmFtZSk7Cj4gLSAgICAgICAgICAgIGlmICggIWYtPm9sZF9hZGRyICkKPiAtICAgICAg ICAgICAgewo+IC0gICAgICAgICAgICAgICAgZi0+b2xkX2FkZHIgPSAodm9pZCAqKWxpdmVwYXRj aF9zeW1ib2xzX2xvb2t1cF9ieV9uYW1lKGYtPm5hbWUpOwo+IC0gICAgICAgICAgICAgICAgaWYg KCAhZi0+b2xkX2FkZHIgKQo+IC0gICAgICAgICAgICAgICAgewo+IC0gICAgICAgICAgICAgICAg ICAgIGRwcmludGsoWEVOTE9HX0VSUiwgTElWRVBBVENIICIlczogQ291bGQgbm90IHJlc29sdmUg b2xkIGFkZHJlc3Mgb2YgJXNcbiIsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBlbGYt Pm5hbWUsIGYtPm5hbWUpOwo+IC0gICAgICAgICAgICAgICAgICAgIHJldHVybiAtRU5PRU5UOwo+ IC0gICAgICAgICAgICAgICAgfQo+IC0gICAgICAgICAgICB9Cj4gLSAgICAgICAgICAgIGRwcmlu dGsoWEVOTE9HX0RFQlVHLCBMSVZFUEFUQ0ggIiVzOiBSZXNvbHZlZCBvbGQgYWRkcmVzcyAlcyA9 PiAlcFxuIiwKPiAtICAgICAgICAgICAgICAgICAgICBlbGYtPm5hbWUsIGYtPm5hbWUsIGYtPm9s ZF9hZGRyKTsKPiAtICAgICAgICB9Cj4gKyAgICAgICAgcmMgPSBsb29rdXBfc3ltYm9sKGYsIGVs Zik7Cj4gKyAgICAgICAgaWYgKCByYyApCj4gKyAgICAgICAgICAgIHJldHVybiByYzsKCkNhbiB5 b3UgZ2l2ZSB0aGUgZnVuY3Rpb24gYSBsZXNzIGdlbmVyaWMgbmFtZT8gRS5nLiByZXNvbHZlX29s ZF9hZGRyZXNzCgotLSAKUm9zcyBMYWdlcndhbGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxp c3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=