From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56978C433F5 for ; Tue, 9 Nov 2021 13:26:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F06761175 for ; Tue, 9 Nov 2021 13:26:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235164AbhKIN3m (ORCPT ); Tue, 9 Nov 2021 08:29:42 -0500 Received: from foss.arm.com ([217.140.110.172]:33872 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230190AbhKIN3j (ORCPT ); Tue, 9 Nov 2021 08:29:39 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A784D2B; Tue, 9 Nov 2021 05:26:53 -0800 (PST) Received: from [10.57.46.99] (unknown [10.57.46.99]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F3D253F70D; Tue, 9 Nov 2021 05:26:50 -0800 (PST) Subject: Re: [PATCH 5/5] perf arm-spe: Snapshot mode test To: James Clark , Leo Yan Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org References: <20210916154635.1525-1-german.gomez@arm.com> <20210916154635.1525-5-german.gomez@arm.com> <20211020131339.GG49614@leoy-ThinkPad-X240s> From: German Gomez Message-ID: <5af799c3-5f39-9792-225e-1957c3da7b07@arm.com> Date: Tue, 9 Nov 2021 13:26:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, Leo, Thank you for testing the patch. On 02/11/2021 15:37, James Clark wrote: > [...] > Ok, it seems like I was relying on buggy dash behaviour for my original change. Even with this: > > if [[ "$1" == "int" ]]; then > kill -SIGINT $$ > fi > if [[ "$1" == "term" ]]; then > kill -SIGTERM $$ > fi > > it still doesn't allow you to break out of running it in a while loop. This is only because of > the exit code, rather than any kind of signal propagation. Actually it's possible to stop it > with Ctrl-\ rather than Ctrl-C, and that doesn't require any extra handling in the script. > > For that reason I'm happy to go with Leo's original suggestion when I first added this which was > to not have any extra kill at all. Thanks for debugging the issue, I think I will consider this fix in the re-submission. Thanks, German > > Another fix could be this, but I'm not too keen on it because I don't think any other tests behave > like this: > > [ "$1" = "int" ] || exit 1 > [ "$1" = "term" ] || exit 1 > >>>> + exit $glb_err >>>> +} >>>> + >>>> +trap cleanup_files exit term int >>>> + >>>> +arm_spe_report() { >>>> + if [ $2 != 0 ]; then >>>> + echo "$1: FAIL" >>>> + glb_err=$2 >>>> + else >>>> + echo "$1: PASS" >>>> + fi >>>> +} >>>> + >>>> +perf_script_samples() { >>>> + echo "Looking at perf.data file for dumping samples:" >>>> + >>>> + # from arm-spe.c/arm_spe_synth_events() >>>> + events="(ld1-miss|ld1-access|llc-miss|lld-access|tlb-miss|tlb-access|branch-miss|remote-access|memory)" >>>> + >>>> + # Below is an example of the samples dumping: >>>> + # dd 3048 [002] 1 l1d-access: ffffaa64999c __GI___libc_write+0x3c (/lib/aarch64-linux-gnu/libc-2.27.so) >>>> + # dd 3048 [002] 1 tlb-access: ffffaa64999c __GI___libc_write+0x3c (/lib/aarch64-linux-gnu/libc-2.27.so) >>>> + # dd 3048 [002] 1 memory: ffffaa64999c __GI___libc_write+0x3c (/lib/aarch64-linux-gnu/libc-2.27.so) >>>> + perf script -F,-time -i ${perfdata} 2>&1 | \ >>>> + egrep " +$1 +[0-9]+ .* +${events}:(.*:)? +" > /dev/null 2>&1 >>>> +} >>>> + >>>> +perf_report_samples() { >>>> + echo "Looking at perf.data file for reporting samples:" >>>> + >>>> + # Below is an example of the samples reporting: >>>> + # 73.04% 73.04% dd libc-2.27.so [.] _dl_addr >>>> + # 7.71% 7.71% dd libc-2.27.so [.] getenv >>>> + # 2.59% 2.59% dd ld-2.27.so [.] strcmp >>>> + perf report --stdio -i ${perfdata} 2>&1 | \ >>>> + egrep " +[0-9]+\.[0-9]+% +[0-9]+\.[0-9]+% +$1 " > /dev/null 2>&1 >>>> +} >>>> + >>>> +arm_spe_snapshot_test() { >>>> + echo "Recording trace with snapshot mode $perfdata" >>>> + perf record -o ${perfdata} -e arm_spe// -S \ >>>> + -- dd if=/dev/zero of=/dev/null > /dev/null 2>&1 & >>>> + PERFPID=$! >>>> + >>>> + # Wait for perf program >>>> + sleep 1 >>>> + >>>> + # Send signal to snapshot trace data >>>> + kill -USR2 $PERFPID >>>> + >>>> + # Stop perf program >>>> + kill $PERFPID >>>> + wait $PERFPID >>>> + >>>> + perf_script_samples dd && >>>> + perf_report_samples dd >>>> + >>>> + err=$? >>>> + arm_spe_report "SPE snapshot testing" $err >>>> +} >>>> + >>>> +arm_spe_snapshot_test >>>> +exit $glb_err >>>> \ No newline at end of file >>>> -- >>>> 2.17.1 >>>> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89472C433EF for ; Tue, 9 Nov 2021 13:28:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B2D16117A for ; Tue, 9 Nov 2021 13:28:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4B2D16117A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=gLVwwexz8NpBrIYYiCsz9nGgmZ9wqrbQHJQ+z0vX4kA=; b=axM5esZTEGnygw/+VXkKDzVvYz 5J4rLz14CfJEYTlYC0C5ck+skbGL/tXL87QZKvsC7qaFezUFje5OqWwHa7gLZYB6iEqM2+TdYKIM+ oTCtlf2wWAxlqLXDf9Ej3QwOZ7W+UIxA30Ed+sQL2xzty8GtI/+3UdrjRHxBmbfu+B+IE6+pnRRc8 8Bog5JtvDuT7Ozj+0p/XGcI9qt6RICqn0z6Qs2XLZ7iSx8ZxmaJWiz7tzTX5eisTklzj1cBzs/nSl o+SRJfj5v6fgMV6b+3bnmVDMmiI3y9nsBgzOAWRL/XouWKbcjSSoT5p0xTcbsyXTIozvr1jFykkmF tkh7EgbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkR9P-002K0n-Qv; Tue, 09 Nov 2021 13:26:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkR9M-002K06-7M for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 13:26:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A784D2B; Tue, 9 Nov 2021 05:26:53 -0800 (PST) Received: from [10.57.46.99] (unknown [10.57.46.99]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F3D253F70D; Tue, 9 Nov 2021 05:26:50 -0800 (PST) Subject: Re: [PATCH 5/5] perf arm-spe: Snapshot mode test To: James Clark , Leo Yan Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org References: <20210916154635.1525-1-german.gomez@arm.com> <20210916154635.1525-5-german.gomez@arm.com> <20211020131339.GG49614@leoy-ThinkPad-X240s> From: German Gomez Message-ID: <5af799c3-5f39-9792-225e-1957c3da7b07@arm.com> Date: Tue, 9 Nov 2021 13:26:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211109_052656_395973_09E2D52F X-CRM114-Status: GOOD ( 21.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James, Leo, Thank you for testing the patch. On 02/11/2021 15:37, James Clark wrote: > [...] > Ok, it seems like I was relying on buggy dash behaviour for my original change. Even with this: > > if [[ "$1" == "int" ]]; then > kill -SIGINT $$ > fi > if [[ "$1" == "term" ]]; then > kill -SIGTERM $$ > fi > > it still doesn't allow you to break out of running it in a while loop. This is only because of > the exit code, rather than any kind of signal propagation. Actually it's possible to stop it > with Ctrl-\ rather than Ctrl-C, and that doesn't require any extra handling in the script. > > For that reason I'm happy to go with Leo's original suggestion when I first added this which was > to not have any extra kill at all. Thanks for debugging the issue, I think I will consider this fix in the re-submission. Thanks, German > > Another fix could be this, but I'm not too keen on it because I don't think any other tests behave > like this: > > [ "$1" = "int" ] || exit 1 > [ "$1" = "term" ] || exit 1 > >>>> + exit $glb_err >>>> +} >>>> + >>>> +trap cleanup_files exit term int >>>> + >>>> +arm_spe_report() { >>>> + if [ $2 != 0 ]; then >>>> + echo "$1: FAIL" >>>> + glb_err=$2 >>>> + else >>>> + echo "$1: PASS" >>>> + fi >>>> +} >>>> + >>>> +perf_script_samples() { >>>> + echo "Looking at perf.data file for dumping samples:" >>>> + >>>> + # from arm-spe.c/arm_spe_synth_events() >>>> + events="(ld1-miss|ld1-access|llc-miss|lld-access|tlb-miss|tlb-access|branch-miss|remote-access|memory)" >>>> + >>>> + # Below is an example of the samples dumping: >>>> + # dd 3048 [002] 1 l1d-access: ffffaa64999c __GI___libc_write+0x3c (/lib/aarch64-linux-gnu/libc-2.27.so) >>>> + # dd 3048 [002] 1 tlb-access: ffffaa64999c __GI___libc_write+0x3c (/lib/aarch64-linux-gnu/libc-2.27.so) >>>> + # dd 3048 [002] 1 memory: ffffaa64999c __GI___libc_write+0x3c (/lib/aarch64-linux-gnu/libc-2.27.so) >>>> + perf script -F,-time -i ${perfdata} 2>&1 | \ >>>> + egrep " +$1 +[0-9]+ .* +${events}:(.*:)? +" > /dev/null 2>&1 >>>> +} >>>> + >>>> +perf_report_samples() { >>>> + echo "Looking at perf.data file for reporting samples:" >>>> + >>>> + # Below is an example of the samples reporting: >>>> + # 73.04% 73.04% dd libc-2.27.so [.] _dl_addr >>>> + # 7.71% 7.71% dd libc-2.27.so [.] getenv >>>> + # 2.59% 2.59% dd ld-2.27.so [.] strcmp >>>> + perf report --stdio -i ${perfdata} 2>&1 | \ >>>> + egrep " +[0-9]+\.[0-9]+% +[0-9]+\.[0-9]+% +$1 " > /dev/null 2>&1 >>>> +} >>>> + >>>> +arm_spe_snapshot_test() { >>>> + echo "Recording trace with snapshot mode $perfdata" >>>> + perf record -o ${perfdata} -e arm_spe// -S \ >>>> + -- dd if=/dev/zero of=/dev/null > /dev/null 2>&1 & >>>> + PERFPID=$! >>>> + >>>> + # Wait for perf program >>>> + sleep 1 >>>> + >>>> + # Send signal to snapshot trace data >>>> + kill -USR2 $PERFPID >>>> + >>>> + # Stop perf program >>>> + kill $PERFPID >>>> + wait $PERFPID >>>> + >>>> + perf_script_samples dd && >>>> + perf_report_samples dd >>>> + >>>> + err=$? >>>> + arm_spe_report "SPE snapshot testing" $err >>>> +} >>>> + >>>> +arm_spe_snapshot_test >>>> +exit $glb_err >>>> \ No newline at end of file >>>> -- >>>> 2.17.1 >>>> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel