From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E9C3C433DB for ; Thu, 25 Mar 2021 10:15:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0013661A1F for ; Thu, 25 Mar 2021 10:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229519AbhCYKOc (ORCPT ); Thu, 25 Mar 2021 06:14:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57366 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbhCYKOL (ORCPT ); Thu, 25 Mar 2021 06:14:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616667250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5kFVmifOqpEQKi5+QdYUnPBCpq2/U9G4tu0rz+JAWHU=; b=VDWqQPS/aA+RZQIvZsyh6kNaOM/apzbBS7KNDGT8WxiUnZdolOwTQ6xsSp6Qo2uDPZJVO4 rwz4jLQpTPjSTfr0qKLLUP9yVXeTHm1jji4uEWTlO80hsYzJ/amBgneLGtq65bBKI7nCp2 nKbh/SzVaKNGRpqSNzJju4ar98RTK9A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-164-pnLX6_OEOCS29hZdy1WTPw-1; Thu, 25 Mar 2021 06:14:06 -0400 X-MC-Unique: pnLX6_OEOCS29hZdy1WTPw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BA74B101F7AF; Thu, 25 Mar 2021 10:14:04 +0000 (UTC) Received: from [10.36.115.72] (ovpn-115-72.ams2.redhat.com [10.36.115.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id 797F417264; Thu, 25 Mar 2021 10:13:54 +0000 (UTC) Subject: Re: [PATCH 1/8] mm: cma: introduce cma_release_nowait() To: Michal Hocko , Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Roman Gushchin , Shakeel Butt , Oscar Salvador , Muchun Song , David Rientjes , Miaohe Lin , Peter Zijlstra , Matthew Wilcox , HORIGUCHI NAOYA , "Aneesh Kumar K . V" , Waiman Long , Peter Xu , Mina Almasry , Hillf Danton , Andrew Morton References: <20210325002835.216118-1-mike.kravetz@oracle.com> <20210325002835.216118-2-mike.kravetz@oracle.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <5afbce32-bb3a-9056-9f61-f26b78ad5f54@redhat.com> Date: Thu, 25 Mar 2021 11:13:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.03.21 11:11, Michal Hocko wrote: > On Thu 25-03-21 10:45:19, Michal Hocko wrote: >> On Wed 24-03-21 17:28:28, Mike Kravetz wrote: >> [...] >>> phys_addr_t cma_get_base(const struct cma *cma) >>> { >>> return PFN_PHYS(cma->base_pfn); >>> @@ -146,6 +155,10 @@ static int __init cma_init_reserved_areas(void) >>> for (i = 0; i < cma_area_count; i++) >>> cma_activate_area(&cma_areas[i]); >>> >>> + cma_release_wq = create_workqueue("cma_release"); >> >> Considering the workqueue is used to free up memory it should likely be >> WQ_MEM_RECLAIM to prevent from long stalls when WQs are overloaded. >> >> I cannot judge the CMA parts from a very quick glance this looks >> reasonably. > > I have overlooked that > +static void cma_clear_bitmap_fn(struct work_struct *work) > +{ > + struct cma_clear_bitmap_work *w; > + > + w = container_of(work, struct cma_clear_bitmap_work, work); > + > + cma_clear_bitmap(w->cma, w->pfn, w->count); > + > + __free_page(pfn_to_page(w->pfn)); > +} > > should be doing free_contig_range with w->count target. > Then the name "cma_clear_bitmap_fn" is misleading. -- Thanks, David / dhildenb