From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH RFC 05/20] libxc/xc_sr: factor out filter_pages() Date: Tue, 28 Mar 2017 20:27:48 +0100 Message-ID: <5b010d08-7e47-0e96-6711-c405030555cc@citrix.com> References: <1490605592-12189-1-git-send-email-jtotto@uwaterloo.ca> <1490605592-12189-6-git-send-email-jtotto@uwaterloo.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cswmV-00061d-PV for xen-devel@lists.xenproject.org; Tue, 28 Mar 2017 19:27:51 +0000 In-Reply-To: <1490605592-12189-6-git-send-email-jtotto@uwaterloo.ca> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Joshua Otto , xen-devel@lists.xenproject.org Cc: ian.jackson@eu.citrix.com, hjarmstr@uwaterloo.ca, wei.liu2@citrix.com, czylin@uwaterloo.ca, imhy.yang@gmail.com List-Id: xen-devel@lists.xenproject.org T24gMjcvMDMvMTcgMTA6MDYsIEpvc2h1YSBPdHRvIHdyb3RlOgo+IGRpZmYgLS1naXQgYS90b29s cy9saWJ4Yy94Y19zcl9yZXN0b3JlLmMgYi90b29scy9saWJ4Yy94Y19zcl9yZXN0b3JlLmMKPiBp bmRleCA0ODFhOTA0Li44NTc0ZWU4IDEwMDY0NAo+IC0tLSBhL3Rvb2xzL2xpYnhjL3hjX3NyX3Jl c3RvcmUuYwo+ICsrKyBiL3Rvb2xzL2xpYnhjL3hjX3NyX3Jlc3RvcmUuYwo+IEBAIC0xOTQsNiAr MTk0LDY4IEBAIGludCBwb3B1bGF0ZV9wZm5zKHN0cnVjdCB4Y19zcl9jb250ZXh0ICpjdHgsIHVu c2lnbmVkIGNvdW50LAo+ICAgICAgcmV0dXJuIHJjOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBz ZXRfcGFnZV90eXBlcyhzdHJ1Y3QgeGNfc3JfY29udGV4dCAqY3R4LCB1bnNpZ25lZCBjb3VudCwK PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgeGVuX3Bmbl90ICpwZm5zLCB1aW50MzJfdCAq dHlwZXMpCj4gK3sKPiArICAgIHVuc2lnbmVkIGk7CgpQbGVhc2UgdXNlIHVuc2lnbmVkIGludCBy YXRoZXIgdGhhbiBqdXN0ICJ1bnNpZ25lZCIgdGhyb3VnaG91dC4KCj4gKwo+ICsgICAgZm9yICgg aSA9IDA7IGkgPCBjb3VudDsgKytpICkKPiArICAgICAgICBjdHgtPnJlc3RvcmUub3BzLnNldF9w YWdlX3R5cGUoY3R4LCBwZm5zW2ldLCB0eXBlc1tpXSk7Cj4gK30KPiArCj4gKy8qCj4gKyAqIEdp dmVuIGNvdW50IHBmbnMgYW5kIHRoZWlyIHR5cGVzLCBhbGxvY2F0ZSBhbmQgZmlsbCBpbiBidWZm ZXIgYnBmbnMgd2l0aCBvbmx5Cj4gKyAqIHRob3NlIHBmbnMgdGhhdCBhcmUgJ2JhY2tlZCcgYnkg cmVhbCBwYWdlIGRhdGEgdGhhdCBuZWVkcyB0byBiZSBtaWdyYXRlZC4KPiArICogVGhlIGNhbGxl ciBtdXN0IGxhdGVyIGZyZWUoKSAqYnBmbnMuCj4gKyAqCj4gKyAqIFJldHVybnMgMCBvbiBzdWNj ZXNzIGFuZCBub24tMCBvbiBmYWlsdXJlLiAgKmJwZm5zIGNhbiBiZSBmcmVlKCllZCBldmVuIGFm dGVyCj4gKyAqIGZhaWx1cmUuCj4gKyAqLwo+ICtzdGF0aWMgaW50IGZpbHRlcl9wYWdlcyhzdHJ1 Y3QgeGNfc3JfY29udGV4dCAqY3R4LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25l ZCBjb3VudCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgeGVuX3Bmbl90ICpwZm5zLAo+ICsg ICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCAqdHlwZXMsCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgIC8qIE9VVCAqLyB1bnNpZ25lZCAqbnJfcGFnZXMsCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgIC8qIE9VVCAqLyB4ZW5fcGZuX3QgKipicGZucykKPiArewo+ICsgICAgeGNfaW50 ZXJmYWNlICp4Y2ggPSBjdHgtPnhjaDsKClBvaW50ZXJzIHRvIGFycmF5cyBhcmUgdmVyeSBlYXN5 IHRvIGdldCB3cm9uZyBpbiBDLiAgVGhpcyBjb2RlIHdpbGwgYmUKbGVzcyBlcnJvciBpZiB5b3Ug dXNlCgp4ZW5fcGZuX3QgKl9wZm5zOyAgKHZhcmlhYmxlIG5hbWUgc3ViamVjdCB0byBpbXByb3Zl bWVudCkKCj4gKyAgICB1bnNpZ25lZCBpOwo+ICsKPiArICAgICpucl9wYWdlcyA9IDA7Cj4gKyAg ICAqYnBmbnMgPSBtYWxsb2MoY291bnQgKiBzaXplb2YoKmJwZm5zKSk7CgpfcGZucyA9ICpiZm5z ID0gbWFsbG9jKC4uLikuCgpUaGVuIHVzZSBfcGZucyBpbiBwbGFjZSBvZiAoKmJwZm5zKSBldmVy eXdoZXJlIGVsc2UuCgpIb3dldmVyLCAgeW91ciBzaXplb2YgaGFzIHRoZSB3cm9uZyBpbmRpcmVj dGlvbi4gIEl0IHdvcmtzIG9uIHg4NgpiZWNhdXNlIHhlbl9wZm5fdCBpcyB0aGUgc2FtZSBzaXpl IGFzIGEgcG9pbnRlciwgYnV0IGl0IHdpbGwgYmxvdyB1cCBvbgozMmJpdCBBUk0sIHdoZXJlIGEg cG9pbnRlciBpcyA0IGJ5dGVzIGJ1dCB4ZW5fcGZuX3QgaXMgOCBieXRlcy4KCj4gKyAgICBpZiAo ICEoKmJwZm5zKSApCj4gKyAgICB7Cj4gKyAgICAgICAgRVJST1IoIkZhaWxlZCB0byBhbGxvY2F0 ZSAlenUgYnl0ZXMgdG8gcHJvY2VzcyBwYWdlIGRhdGEiLAo+ICsgICAgICAgICAgICAgIGNvdW50 ICogKHNpemVvZigqYnBmbnMpKSk7Cj4gKyAgICAgICAgcmV0dXJuIC0xOwo+ICsgICAgfQo+ICsK PiArICAgIGZvciAoIGkgPSAwOyBpIDwgY291bnQ7ICsraSApCj4gKyAgICB7Cj4gKyAgICAgICAg c3dpdGNoICggdHlwZXNbaV0gKQo+ICsgICAgICAgIHsKPiArICAgICAgICBjYXNlIFhFTl9ET01D VExfUEZJTkZPX05PVEFCOgo+ICsKPiArICAgICAgICBjYXNlIFhFTl9ET01DVExfUEZJTkZPX0wx VEFCOgo+ICsgICAgICAgIGNhc2UgWEVOX0RPTUNUTF9QRklORk9fTDFUQUIgfCBYRU5fRE9NQ1RM X1BGSU5GT19MUElOVEFCOgo+ICsKPiArICAgICAgICBjYXNlIFhFTl9ET01DVExfUEZJTkZPX0wy VEFCOgo+ICsgICAgICAgIGNhc2UgWEVOX0RPTUNUTF9QRklORk9fTDJUQUIgfCBYRU5fRE9NQ1RM X1BGSU5GT19MUElOVEFCOgo+ICsKPiArICAgICAgICBjYXNlIFhFTl9ET01DVExfUEZJTkZPX0wz VEFCOgo+ICsgICAgICAgIGNhc2UgWEVOX0RPTUNUTF9QRklORk9fTDNUQUIgfCBYRU5fRE9NQ1RM X1BGSU5GT19MUElOVEFCOgo+ICsKPiArICAgICAgICBjYXNlIFhFTl9ET01DVExfUEZJTkZPX0w0 VEFCOgo+ICsgICAgICAgIGNhc2UgWEVOX0RPTUNUTF9QRklORk9fTDRUQUIgfCBYRU5fRE9NQ1RM X1BGSU5GT19MUElOVEFCOgo+ICsKPiArICAgICAgICAgICAgKCpicGZucylbKCpucl9wYWdlcykr K10gPSBwZm5zW2ldOwo+ICsgICAgICAgICAgICBicmVhazsKPiArICAgICAgICB9Cj4gKyAgICB9 Cj4gKwo+ICsgICAgcmV0dXJuIDA7Cj4gK30KPiArCj4gIC8qCj4gICAqIEdpdmVuIGEgbGlzdCBv ZiBwZm5zLCB0aGVpciB0eXBlcywgYW5kIGEgYmxvY2sgb2YgcGFnZSBkYXRhIGZyb20gdGhlCj4g ICAqIHN0cmVhbSwgcG9wdWxhdGUgYW5kIHJlY29yZCB0aGVpciB0eXBlcywgbWFwIHRoZSByZWxl dmFudCBzdWJzZXQgYW5kIGNvcHkKPiBAQCAtMjAzLDcgKzI2NSw3IEBAIHN0YXRpYyBpbnQgcHJv Y2Vzc19wYWdlX2RhdGEoc3RydWN0IHhjX3NyX2NvbnRleHQgKmN0eCwgdW5zaWduZWQgY291bnQs Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgeGVuX3Bmbl90ICpwZm5zLCB1aW50MzJf dCAqdHlwZXMsIHZvaWQgKnBhZ2VfZGF0YSkKPiAgewo+ICAgICAgeGNfaW50ZXJmYWNlICp4Y2gg PSBjdHgtPnhjaDsKPiAtICAgIHhlbl9wZm5fdCAqbWZucyA9IG1hbGxvYyhjb3VudCAqIHNpemVv ZigqbWZucykpOwo+ICsgICAgeGVuX3Bmbl90ICptZm5zID0gTlVMTDsKClRoaXMgc2hvd3MgYSBu YW1pbmcgYnVnLCB3aGljaCBpcyBteSBmYXVsdC4gIFRoaXMgc2hvdWxkIGJlIG5hbWVkIGdmbnMs Cm5vdCBtZm5zLiAgKEl0IGluaGVyaXRzIGl0cyBuYW1lIGZyb20gdGhlIGxlZ2FjeSBtaWdyYXRp b24gY29kZSwgYnV0CnRoYXQgd2FzIGFsc28gd3JvbmcuKQoKUGxlYXNlIGNvcnJlY3QgaXQsIGVp dGhlciBpbiB0aGlzIHBhdGNoIG9yIGFub3RoZXI7IHRoZSBtZW1vcnkKbWFuYWdlbWVudCB0ZXJt cyBhcmUgaGFyZCBlbm91Z2gsIGV2ZW4gd2hlbiBhbGwgdGhlIGNvZGUgaXMgY29ycmVjdC4KCn5B bmRyZXcKCj4gICAgICBpbnQgKm1hcF9lcnJzID0gbWFsbG9jKGNvdW50ICogc2l6ZW9mKCptYXBf ZXJycykpOwo+ICAgICAgaW50IHJjOwo+ICAgICAgdm9pZCAqbWFwcGluZyA9IE5VTEwsICpndWVz dF9wYWdlID0gTlVMTDsKPiBAQCAtMjExLDExICsyNzMsMTEgQEAgc3RhdGljIGludCBwcm9jZXNz X3BhZ2VfZGF0YShzdHJ1Y3QgeGNfc3JfY29udGV4dCAqY3R4LCB1bnNpZ25lZCBjb3VudCwKPiAg ICAgICAgICBqLCAgICAgICAgIC8qIGogaW5kZXhlcyB0aGUgc3Vic2V0IG9mIHBmbnMgd2UgZGVj aWRlIHRvIG1hcC4gKi8KPiAgICAgICAgICBucl9wYWdlcyA9IDA7Cj4gIAo+IC0gICAgaWYgKCAh bWZucyB8fCAhbWFwX2VycnMgKQo+ICsgICAgaWYgKCAhbWFwX2VycnMgKQo+ICAgICAgewo+ICAg ICAgICAgIHJjID0gLTE7Cj4gICAgICAgICAgRVJST1IoIkZhaWxlZCB0byBhbGxvY2F0ZSAlenUg Ynl0ZXMgdG8gcHJvY2VzcyBwYWdlIGRhdGEiLAo+IC0gICAgICAgICAgICAgIGNvdW50ICogKHNp emVvZigqbWZucykgKyBzaXplb2YoKm1hcF9lcnJzKSkpOwo+ICsgICAgICAgICAgICAgIGNvdW50 ICogc2l6ZW9mKCptYXBfZXJycykpOwo+ICAgICAgICAgIGdvdG8gZXJyOwo+ICAgICAgfQo+ICAK PgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1k ZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54 ZW4ub3JnL3hlbi1kZXZlbAo=