From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHb2t-0002GL-Bq for qemu-devel@nongnu.org; Mon, 27 Jun 2016 14:14:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHb2o-0005Eu-J4 for qemu-devel@nongnu.org; Mon, 27 Jun 2016 14:14:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHb2o-0005Eo-Dg for qemu-devel@nongnu.org; Mon, 27 Jun 2016 14:14:02 -0400 References: <1466777957-5126-1-git-send-email-armbru@redhat.com> <87ziq6bkz2.fsf@oc4731375738.ibm.com> From: Paolo Bonzini Message-ID: <5b090095-a7bb-e076-5a22-2a7dd02b074b@redhat.com> Date: Mon, 27 Jun 2016 20:13:57 +0200 MIME-Version: 1.0 In-Reply-To: <87ziq6bkz2.fsf@oc4731375738.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sascha Silbe , Markus Armbruster , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 27/06/2016 19:27, Sascha Silbe wrote: > Dear Markus, > > Markus Armbruster writes: > >> Some time ago, we discussed rules for headers, and these were >> generally liked: > [...] >> Trouble is we're not exactly close to obeying 2. This series >> demonstrates a possible path towards obeying it: enforce it in "make >> check", except for known-bad headers [PATCH 2]. We start with a large >> list of known-bad headers, then whittle it down. Some sample >> whittling in PATCH 4+5. > [...] > > Does this series depend on any other series that's not in master yet? > > After applying your series on top of f12103af and running "./configure" > in a clean working directory, I get the following errors for "make > check-source": > > $ make check-source > egrep: config-host.h: No such file or directory > egrep: qmp-commands.h: No such file or directory > egrep: qapi-types.h: No such file or directory > egrep: qapi-visit.h: No such file or directory > egrep: qapi-event.h: No such file or directory > egrep: qmp-introspect.h: No such file or directory > egrep: trace/generated-events.h: No such file or directory > egrep: trace/generated-tracers.h: No such file or directory > egrep: trace/generated-tcg-tracers.h: No such file or directory > egrep: trace/generated-helpers-wrappers.h: No such file or directory > egrep: trace/generated-helpers.h: No such file or directory > egrep: tests/test-qapi-types.h: No such file or directory > egrep: tests/test-qapi-visit.h: No such file or directory > egrep: tests/test-qmp-commands.h: No such file or directory > egrep: tests/test-qapi-event.h: No such file or directory > egrep: tests/test-qmp-introspect.h: No such file or directory > GEN aarch64-softmmu/config-devices.mak.tmp > GEN aarch64-softmmu/config-devices.mak > [...] > GEN tests/test-qmp-introspect.h > make: *** No rule to make target `tests/headers/audio/audio.o', needed by `check-headers'. Stop. Hi Sascha, these are all generated headers. In general, "make check" must be run after "make", and I suppose the same holds for "make check-headers". Paolo