From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D7A6C433EF for ; Wed, 1 Dec 2021 12:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349231AbhLAMNN (ORCPT ); Wed, 1 Dec 2021 07:13:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349259AbhLAMMr (ORCPT ); Wed, 1 Dec 2021 07:12:47 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDD06C06175A; Wed, 1 Dec 2021 04:09:26 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 9416B1F458EC DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1638360565; bh=/uidj4k0zJPUmLFptZ47+9Rl9yr9MrmexaB64VMOX64=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Do5rNVUKnh6urPTkrQHXjoKTciTmUYKZR/jbWV5MjPfMvuHvx5HqSoCShqPY7y0/7 4/cOnRnbRfkAQl5dg3O4rcBCTVlEOuOdqO+UzKdr7mPhQEnTQRo+y8HEp/7i5aj8uX gv0jmm+txjQiHqmmLyRIa/7I/k+AQZMsZnxeGdFnTnH/EAbqzrnaR57X/fLoWE/8t1 dWBlumJqHcL+6RqwRZZw595Hr76OCpbPLJQAOVIJzlTWZRh/l3yWVpEbonNg3HT3q3 rGoADhsWdrKribQrR9VHCGtCsdG/jFnMT68WFOQFO6p5S/tmsQEDwReI2IsWjnYTG7 ikfalqTEyb+4g== Subject: Re: [PATCH v11, 09/19] media: mtk-vcodec: Add irq interface for multi hardware To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-10-yunfei.dong@mediatek.com> From: AngeloGioacchino Del Regno Message-ID: <5b09baac-ac73-03be-09c7-47dc8bdd61a9@collabora.com> Date: Wed, 1 Dec 2021 13:09:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211129034201.5767-10-yunfei.dong@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 29/11/21 04:41, Yunfei Dong ha scritto: > Adds irq interface for multi hardware. > > Signed-off-by: Yunfei Dong > --- > .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 33 ++++++++++++++++--- > .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- > .../platform/mtk-vcodec/mtk_vcodec_drv.h | 25 ++++++++++---- > .../platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 4 +-- > .../platform/mtk-vcodec/mtk_vcodec_intr.c | 27 +++++++-------- > .../platform/mtk-vcodec/mtk_vcodec_intr.h | 4 +-- > .../platform/mtk-vcodec/vdec/vdec_h264_if.c | 2 +- > .../mtk-vcodec/vdec/vdec_h264_req_if.c | 2 +- > .../platform/mtk-vcodec/vdec/vdec_vp8_if.c | 2 +- > .../platform/mtk-vcodec/vdec/vdec_vp9_if.c | 2 +- > .../platform/mtk-vcodec/venc/venc_h264_if.c | 2 +- > .../platform/mtk-vcodec/venc/venc_vp8_if.c | 2 +- > 12 files changed, 70 insertions(+), 37 deletions(-) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > index 95fbe9be3f6d..ac279c2a3f8a 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > @@ -52,6 +52,20 @@ static int mtk_vcodec_subdev_device_check(struct mtk_vcodec_dev *vdec_dev) > return 0; > } > > +static int mtk_vcodec_get_hw_count(struct mtk_vcodec_dev *dev) > +{ > + switch (dev->vdec_pdata->hw_arch) { > + case MTK_VDEC_PURE_SINGLE_CORE: > + return MTK_VDEC_ONE_CORE; > + case MTK_VDEC_LAT_SINGLE_CORE: > + return MTK_VDEC_ONE_LAT_ONE_CORE; > + default: > + mtk_v4l2_err("not support hw arch:%d", > + dev->vdec_pdata->hw_arch); There's no need to break this line... also, what about changing the message to "hw arch %d not supported"? Apart from that, Reviewed-by: AngeloGioacchino Del Regno From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9396EC433EF for ; Wed, 1 Dec 2021 12:09:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 133196FA90; Wed, 1 Dec 2021 12:09:28 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB3BA6FA90 for ; Wed, 1 Dec 2021 12:09:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 9416B1F458EC DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1638360565; bh=/uidj4k0zJPUmLFptZ47+9Rl9yr9MrmexaB64VMOX64=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Do5rNVUKnh6urPTkrQHXjoKTciTmUYKZR/jbWV5MjPfMvuHvx5HqSoCShqPY7y0/7 4/cOnRnbRfkAQl5dg3O4rcBCTVlEOuOdqO+UzKdr7mPhQEnTQRo+y8HEp/7i5aj8uX gv0jmm+txjQiHqmmLyRIa/7I/k+AQZMsZnxeGdFnTnH/EAbqzrnaR57X/fLoWE/8t1 dWBlumJqHcL+6RqwRZZw595Hr76OCpbPLJQAOVIJzlTWZRh/l3yWVpEbonNg3HT3q3 rGoADhsWdrKribQrR9VHCGtCsdG/jFnMT68WFOQFO6p5S/tmsQEDwReI2IsWjnYTG7 ikfalqTEyb+4g== Subject: Re: [PATCH v11, 09/19] media: mtk-vcodec: Add irq interface for multi hardware To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-10-yunfei.dong@mediatek.com> From: AngeloGioacchino Del Regno Message-ID: <5b09baac-ac73-03be-09c7-47dc8bdd61a9@collabora.com> Date: Wed, 1 Dec 2021 13:09:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211129034201.5767-10-yunfei.dong@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Irui Wang , Benjamin Gaignard , srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-mediatek@lists.infradead.org, Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Il 29/11/21 04:41, Yunfei Dong ha scritto: > Adds irq interface for multi hardware. > > Signed-off-by: Yunfei Dong > --- > .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 33 ++++++++++++++++--- > .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- > .../platform/mtk-vcodec/mtk_vcodec_drv.h | 25 ++++++++++---- > .../platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 4 +-- > .../platform/mtk-vcodec/mtk_vcodec_intr.c | 27 +++++++-------- > .../platform/mtk-vcodec/mtk_vcodec_intr.h | 4 +-- > .../platform/mtk-vcodec/vdec/vdec_h264_if.c | 2 +- > .../mtk-vcodec/vdec/vdec_h264_req_if.c | 2 +- > .../platform/mtk-vcodec/vdec/vdec_vp8_if.c | 2 +- > .../platform/mtk-vcodec/vdec/vdec_vp9_if.c | 2 +- > .../platform/mtk-vcodec/venc/venc_h264_if.c | 2 +- > .../platform/mtk-vcodec/venc/venc_vp8_if.c | 2 +- > 12 files changed, 70 insertions(+), 37 deletions(-) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > index 95fbe9be3f6d..ac279c2a3f8a 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > @@ -52,6 +52,20 @@ static int mtk_vcodec_subdev_device_check(struct mtk_vcodec_dev *vdec_dev) > return 0; > } > > +static int mtk_vcodec_get_hw_count(struct mtk_vcodec_dev *dev) > +{ > + switch (dev->vdec_pdata->hw_arch) { > + case MTK_VDEC_PURE_SINGLE_CORE: > + return MTK_VDEC_ONE_CORE; > + case MTK_VDEC_LAT_SINGLE_CORE: > + return MTK_VDEC_ONE_LAT_ONE_CORE; > + default: > + mtk_v4l2_err("not support hw arch:%d", > + dev->vdec_pdata->hw_arch); There's no need to break this line... also, what about changing the message to "hw arch %d not supported"? Apart from that, Reviewed-by: AngeloGioacchino Del Regno From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7E8FC433F5 for ; Wed, 1 Dec 2021 12:18:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qUoMvHxOc0VLNXxqqhG0X4kSnrWkZ9Sb3GS2op0ymoU=; b=DdjuGw0PxLjFoi83fAfXfFphhA 83bbi9K1m3Fey7t0cH3mdfWqngdNva3DAJRZOePZ1K0ZAumZMSNVb0TDXA+rUTthUzTe7pSqyXjb+ fapyzsQA1z14XOCGxfWrPBwmGQVSoaKPpp//IVXUz0Bw1X542zZOclg5CbypvyovN7M4r7jIB9nXg DtRIsMa0lbQQM4LH57uito8GkiuZFjpAvOWYe6So0sHbBb6F+RvQjfgE/s6Gb1cfVFtfClbgHper+ NQB4egIPnd0iCWXDVyDNHOIeyfWNPjhANwzzvYkFsQLmvGQ95+3puO+s0W1ZfsxpQO3LUxboNshca dJ3/qLkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msOZA-008P4E-Ng; Wed, 01 Dec 2021 12:18:28 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msOQQ-008LVV-Uf; Wed, 01 Dec 2021 12:09:28 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 9416B1F458EC DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1638360565; bh=/uidj4k0zJPUmLFptZ47+9Rl9yr9MrmexaB64VMOX64=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Do5rNVUKnh6urPTkrQHXjoKTciTmUYKZR/jbWV5MjPfMvuHvx5HqSoCShqPY7y0/7 4/cOnRnbRfkAQl5dg3O4rcBCTVlEOuOdqO+UzKdr7mPhQEnTQRo+y8HEp/7i5aj8uX gv0jmm+txjQiHqmmLyRIa/7I/k+AQZMsZnxeGdFnTnH/EAbqzrnaR57X/fLoWE/8t1 dWBlumJqHcL+6RqwRZZw595Hr76OCpbPLJQAOVIJzlTWZRh/l3yWVpEbonNg3HT3q3 rGoADhsWdrKribQrR9VHCGtCsdG/jFnMT68WFOQFO6p5S/tmsQEDwReI2IsWjnYTG7 ikfalqTEyb+4g== Subject: Re: [PATCH v11, 09/19] media: mtk-vcodec: Add irq interface for multi hardware To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-10-yunfei.dong@mediatek.com> From: AngeloGioacchino Del Regno Message-ID: <5b09baac-ac73-03be-09c7-47dc8bdd61a9@collabora.com> Date: Wed, 1 Dec 2021 13:09:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211129034201.5767-10-yunfei.dong@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_040927_231674_FF507E3F X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 29/11/21 04:41, Yunfei Dong ha scritto: > Adds irq interface for multi hardware. > > Signed-off-by: Yunfei Dong > --- > .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 33 ++++++++++++++++--- > .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- > .../platform/mtk-vcodec/mtk_vcodec_drv.h | 25 ++++++++++---- > .../platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 4 +-- > .../platform/mtk-vcodec/mtk_vcodec_intr.c | 27 +++++++-------- > .../platform/mtk-vcodec/mtk_vcodec_intr.h | 4 +-- > .../platform/mtk-vcodec/vdec/vdec_h264_if.c | 2 +- > .../mtk-vcodec/vdec/vdec_h264_req_if.c | 2 +- > .../platform/mtk-vcodec/vdec/vdec_vp8_if.c | 2 +- > .../platform/mtk-vcodec/vdec/vdec_vp9_if.c | 2 +- > .../platform/mtk-vcodec/venc/venc_h264_if.c | 2 +- > .../platform/mtk-vcodec/venc/venc_vp8_if.c | 2 +- > 12 files changed, 70 insertions(+), 37 deletions(-) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > index 95fbe9be3f6d..ac279c2a3f8a 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > @@ -52,6 +52,20 @@ static int mtk_vcodec_subdev_device_check(struct mtk_vcodec_dev *vdec_dev) > return 0; > } > > +static int mtk_vcodec_get_hw_count(struct mtk_vcodec_dev *dev) > +{ > + switch (dev->vdec_pdata->hw_arch) { > + case MTK_VDEC_PURE_SINGLE_CORE: > + return MTK_VDEC_ONE_CORE; > + case MTK_VDEC_LAT_SINGLE_CORE: > + return MTK_VDEC_ONE_LAT_ONE_CORE; > + default: > + mtk_v4l2_err("not support hw arch:%d", > + dev->vdec_pdata->hw_arch); There's no need to break this line... also, what about changing the message to "hw arch %d not supported"? Apart from that, Reviewed-by: AngeloGioacchino Del Regno _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAEA7C433EF for ; Wed, 1 Dec 2021 12:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g0CnogEszl8IOB3EXHGlceMW4lltKSECxguR9+1GN3g=; b=OBfO8rg5/3sbN9xErj2fPyK1BL KNaOJ+sYjZlMz6PvD5t3hICaUZmckGyWNLZP/0BFO30Wmm8b4BhPW14yeBAr3FLrfODbe/hTa2CjN kQh03l3pyLexlo0x/WyhNylkYnNjNI3rQaIEoFqVGCb8ngX3EgrJzBhDfTgHo50KKRkutE6KqSWvT 0W9o7jdy0U79P+nrK+EFKWQpBFAeXrFNr8tPv2f4Pok2UGB7iQd7ZZMUVOhWuglpwogf69SMx3y6E uogXzzOXraL+VT59recuGBtUKP/XnOgnYC+v1S+wtJAdGaYD+NLmFEzltlrB3yo2H4w8QlaH3nQjM qu9dlF1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msOXu-008OY0-DK; Wed, 01 Dec 2021 12:17:11 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msOQQ-008LVV-Uf; Wed, 01 Dec 2021 12:09:28 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 9416B1F458EC DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1638360565; bh=/uidj4k0zJPUmLFptZ47+9Rl9yr9MrmexaB64VMOX64=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Do5rNVUKnh6urPTkrQHXjoKTciTmUYKZR/jbWV5MjPfMvuHvx5HqSoCShqPY7y0/7 4/cOnRnbRfkAQl5dg3O4rcBCTVlEOuOdqO+UzKdr7mPhQEnTQRo+y8HEp/7i5aj8uX gv0jmm+txjQiHqmmLyRIa/7I/k+AQZMsZnxeGdFnTnH/EAbqzrnaR57X/fLoWE/8t1 dWBlumJqHcL+6RqwRZZw595Hr76OCpbPLJQAOVIJzlTWZRh/l3yWVpEbonNg3HT3q3 rGoADhsWdrKribQrR9VHCGtCsdG/jFnMT68WFOQFO6p5S/tmsQEDwReI2IsWjnYTG7 ikfalqTEyb+4g== Subject: Re: [PATCH v11, 09/19] media: mtk-vcodec: Add irq interface for multi hardware To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20211129034201.5767-1-yunfei.dong@mediatek.com> <20211129034201.5767-10-yunfei.dong@mediatek.com> From: AngeloGioacchino Del Regno Message-ID: <5b09baac-ac73-03be-09c7-47dc8bdd61a9@collabora.com> Date: Wed, 1 Dec 2021 13:09:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211129034201.5767-10-yunfei.dong@mediatek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_040927_231674_FF507E3F X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 29/11/21 04:41, Yunfei Dong ha scritto: > Adds irq interface for multi hardware. > > Signed-off-by: Yunfei Dong > --- > .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 33 ++++++++++++++++--- > .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 2 +- > .../platform/mtk-vcodec/mtk_vcodec_drv.h | 25 ++++++++++---- > .../platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 4 +-- > .../platform/mtk-vcodec/mtk_vcodec_intr.c | 27 +++++++-------- > .../platform/mtk-vcodec/mtk_vcodec_intr.h | 4 +-- > .../platform/mtk-vcodec/vdec/vdec_h264_if.c | 2 +- > .../mtk-vcodec/vdec/vdec_h264_req_if.c | 2 +- > .../platform/mtk-vcodec/vdec/vdec_vp8_if.c | 2 +- > .../platform/mtk-vcodec/vdec/vdec_vp9_if.c | 2 +- > .../platform/mtk-vcodec/venc/venc_h264_if.c | 2 +- > .../platform/mtk-vcodec/venc/venc_vp8_if.c | 2 +- > 12 files changed, 70 insertions(+), 37 deletions(-) > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > index 95fbe9be3f6d..ac279c2a3f8a 100644 > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > @@ -52,6 +52,20 @@ static int mtk_vcodec_subdev_device_check(struct mtk_vcodec_dev *vdec_dev) > return 0; > } > > +static int mtk_vcodec_get_hw_count(struct mtk_vcodec_dev *dev) > +{ > + switch (dev->vdec_pdata->hw_arch) { > + case MTK_VDEC_PURE_SINGLE_CORE: > + return MTK_VDEC_ONE_CORE; > + case MTK_VDEC_LAT_SINGLE_CORE: > + return MTK_VDEC_ONE_LAT_ONE_CORE; > + default: > + mtk_v4l2_err("not support hw arch:%d", > + dev->vdec_pdata->hw_arch); There's no need to break this line... also, what about changing the message to "hw arch %d not supported"? Apart from that, Reviewed-by: AngeloGioacchino Del Regno _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel