From: Bart Van Assche <bvanassche@acm.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Luis Chamberlain <mcgrof@kernel.org>,
Russ Weight <russell.h.weight@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Jean Delvare <jdelvare@suse.com>, Johan Hovold <johan@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
Karsten Keil <isdn@linux-pingi.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Sebastian Reichel <sre@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Johannes Berg <johannes@sipsolutions.net>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Raed Salem <raeds@nvidia.com>,
Chen Zhongjin <chenzhongjin@huawei.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Avihai Horon <avihaih@nvidia.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Alan Stern <stern@rowland.harvard.edu>,
Colin Ian King <colin.i.king@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Jakob Koschel <jakobkoschel@gmail.com>,
Antoine Tenart <atenart@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Wang Yufen <wangyufen@huawei.com>,
linux-block@vger.kernel.org, linux-media@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-usb@vger.kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/5] driver core: make struct class.dev_uevent() take a const *
Date: Sun, 27 Nov 2022 18:38:39 -0800 [thread overview]
Message-ID: <5b14cdea-1bbe-1900-0004-a218ba97bbcb@acm.org> (raw)
In-Reply-To: <Y4NqAJW5V0tAP8ax@kroah.com>
On 11/27/22 05:45, Greg Kroah-Hartman wrote:
> On Fri, Nov 25, 2022 at 03:51:11PM -0800, Bart Van Assche wrote:
>> On 11/23/22 04:25, Greg Kroah-Hartman wrote:
>>> diff --git a/include/linux/mISDNif.h b/include/linux/mISDNif.h
>>> index 7dd1f01ec4f9..7aab4a769736 100644
>>> --- a/include/linux/mISDNif.h
>>> +++ b/include/linux/mISDNif.h
>>> @@ -586,7 +586,7 @@ extern struct mISDNclock *mISDN_register_clock(char *, int, clockctl_func_t *,
>>> void *);
>>> extern void mISDN_unregister_clock(struct mISDNclock *);
>>> -static inline struct mISDNdevice *dev_to_mISDN(struct device *dev)
>>> +static inline struct mISDNdevice *dev_to_mISDN(const struct device *dev)
>>> {
>>> if (dev)
>>> return dev_get_drvdata(dev);
>>
>> Why does the dev_to_mISDN() function drop constness? I haven't found an
>> explanation for this in the cover letter.
>
> I agree, this is going to be fixed up, see the thread starting here:
> https://lore.kernel.org/r/Y34+V2bCDdqujBDk@kroah.com
>
> I'll work on making a const / non const version for these so that we
> don't loose the marking.
>
> Oh wait, no, this function is fine, it's not modifying the device
> structure at all, and only returning the pointer in the private data
> stored in the device. There is no loss of const-ness here.
Hi Greg,
This is what I found in include/linux/mISDNif.h:
struct mISDNdevice {
struct mISDNchannel D;
u_int id;
u_int Dprotocols;
u_int Bprotocols;
u_int nrbchan;
u_char channelmap[MISDN_CHMAP_SIZE];
struct list_head bchannels;
struct mISDNchannel *teimgr;
struct device dev;
};
As one can see 'dev' is a member of struct mISDNdevice. I still think
that dev_to_mISDN() drops constness. Did I perhaps overlook something?
Bart.
next prev parent reply other threads:[~2022-11-28 2:38 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 12:25 [PATCH 1/5] driver core: make struct class.dev_uevent() take a const * Greg Kroah-Hartman
2022-11-23 12:25 ` [PATCH 2/5] driver core: make struct class.devnode() " Greg Kroah-Hartman
2022-11-23 12:25 ` Greg Kroah-Hartman
2022-11-23 12:25 ` Greg Kroah-Hartman
2022-11-23 12:25 ` Greg Kroah-Hartman
2022-11-25 11:55 ` Mauro Carvalho Chehab
2022-11-25 11:55 ` Mauro Carvalho Chehab
2022-11-25 11:55 ` Mauro Carvalho Chehab
2022-11-25 12:40 ` Sumit Semwal
2022-11-25 12:40 ` Sumit Semwal
2022-11-25 12:40 ` Sumit Semwal
2022-11-23 12:25 ` [PATCH 3/5] driver core: make struct device_type.uevent() " Greg Kroah-Hartman
2022-11-23 12:25 ` Greg Kroah-Hartman
2022-11-23 12:25 ` Greg Kroah-Hartman
2022-11-23 12:38 ` Rafael J. Wysocki
2022-11-23 12:38 ` Rafael J. Wysocki
2022-11-23 12:38 ` Rafael J. Wysocki
2023-01-11 9:51 ` Greg Kroah-Hartman
2023-01-11 9:51 ` Greg Kroah-Hartman
2023-01-11 9:51 ` Greg Kroah-Hartman
2022-11-23 13:14 ` Maximilian Luz
2022-11-23 13:14 ` Maximilian Luz
2022-11-23 13:14 ` Maximilian Luz
2022-11-23 13:34 ` Andy Shevchenko
2022-11-23 13:34 ` Andy Shevchenko
2022-11-23 13:34 ` Andy Shevchenko
2022-11-23 13:59 ` Maximilian Luz
2022-11-23 13:59 ` Maximilian Luz
2022-11-23 13:59 ` Maximilian Luz
2022-11-23 14:52 ` Matthew Wilcox
2022-11-23 14:52 ` Matthew Wilcox
2022-11-23 14:52 ` Matthew Wilcox
2022-11-23 15:14 ` Maximilian Luz
2022-11-23 15:14 ` Maximilian Luz
2022-11-23 15:14 ` Maximilian Luz
2022-11-23 15:37 ` Greg Kroah-Hartman
2022-11-23 15:37 ` Greg Kroah-Hartman
2022-11-23 15:37 ` Greg Kroah-Hartman
2022-11-23 15:48 ` Maximilian Luz
2022-11-23 15:48 ` Maximilian Luz
2022-11-23 15:48 ` Maximilian Luz
2022-11-23 15:52 ` Greg Kroah-Hartman
2022-11-23 15:52 ` Greg Kroah-Hartman
2022-11-23 15:52 ` Greg Kroah-Hartman
2022-11-23 16:25 ` Jason Gunthorpe
2022-11-23 16:25 ` Jason Gunthorpe
2022-11-23 16:25 ` Jason Gunthorpe
2022-11-23 17:01 ` Greg Kroah-Hartman
2022-11-23 17:01 ` Greg Kroah-Hartman
2022-11-23 17:01 ` Greg Kroah-Hartman
2022-11-23 17:29 ` Jason Gunthorpe
2022-11-23 17:29 ` Jason Gunthorpe
2022-11-23 17:29 ` Jason Gunthorpe
2022-11-23 17:49 ` Matthew Wilcox
2022-11-23 17:49 ` Matthew Wilcox
2022-11-23 17:49 ` Matthew Wilcox
2022-11-23 17:55 ` Jason Gunthorpe
2022-11-23 17:55 ` Jason Gunthorpe
2022-11-23 17:55 ` Jason Gunthorpe
2022-11-23 18:00 ` Matthew Wilcox
2022-11-23 18:00 ` Matthew Wilcox
2022-11-23 18:00 ` Matthew Wilcox
2022-12-01 18:43 ` Greg Kroah-Hartman
2022-12-01 18:43 ` Greg Kroah-Hartman
2022-12-01 18:43 ` Greg Kroah-Hartman
2022-11-23 18:10 ` Greg Kroah-Hartman
2022-11-23 18:10 ` Greg Kroah-Hartman
2022-11-23 18:10 ` Greg Kroah-Hartman
2022-11-23 18:25 ` Jason Gunthorpe
2022-11-23 18:25 ` Jason Gunthorpe
2022-11-23 18:25 ` Jason Gunthorpe
2022-11-23 19:06 ` Greg Kroah-Hartman
2022-11-23 19:06 ` Greg Kroah-Hartman
2022-11-23 19:06 ` Greg Kroah-Hartman
2022-11-23 23:24 ` Barnabás Pőcze
2022-11-23 23:24 ` Barnabás Pőcze
2022-11-23 23:24 ` Barnabás Pőcze
2022-11-23 13:56 ` Mika Westerberg
2022-11-23 13:56 ` Mika Westerberg
2022-11-23 13:56 ` Mika Westerberg
2023-01-11 9:52 ` Greg Kroah-Hartman
2023-01-11 9:52 ` Greg Kroah-Hartman
2023-01-11 9:52 ` Greg Kroah-Hartman
2022-11-25 11:56 ` Mauro Carvalho Chehab
2022-11-25 11:56 ` Mauro Carvalho Chehab
2022-11-25 11:56 ` Mauro Carvalho Chehab
2023-01-11 9:52 ` Greg Kroah-Hartman
2023-01-11 9:52 ` Greg Kroah-Hartman
2023-01-11 9:52 ` Greg Kroah-Hartman
2022-11-23 12:25 ` [PATCH 4/5] driver core: make struct device_type.devnode() " Greg Kroah-Hartman
2022-11-23 19:23 ` Dan Williams
2023-01-11 9:46 ` Greg Kroah-Hartman
2022-11-23 12:25 ` [PATCH 5/5] driver core: device_get_devnode() should " Greg Kroah-Hartman
2022-11-23 12:39 ` Rafael J. Wysocki
2022-11-23 13:36 ` Andy Shevchenko
2023-01-11 9:47 ` Greg Kroah-Hartman
2022-11-23 12:38 ` [PATCH 1/5] driver core: make struct class.dev_uevent() " Rafael J. Wysocki
2022-11-24 15:03 ` Sebastian Reichel
2022-11-25 11:54 ` Mauro Carvalho Chehab
2022-11-25 23:51 ` Bart Van Assche
2022-11-27 13:45 ` Greg Kroah-Hartman
2022-11-28 2:38 ` Bart Van Assche [this message]
2022-11-28 17:25 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b14cdea-1bbe-1900-0004-a218ba97bbcb@acm.org \
--to=bvanassche@acm.org \
--cc=atenart@kernel.org \
--cc=avihaih@nvidia.com \
--cc=axboe@kernel.dk \
--cc=chenzhongjin@huawei.com \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=isdn@linux-pingi.de \
--cc=jakobkoschel@gmail.com \
--cc=jdelvare@suse.com \
--cc=jgg@ziepe.ca \
--cc=johan@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kbusch@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mcgrof@kernel.org \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=raeds@nvidia.com \
--cc=rafael@kernel.org \
--cc=russell.h.weight@intel.com \
--cc=sagi@grimberg.me \
--cc=sre@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=wangyufen@huawei.com \
--cc=willy@infradead.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.