From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "jandryuk@gmail.com" <jandryuk@gmail.com>,
Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH] xsm/flask: code style formatting
Date: Fri, 22 Apr 2022 23:07:27 +0000 [thread overview]
Message-ID: <5b199cfb-98c8-c382-82b3-a60819a0e977@citrix.com> (raw)
In-Reply-To: <20220422194344.9318-1-dpsmith@apertussolutions.com>
On 22/04/2022 20:43, Daniel P. Smith wrote:
> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> index 0bf63ffa84..e2ebbc7716 100644
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -120,8 +121,8 @@ static int get_irq_sid(int irq, u32 *sid, struct avc_audit_data *ad)
> struct irq_desc *desc = irq_to_desc(irq);
> if ( desc->msi_desc && desc->msi_desc->dev ) {
> struct pci_dev *dev = desc->msi_desc->dev;
> - u32 sbdf = (dev->seg << 16) | (dev->bus << 8) | dev->devfn;
> - if (ad) {
> + uint32_t sbdf = (dev->seg << 16) | (dev->bus << 8) | dev->devfn;
> + if ( ad ) {
Brace on newline, and in the subsequent hunk. Can be fixed on commit.
Otherwise, LGTM. Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2022-04-22 23:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 19:43 [PATCH] xsm/flask: code style formatting Daniel P. Smith
2022-04-22 23:07 ` Andrew Cooper [this message]
2022-04-25 19:36 ` Jason Andryuk
2022-04-26 8:38 ` Jan Beulich
2022-04-26 10:49 ` Daniel P. Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b199cfb-98c8-c382-82b3-a60819a0e977@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=dpsmith@apertussolutions.com \
--cc=jandryuk@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.