All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH] net/ftgmac100: Rewrite the driver
Date: Tue, 28 Mar 2017 18:41:41 +0200	[thread overview]
Message-ID: <5b1b8621-c20d-f100-0875-8f2264d70e8e@kaod.org> (raw)
In-Reply-To: <f5146202-a82d-17b3-2e23-7b8954aa4092@kaod.org>


>>>> It does that by, among other things, rewriting the receive and
>>>> transmit code, to both simplify the fast path as much as possible,
>>>> avoid flushing of the caches (the aspeed chips have really slow
>>>> little ARM cores), implementing support for fragmented sends,
>>>> fixing HW checksum generation (AST2500 only), etc...
>>>>
>>>> In addition, I've added netpoll support, tx timeout recovery,
>>>> better handling of link speed changes, multicast filter
>>>> and promisc support, various ethtool config additions etc...
>>>
>>> Nice. So I will need to update the QEMU model as it is quite 
>>> basic for the moment.
>>
>> You will need to support fragmented sends yes ;-)
> 
> among other things yes ... I will add that on the TODO list. Anyhow
> the model needed some cleanups. 

The fragmented tx was not taking into account the full size of 
the frame ... That is fixed now and I also added cksum offload 
support for the AST2500. So the new and old n/w drivers are now
supported in QEMU, in a very basic way. no nifty tuning.

I reworked a bit the way the rx queue is flushed but this is not 
enough to support iperf yet. it needs more work to sustain high 
throughput. U-Boot support would be nice also but I think we will 
need a more complete NCSI model. 

Cheers,

C. 
 

  parent reply	other threads:[~2017-03-28 16:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27 10:28 [PATCH] net/ftgmac100: Rewrite the driver Benjamin Herrenschmidt
2017-03-27 13:52 ` Cédric Le Goater
2017-03-27 21:14   ` Benjamin Herrenschmidt
2017-03-28  6:28     ` Cédric Le Goater
2017-03-28  6:32       ` Benjamin Herrenschmidt
2017-03-28  6:47         ` Cédric Le Goater
2017-03-28  6:59           ` Cédric Le Goater
2017-03-28  8:45             ` Benjamin Herrenschmidt
2017-03-29  3:42               ` Joel Stanley
2017-03-28 16:41       ` Cédric Le Goater [this message]
2017-03-28 20:35         ` Benjamin Herrenschmidt
2017-03-29 16:12         ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b1b8621-c20d-f100-0875-8f2264d70e8e@kaod.org \
    --to=clg@kaod.org \
    --cc=benh@kernel.crashing.org \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.