From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7505C43463 for ; Mon, 21 Sep 2020 11:50:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75C722076E for ; Mon, 21 Sep 2020 11:50:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="eemjFo0N" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726430AbgIULul (ORCPT ); Mon, 21 Sep 2020 07:50:41 -0400 Received: from m42-4.mailgun.net ([69.72.42.4]:57136 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726375AbgIULuk (ORCPT ); Mon, 21 Sep 2020 07:50:40 -0400 X-Greylist: delayed 319 seconds by postgrey-1.27 at vger.kernel.org; Mon, 21 Sep 2020 07:50:39 EDT DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1600689040; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=u4Z+XoZMH7rS4HZ2AhmWXEKDfVhLbPPjNUMsiTu8wuY=; b=eemjFo0NiKp0BIeqJRe4tYhlnsHvnLSSSsqTC+GPLNKxvxhLbsvdO2Kp8N+h22p8nWqTeuTy ISZRLRvck5obFY2BPjdUm0n1QwcGsJ1Wyu3Hj4Sll7m4MMb7FGJmqwqgyQOpN2zBSPy5sw7O BSEEc7Os9no5KUtVMb6emG9l41U= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI5ZGU3NiIsICJsaW51eC1pMmNAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 5f68924c6b1937bb6501ddbb (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 21 Sep 2020 11:45:16 GMT Sender: akashast=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D0E8DC433CB; Mon, 21 Sep 2020 11:45:16 +0000 (UTC) Received: from [192.168.1.100] (unknown [47.8.50.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: akashast) by smtp.codeaurora.org (Postfix) with ESMTPSA id BAB23C433CA; Mon, 21 Sep 2020 11:45:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BAB23C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=akashast@codeaurora.org Subject: Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ To: Wolfram Sang Cc: Barry Song , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com, Gregory CLEMENT , =?UTF-8?Q?Andreas_F=c3=a4rber?= , Manivannan Sadhasivam , Mukesh Savaliya , Andy Gross , Bjorn Andersson References: <20200909041001.5612-1-song.bao.hua@hisilicon.com> <24424594-963c-c744-846f-cf79b6024b1c@codeaurora.org> <20200921093433.GH1840@ninjato> From: Akash Asthana Message-ID: <5b1ee0bb-c496-fe48-e7ea-7d89377ae60d@codeaurora.org> Date: Mon, 21 Sep 2020 17:14:59 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200921093433.GH1840@ninjato> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi Wolfram, On 9/21/2020 3:04 PM, Wolfram Sang wrote: > On Thu, Sep 10, 2020 at 05:10:20PM +0530, Akash Asthana wrote: >> On 9/9/2020 9:40 AM, Barry Song wrote: >>> The code has been in a irq-disabled context since it is hard IRQ. There >>> is no necessity to do it again. >>> >>> Cc: Gregory CLEMENT >>> Cc: "Andreas Färber" >>> Cc: Manivannan Sadhasivam >>> Cc: Akash Asthana >>> Cc: Mukesh Savaliya >>> Cc: Andy Gross >>> Cc: Bjorn Andersson >>> Signed-off-by: Barry Song >>> --- >> Reviewed-by: Akash Asthana > Thanks! Did you review the whole patch or only the qcom-geni part? I reviewed the whole patch. > (and please don't include the full message when you only reply to a part > of it). Sure thanks. Regards, Akash -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B468C43463 for ; Mon, 21 Sep 2020 11:46:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8D2A20EDD for ; Mon, 21 Sep 2020 11:46:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ee+B7+Af"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Qwv+Jhr6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8D2A20EDD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gxsd8ryhM1sSC7y70LPsdWMqbnOESJ5a5ZSPFKMa8qo=; b=ee+B7+AfIBZ4a7W5WGXvkVgbN JnXyAiZYHSmaTuwGgUmKtU8sYkfX8A9q/0e4+5tqNNQfo2uuR6VLIgSCPN8hWwUjuyM8AcBfHZYB2 NHsBTMovsbzQA90i5uzAkE7Xow0DAby+m7PrfxxnpvB4UuZU56nMTLFB48+KxgyGQxo224onlIjH8 3mPrMw0LrJwpE7PxAkUTNT1bkXMTB8tBenfLbYo1umhqc96JMDBgDalyW+AKnYzE2wPJNxTahnytT u54e7se6MfzhWMm0N8d/vLg7Cwj0sKKhVvZhp3FESVWefz9mPXTIWcS18nDhWXyYPq00DKbnfOu2V 21dBv5gWg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKKG6-0007T7-67; Mon, 21 Sep 2020 11:45:26 +0000 Received: from z5.mailgun.us ([104.130.96.5]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKKG3-0007SY-Cg for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 11:45:24 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1600688723; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=u4Z+XoZMH7rS4HZ2AhmWXEKDfVhLbPPjNUMsiTu8wuY=; b=Qwv+Jhr6gHxkpLdmYnTBsMnqidqFAGvdOoTE0u5dIC/vFHIukNZ7YtJ93N2/Z/81AsXhUO0R iWaGkHZL+qrwTxwazBTBEMeHG2lKp4c9ke4D4QP4Khe6qGqf7TFNWbolOM7RO+ACIWS4Ay8z zgmbzzD12ryM2rgq2DC9GVpGVsM= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 5f68924d0049ea5816bbff99 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 21 Sep 2020 11:45:17 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E8DF2C433FE; Mon, 21 Sep 2020 11:45:16 +0000 (UTC) Received: from [192.168.1.100] (unknown [47.8.50.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: akashast) by smtp.codeaurora.org (Postfix) with ESMTPSA id BAB23C433CA; Mon, 21 Sep 2020 11:45:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BAB23C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=akashast@codeaurora.org Subject: Re: [PATCH] i2c: busses: replace spin_lock_irqsave by spin_lock in hard IRQ To: Wolfram Sang References: <20200909041001.5612-1-song.bao.hua@hisilicon.com> <24424594-963c-c744-846f-cf79b6024b1c@codeaurora.org> <20200921093433.GH1840@ninjato> From: Akash Asthana Message-ID: <5b1ee0bb-c496-fe48-e7ea-7d89377ae60d@codeaurora.org> Date: Mon, 21 Sep 2020 17:14:59 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200921093433.GH1840@ninjato> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_074523_832336_1101C5FF X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Barry Song , Gregory CLEMENT , linuxarm@huawei.com, Bjorn Andersson , Andy Gross , linux-i2c@vger.kernel.org, Manivannan Sadhasivam , Mukesh Savaliya , =?UTF-8?Q?Andreas_F=c3=a4rber?= , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgV29sZnJhbSwKCk9uIDkvMjEvMjAyMCAzOjA0IFBNLCBXb2xmcmFtIFNhbmcgd3JvdGU6Cj4g T24gVGh1LCBTZXAgMTAsIDIwMjAgYXQgMDU6MTA6MjBQTSArMDUzMCwgQWthc2ggQXN0aGFuYSB3 cm90ZToKPj4gT24gOS85LzIwMjAgOTo0MCBBTSwgQmFycnkgU29uZyB3cm90ZToKPj4+IFRoZSBj b2RlIGhhcyBiZWVuIGluIGEgaXJxLWRpc2FibGVkIGNvbnRleHQgc2luY2UgaXQgaXMgaGFyZCBJ UlEuIFRoZXJlCj4+PiBpcyBubyBuZWNlc3NpdHkgdG8gZG8gaXQgYWdhaW4uCj4+Pgo+Pj4gQ2M6 IEdyZWdvcnkgQ0xFTUVOVCA8Z3JlZ29yeS5jbGVtZW50QGJvb3RsaW4uY29tPgo+Pj4gQ2M6ICJB bmRyZWFzIEbDpHJiZXIiIDxhZmFlcmJlckBzdXNlLmRlPgo+Pj4gQ2M6IE1hbml2YW5uYW4gU2Fk aGFzaXZhbSA8bWFuaXZhbm5hbi5zYWRoYXNpdmFtQGxpbmFyby5vcmc+Cj4+PiBDYzogQWthc2gg QXN0aGFuYSA8YWthc2hhc3RAY29kZWF1cm9yYS5vcmc+Cj4+PiBDYzogTXVrZXNoIFNhdmFsaXlh IDxtc2F2YWxpeUBjb2RlYXVyb3JhLm9yZz4KPj4+IENjOiBBbmR5IEdyb3NzIDxhZ3Jvc3NAa2Vy bmVsLm9yZz4KPj4+IENjOiBCam9ybiBBbmRlcnNzb24gPGJqb3JuLmFuZGVyc3NvbkBsaW5hcm8u b3JnPgo+Pj4gU2lnbmVkLW9mZi1ieTogQmFycnkgU29uZyA8c29uZy5iYW8uaHVhQGhpc2lsaWNv bi5jb20+Cj4+PiAtLS0KPj4gUmV2aWV3ZWQtYnk6IEFrYXNoIEFzdGhhbmEgPGFrYXNoYXN0QGNv ZGVhdXJvcmEub3JnPgo+IFRoYW5rcyEgRGlkIHlvdSByZXZpZXcgdGhlIHdob2xlIHBhdGNoIG9y IG9ubHkgdGhlIHFjb20tZ2VuaSBwYXJ0PwpJIHJldmlld2VkIHRoZSB3aG9sZSBwYXRjaC4KPiAo YW5kIHBsZWFzZSBkb24ndCBpbmNsdWRlIHRoZSBmdWxsIG1lc3NhZ2Ugd2hlbiB5b3Ugb25seSBy ZXBseSB0byBhIHBhcnQKPiBvZiBpdCkuCgpTdXJlIHRoYW5rcy4KClJlZ2FyZHMsCgpBa2FzaAoK LS0gClRoZSBRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiB0 aGUgQ29kZSBBdXJvcmEgRm9ydW0sXG5hIExpbnV4IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQ cm9qZWN0CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo=