From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B67D2C43381 for ; Tue, 2 Apr 2019 08:03:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85FA220830 for ; Tue, 2 Apr 2019 08:03:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554192183; bh=t2qFbe19O35nJOn0zDIVazGrzSn3miwc0jREppNxx8g=; h=Subject:To:Cc:References:From:Reply-To:Date:In-Reply-To:List-ID: From; b=cdxbnkaVgopnmMY0cvu7naxqh74AQcxmrtwVcPuJtX1QIr1VkiqzHhn1VZ9MWf3OY UhC+sdhl0PzsdqXSoaTFtxeU841iTC3T3dywVMxCjCFQp/gbE7gWu3cn1YK/53Ev1u UFjgGPAcc2dQpMMks3Cjn/Jhnt8QxUHPubZg96yI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728875AbfDBIDC (ORCPT ); Tue, 2 Apr 2019 04:03:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:41230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbfDBIDB (ORCPT ); Tue, 2 Apr 2019 04:03:01 -0400 Received: from [10.71.11.124] (unknown [147.50.13.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6AA6020856; Tue, 2 Apr 2019 08:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554192180; bh=t2qFbe19O35nJOn0zDIVazGrzSn3miwc0jREppNxx8g=; h=Subject:To:Cc:References:From:Reply-To:Date:In-Reply-To:From; b=KQ2jbCI+dFCDg04aay0pZE9/F4IH50XMQWuxGb3HkyCbkv5n5BUwF0l86ciMRHSz2 fnngsjSVi8Pb1oggdzJDhFObVtcKCkFt1CK94ASDBe6BXZ2dpE5NF3GOTfkegkW6X1 V9wIGYkdCO5yAy7t6ZxlwkQcCfbRF8V4okv+THQc= Subject: Re: [PATCH 4/6] kbuild: mkmakefile: generate a simple wrapper of top Makefile To: Masahiro Yamada , linux-kbuild@vger.kernel.org Cc: Michal Marek , linux-kernel@vger.kernel.org References: <1553947458-8311-1-git-send-email-yamada.masahiro@socionext.com> <1553947458-8311-4-git-send-email-yamada.masahiro@socionext.com> From: Kieran Bingham Reply-To: kbingham@kernel.org Openpgp: preference=signencrypt Message-ID: <5b2191d5-1fde-1ccd-023b-bd0de292c4b8@kernel.org> Date: Tue, 2 Apr 2019 15:02:55 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1553947458-8311-4-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yamada-san, On 30/03/2019 12:04, Masahiro Yamada wrote: > Now that Kbuild is able to start from any directory, the generated > Makefile can simply wrap the top Makefile. This is a really nice simplification :) Reviewed-by: Kieran Bingham > Signed-off-by: Masahiro Yamada > --- > > scripts/mkmakefile | 20 ++------------------ > 1 file changed, 2 insertions(+), 18 deletions(-) > > diff --git a/scripts/mkmakefile b/scripts/mkmakefile > index 31de468..4d0faeb 100755 > --- a/scripts/mkmakefile > +++ b/scripts/mkmakefile > @@ -12,22 +12,6 @@ if [ "${quiet}" != "silent_" ]; then > fi > > cat << EOF > Makefile > -# Automatically generated by $0: don't edit > - > -ifeq ("\$(origin V)", "command line") > -VERBOSE := \$(V) > -endif > -ifneq (\$(VERBOSE),1) > -Q := @ > -endif > - > -MAKEFLAGS += --no-print-directory > - > -.PHONY: __sub-make \$(MAKECMDGOALS) > - > -__sub-make: > - \$(Q)\$(MAKE) -C $1 O=\$(CURDIR) \$(MAKECMDGOALS) > - > -\$(filter-out __sub-make, \$(MAKECMDGOALS)): __sub-make > - @: > +# Automatically generated by $(realpath $0): don't edit > +include $(realpath $1/Makefile) > EOF > -- -- Kieran