From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751963AbcFFIDl (ORCPT ); Mon, 6 Jun 2016 04:03:41 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:34894 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbcFFIDe (ORCPT ); Mon, 6 Jun 2016 04:03:34 -0400 Subject: Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block To: "Leizhen (ThunderTown)" , Will Deacon , "Wangkefeng (Kevin)" References: <1464427377-12712-1-git-send-email-thunder.leizhen@huawei.com> <1464427377-12712-3-git-send-email-thunder.leizhen@huawei.com> <574F8DA8.4040503@huawei.com> <20160603094520.GF9915@arm.com> <5754D0E8.8070009@huawei.com> Cc: Rob Herring , devicetree , David Daney , Catalin Marinas , Xinwei Hu , Hanjun Guo , linux-kernel , Robert Richter , Zefan Li , Tianhong Ding , Grant Likely , Ganapatrao Kulkarni , Frank Rowand , linux-arm-kernel From: Hanjun Guo Message-ID: <5b29216c-e059-2a17-b3a4-6f17934e1d71@linaro.org> Date: Mon, 6 Jun 2016 16:03:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <5754D0E8.8070009@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Leizhen, On 2016/6/6 9:24, Leizhen (ThunderTown) wrote: > > > On 2016/6/3 17:45, Will Deacon wrote: >> On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote: >>> On 2016/6/2 4:13, Rob Herring wrote: >>>> I believe you still need this and not the one above. You only need it >>>> within the loop if you return. Otherwise, the last node always need to >>>> be put. >>> >>> OK. Thanks. >>> >>> Addition with Matthias's suggestion, I will move "return" into this patch, >>> so that this of_node_put(np) can be safely removed. >> >> Do you want to include Kefeng's [1] patches in your series too? We don't >> need two sets of related NUMA cleanups :) > > Yes, It's originally suggested by Joe Perches. I think Will suggested us to add Kefeng's NUMA cleanup patches into yours and send a new version, just see comments from Will, > Actually, I see you've already respun the series, do don't worry about > doing another version just for this. Will, correct me if I'm wrong. Thanks Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 From: hanjun.guo@linaro.org (Hanjun Guo) Date: Mon, 6 Jun 2016 16:03:27 +0800 Subject: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block In-Reply-To: <5754D0E8.8070009@huawei.com> References: <1464427377-12712-1-git-send-email-thunder.leizhen@huawei.com> <1464427377-12712-3-git-send-email-thunder.leizhen@huawei.com> <574F8DA8.4040503@huawei.com> <20160603094520.GF9915@arm.com> <5754D0E8.8070009@huawei.com> Message-ID: <5b29216c-e059-2a17-b3a4-6f17934e1d71@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Leizhen, On 2016/6/6 9:24, Leizhen (ThunderTown) wrote: > > > On 2016/6/3 17:45, Will Deacon wrote: >> On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote: >>> On 2016/6/2 4:13, Rob Herring wrote: >>>> I believe you still need this and not the one above. You only need it >>>> within the loop if you return. Otherwise, the last node always need to >>>> be put. >>> >>> OK. Thanks. >>> >>> Addition with Matthias's suggestion, I will move "return" into this patch, >>> so that this of_node_put(np) can be safely removed. >> >> Do you want to include Kefeng's [1] patches in your series too? We don't >> need two sets of related NUMA cleanups :) > > Yes, It's originally suggested by Joe Perches. I think Will suggested us to add Kefeng's NUMA cleanup patches into yours and send a new version, just see comments from Will, > Actually, I see you've already respun the series, do don't worry about > doing another version just for this. Will, correct me if I'm wrong. Thanks Hanjun