From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751058AbeCHUK6 (ORCPT ); Thu, 8 Mar 2018 15:10:58 -0500 Received: from gateway30.websitewelcome.com ([192.185.198.26]:24905 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbeCHUK5 (ORCPT ); Thu, 8 Mar 2018 15:10:57 -0500 Subject: Re: [PATCH v2 0/3] pinctrl: bcm2835: Add brcm,level property To: Stefan Wahren Cc: linus.walleij@linaro.org, eric@anholt.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <431699005.307231.1520086916739@email.1und1.de> <1520216960-19880-1-git-send-email-matheus@castello.eng.br> <821312841.275581.1520423887935@email.1und1.de> <047e47b4-daf7-2ba2-ea86-0060a59049b7@castello.eng.br> <188888639.307907.1520496039100@email.1und1.de> From: Matheus Castello Message-ID: <5b3419be-12ca-75d7-6f5e-d3338ddd7f14@castello.eng.br> Date: Thu, 8 Mar 2018 15:47:22 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <188888639.307907.1520496039100@email.1und1.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - br164.hostgator.com.br X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - castello.eng.br X-BWhitelist: no X-Source-IP: 191.189.21.134 X-Source-L: No X-Exim-ID: 1eu1Vf-000l2Z-GE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.0.11]) [191.189.21.134]:8192 X-Source-Auth: matheus@castello.eng.br X-Email-Count: 5 X-Source-Cap: Y2FzdGUyNDg7Y2FzdGUyNDg7YnIxNjQuaG9zdGdhdG9yLmNvbS5icg== X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stefan, On 03/08/2018 04:00 AM, Stefan Wahren wrote: > Hi Matheus, > >> Matheus Castello hat am 8. März 2018 um 01:12 geschrieben: >> >> >> Hi Stefan, >> >> On 03/07/2018 07:58 AM, Stefan Wahren wrote: >>> Hi Matheus, >>> >>>> Matheus Castello hat am 5. März 2018 um 03:29 geschrieben: >>>> >>>> >>>> Hi Linus and Stefan, >>>> >>>> thanks for the tips. >>>> >>>> This series adds support for generic binding for pinctrl bcm2835 driver, >>>> and add the code for set output buffer of a pin using the output-low and >>>> output-high generic properties. >>>> >>>> Tested on Raspberry Pi Zero W, based on bcm2835 SoC. >>>> >>>> Matheus Castello (3): >>> >>> looks like you missed the changes to the dt binding. Please also add Rob Herring and Mark Rutland to CC. We need a ACK from them. >> >> are you talking about the .dts files? I add an overlay file for my tests. >> I was thinking it would be better to start with this changes in the driver and then in another series to convert to the generic style in the .dts. >> If you find it better already add the conversion also in this series let me know. >> >> I understood that I should put the device tree maintainers in thread only if I were to introduce a new property. As I am using generic properties and not introducing new ones I did not add them. >> Let me know if it is still necessary I stayed in this doubt. > > no this is a misunderstanding. You are changing the DT interface because the driver supports new properties (from driver point of view). The DT users usually look at the binding document [1] not the source code. So you need to extend the binding document before changing the source code within a patch series. At the end we need a DT maintainer's ACK for the binding change. Using the generic properties doesn't allow us to skip this, but it increases the chance of an ACK. > > Btw it's okay to keep the DTS files. > > Stefan > > [1] - https://elixir.bootlin.com/linux/v4.16-rc4/source/Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt > Ok, I got it, thank you, I will work on the patch v3. Best Regards Matheus Castello >> >> Best Regards >> Matheus Castello >>> >>>> pinctrl: bcm2835: switch to GENERIC_PINCONF >>>> pinctrl: bcm2835: Add support for generic pinctrl binding >>>> pinctrl: bcm2835: Add support for output-low output-high properties >>>> >>>> drivers/pinctrl/bcm/Kconfig | 1 + >>>> drivers/pinctrl/bcm/pinctrl-bcm2835.c | 88 +++++++++++++++++++++++------------ >>>> 2 files changed, 60 insertions(+), 29 deletions(-) >>>> >>>> -- >>>> 2.7.4 >>>>