All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Eugene Syromiatnikov <esyr@redhat.com>,
	Matt Johnston <matt@codeconstruct.com.au>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/2] MCTP sockaddr padding check/initialisation fixup
Date: Fri, 05 Nov 2021 08:23:01 +0800	[thread overview]
Message-ID: <5b38692a40561b983f379a2d19de238f444fe50f.camel@codeconstruct.com.au> (raw)
In-Reply-To: <cover.1635965993.git.esyr@redhat.com>

Hi Eugene,

> While the first commit is definitely an ABI breakage, it is proposed
> in hopes that the change is made soon enough (the interface appeared
> only in Linux 5.15) to avoid affecting any existing user space.

Of the two applications that currently use AF_MCTP:

 - one is already zeroing the sockaddr_mctp
 - the other has a fix for two of the potential sendmsg() & bind()
   calls: https://github.com/CodeConstruct/mctp/commit/072bafe7

Given we have a confined set of applications (and users), and they're
both now compatible with this change:

Acked-by: Jeremy Kerr <jk@codeconstruct.com.au>

For both patches.

Cheers,


Jeremy


  parent reply	other threads:[~2021-11-05  0:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 19:09 [PATCH net-next v2 0/2] MCTP sockaddr padding check/initialisation fixup Eugene Syromiatnikov
2021-11-03 19:09 ` [PATCH net-next v2 1/2] mctp: handle the struct sockaddr_mctp padding fields Eugene Syromiatnikov
2021-11-03 19:09 ` [PATCH net-next v2 2/2] mctp: handle the struct sockaddr_mctp_ext padding field Eugene Syromiatnikov
2021-11-04 23:55 ` [PATCH net-next v2 0/2] MCTP sockaddr padding check/initialisation fixup Jakub Kicinski
2021-11-04 23:59   ` Jeremy Kerr
2021-11-05  0:23 ` Jeremy Kerr [this message]
2021-11-05  2:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b38692a40561b983f379a2d19de238f444fe50f.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=davem@davemloft.net \
    --cc=esyr@redhat.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeconstruct.com.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.